I can't just add values to an array and then I want to print the values

Question

/*This is a simple code to add values to an array using c# and then just to print them. But I am having an error in order to do this. What possible error could be? */

        int size = 0, k = 0;
        Console.WriteLine("Enter size of array: ");            
        size = Console.Read();
        string[] array = new string[size];  

        for (int i = 0; i < size; i++)
        {
            Console.WriteLine("Enter at index: {0}", i);
            array[i] = Console.ReadLine();                
        }

        foreach (string s in array)
        {
            Console.WriteLine("Value at index: {0}", k++ + " = " + s);
        }

i have edited actual code now...having problem in first loop — Amir, Feb 20 '13 at 22:45

score 2 · Answer 1 · answered Feb 20 '13 at 22:21

2

k++

in the foreach loop would work.

I would actually just write:

Console.WriteLine("Value at index: {0} = {1}", k++, s);

answered Feb 20 '13 at 22:21

Joe

80,724
18
127
145

yea thats right...i forgot to add k++ while pasting here...having yet same problem – Amir Feb 20 '13 at 22:27
What error are you getting? And can you fix your code above to show what is actually being run then? – jzworkman Feb 20 '13 at 22:28
Your first loop keeps running because your `Console.Read()` call is setting the size to the ascii value of the input instead of the actual number(so 49 for '1', or 52 for '4' in your case). You need to do a `Convert.ToUInt32(Colsole.ReadLine())` instead. – jzworkman Feb 20 '13 at 22:50
Exception problem after changing to [array[i] = Convert.ToUInt32(Colsole.ReadLine()).toString()]!...it says input string was not in correct format – Amir Feb 20 '13 at 22:54
size = Convert.ToInt32(Console.ReadLine()); NOW it worked....thanks allot....u r the hero :) – Amir Feb 20 '13 at 22:59

score 0 · Answer 2 · answered Feb 20 '13 at 22:22

0

Twothings:

1)string[] array = new string[size]; likely to not compile, you can get a negative number

2) Console.WriteLine("Value at index: {0}", k + " = " + s); -> should be i think Console.WriteLine("Value at index: {0}" + k + " = " + s);

answered Feb 20 '13 at 22:22

Ariel Pinchover

654
3
17

The second part of your answer would not work, the `{0}` needs a parameter to be replaced with(after the comma) and is what the `k + " = " + s` would be – jzworkman Feb 20 '13 at 22:24
huh, then c# isnt that close to c/++ after all. its been some time since i learned c#. – Ariel Pinchover Feb 20 '13 at 22:28
It would be better to do Console.WriteLine("Value at index: {0} = {1}", k++, s); which I did but having same prob – Amir Feb 20 '13 at 22:29
maybe you should k++ outside of the writeline? – Ariel Pinchover Feb 20 '13 at 22:31
I wonder why my code put 52 in size as I am entering 4 in console – Amir Feb 20 '13 at 22:31
no I meant when this (size = Console.Read();) executes while debugging, I enter 4 for size in console but it enters 52....why? – Amir Feb 20 '13 at 22:33
1

ascii table. why dont you ReadLine()? – Ariel Pinchover Feb 20 '13 at 22:36
this seems to solve the ascii problem http://stackoverflow.com/questions/9156363/console-readline-add-48-to-int Convert.ToInt32(Console.ReadLine()); – Ariel Pinchover Feb 20 '13 at 22:45
Exception problem now!...it says input string was not in correct format – Amir Feb 20 '13 at 22:51
yea it worked by Convert.ToInt32(Console.ReadLine()); thanks allot – Amir Feb 20 '13 at 23:01
i will do, however, appreciate if you accept this answer, though you dont have to. if not mine, then pick any of the others, to mark this question has been answered. – Ariel Pinchover Feb 21 '13 at 08:45
you click on the 'v' sign next to an answer. – Ariel Pinchover Feb 21 '13 at 09:11

score 0 · Answer 3 · answered Feb 20 '13 at 22:31

I believe that you could achieve what you want by changing the code within your foreach loop as shown below:

Console.WriteLine("Value at index {0}: {1}", k++, s);

(looks like Joe already has this solution in his answer as well).

{0} is a placeholder for the value of the first parameter to the Console.WriteLine method after the format string parameter. {1} is a placeholder for the value of the second parameter to the Console.WriteLine method after the format string parameter.

I'm using k++ to increment the value of k on each iteration of the foreach loop.

A foreach loop simply iterates over an IEnumerable object (or more specifically, an IEnumerable<int> object in this case), and the functionality of an IEnumerable object is that it simply gives you each item in the collection. It has no concept of "index", so if you want to associate an index with each item, then you would need to take care of that yourself.

Note that for some collections, such as arrays and lists, you will always get the items in the order that they exist within those structures. However, the IEnumerable and IEnumerable<T> interfaces by themselves don't necessarily guarantee that you will get the items in any specific order, or that you will get the items in the same order if you loop over them a second time. The order of iteration is determined by the underlying implementation, which is an array of integers (int[]) in this case.

score 0 · Answer 4 · answered Feb 20 '13 at 22:32

0

I think Console.Read() is causing you problems, try ReadLine() instead and convert to Int when necessary, and increment k:

 int size = 0, k = 0;
 Console.WriteLine("Enter size of array: ");
 size = Convert.ToInt32(Console.ReadLine());
 string[] array = new string[size];

 for (int i = 0; i < size; i++)
 {
     Console.WriteLine("Enter at index: {0}", i);
     array[i] = Console.ReadLine();
 }

 foreach (string s in array)
 {
     Console.WriteLine("Value at index: {0}", k + " = " + s);
     k++;
 }

 Console.ReadLine();

answered Feb 20 '13 at 22:32

Colm Prunty

1,595
1
11
29

What do you mean? I put that last Console.ReadLine() in just to keep the console open so you can see the output. Does it do what you want if you take that out? – Colm Prunty Feb 20 '13 at 22:41
having problem now only in first loop...it keeps running on – Amir Feb 20 '13 at 22:47
Does it ask you to enter at index : x where x is more than you entered for the size of the array? – Colm Prunty Feb 20 '13 at 22:48
i.e. have you changed the size line to: size = Convert.ToInt32(Console.ReadLine()); – Colm Prunty Feb 20 '13 at 22:54
size = Convert.ToInt32(Console.ReadLine()); NOW it worked,,,thanks :) – Amir Feb 20 '13 at 22:59
There should be a tick mark next to top left of the answer, in between the up and down arrows. If you click that, it should go green. – Colm Prunty Feb 21 '13 at 09:49

score 0 · Answer 5 · answered Feb 20 '13 at 22:35

0

Why do you use Console.Read()? It reads integers corresponding to each of the characters in the input stream, but not until you press enter (which will in itself send two integers, one 13 and one 10).

Maybe you should use Console.ReadLine() instead?

answered Feb 20 '13 at 22:35

Jeppe Stig Nielsen

60,409
11
110
181

yea ryt...but loop keeps going on – Amir Feb 20 '13 at 22:40
I mean only the first loop – Amir Feb 20 '13 at 22:47
@Amir You still have `Console.Read()` in `size = Console.Read();`. What `size` do you think that gives you? It depends on the codepoint of the first character read from the input stream. Do you want the user to type in a number instead? At least you should write out `size` so the user can see what size he gets. – Jeppe Stig Nielsen Feb 21 '13 at 09:52

score 0 · Answer 6 · answered Feb 20 '13 at 22:50

This works (tested) :

        int size = 0, k = 0;
        Console.WriteLine("Enter size of array: ");
        size = int.Parse(Console.ReadLine());
        string[] array = new string[size];

        for (int i = 0; i < size; i++)
        {
            Console.WriteLine("Enter at index: {0}", i);
            array[i] =  Console.ReadLine();
        }

        foreach (string s in array)
        {
            Console.WriteLine("Value at index: {0} = {1}", k++, s);
        }

        Console.Read();

I can't just add values to an array and then I want to print the values

6 Answers6