How to solve leak in this Code (ARC enabled)?

Question

Here is my Code(ARC enabled) where memory leak is seen.

Please help me to solve this issue.

- (void) setMusic
{      
     /*
     Initialise and set the music for the game.
     */

 NSURL *url = [NSURL fileURLWithPath:[[NSBundle mainBundle] pathForResource:@"actionMusic" ofType:@"caf"]];
NSError *error = nil;
_audioPlayer = [[AVAudioPlayer alloc] initWithContentsOfURL:url error:&error];
if (!error)
{
    _audioPlayer.delegate = self;
    if(_musicFlag)
    {
        [_audioPlayer play];
    }
    [_audioPlayer setNumberOfLoops:INT32_MAX];
}

error = nil;
url =nil;

url = [NSURL fileURLWithPath:[[NSBundle mainBundle] pathForResource:@"pew" ofType:@"wav"]];
_moveMusic = [[AVAudioPlayer alloc] initWithContentsOfURL:url error:&error];

if (!error)
{
    _audioPlayer.delegate = self;
}

error = nil;
url =nil;


url = [NSURL fileURLWithPath:[[NSBundle mainBundle] pathForResource:@"Won" ofType:@"wav"]];
_winningMusic = [[AVAudioPlayer alloc] initWithContentsOfURL:url error:&error];

if (!error)
{
    _winningMusic.delegate = self;
    [_winningMusic setNumberOfLoops:1];
}

}

enter image description here

Comment out things until the memory leak stops. The last line that the memory leak occured on is the cause. — Patashu, Feb 25 '13 at 04:52
What is telling you there's a leak? What line is reported as causing the leak. How are your properties declared? — Hot Licks, Feb 25 '13 at 04:52
Can you share details like what the static analyzer found, what you found in Instruments? — Carl Veazey, Feb 25 '13 at 04:52
Side note: All of your `if` statements are incorrect. You should only check `error` if the return value of the methods is `nil`. So the first should be: `if (_audioPlayer)`. — rmaddy, Feb 25 '13 at 04:53
@Vinu1991 Not at all. I was pointing out an unrelated problem with your code. — rmaddy, Feb 25 '13 at 05:01
@rmaddy so what in this code is leading to memory leak? any idea? — Vinayak Kini, Feb 25 '13 at 05:04
The posted code looks fine. You need to provide better details from Instruments. The screen shot you posted is not helpful. Also, run the analyzer in Xcode. — rmaddy, Feb 25 '13 at 05:06
@rmaddy added one more image that wud be hepful to solve the issue — Vinayak Kini, Feb 25 '13 at 05:13
@Vinu1991 No, that's not helpful either. You need to show the screen where Instruments shows you the line that causes the leak and the line where the memory was allocated. — rmaddy, Feb 25 '13 at 05:16
@Vinu1991 Sorry, those come from the analyzer in Xcode, not Instruments. Go to the Project menu and select Analyze. — rmaddy, Feb 25 '13 at 05:23
@rmaddy static analyser is already set in the project.. it does not show any error nor any warnings! — Vinayak Kini, Feb 25 '13 at 05:24
@rmaddy Leak is due to AVAudioPlayer foundation class i.e in the apple code . Thanks alot for putting in efforts to solve my question. — Vinayak Kini, Feb 27 '13 at 04:51

score 0 · Accepted Answer · edited May 23 '17 at 12:13

0

I found the answer for the leak.

This leak is due to AVAudioPlayer foundation class which is yet to be fixed by Apple.

Thus Usage of AVAudioPlayer foundation class leads to leaks.

Check This link for more detail

edited May 23 '17 at 12:13

Community

1
1

answered Feb 26 '13 at 11:21

Vinayak Kini

2,919
21
35

How to solve leak in this Code (ARC enabled)?

1 Answers1