MySQL/PHP Order By Where

Question

I have the following query -

$query = mysql_query("SELECT * FROM test where admin = 'Yes' order by name = '$_GET[name]' DESC");

while($row = mysql_fetch_array($query))
{
   $id.=$row[id];
}

echo $id;

I want a list of id's starting from the id of the $_GET[name] however it's returning a list with a start name of the row underneath? Any idea's?

Many Thanks.

Please, provide a data set and what result you're getting/what you want. Your code is also vulnerable to SQL injection. Your API is deprecated. All around poor, poor code. — Kermit, Feb 26 '13 at 01:15
Woah! You need to seriously check the security of your code. Not only are you using a deprecated library (`mysql_*`), but your code is seriously vulnerable to SQL injection! — BenM, Feb 26 '13 at 01:15

score 1 · Answer 1 · edited May 25 '19 at 14:28

Use an array
You need to use quotes around colums names

$query = mysql_query("SELECT * FROM test where admin = 'Yes' order by name = '$_GET[name]' DESC");

$ids = array();
while($row = mysql_fetch_array($query))
{
   $ids[] =$row['id'];
}

// Your IDs are now in an array which is easier to work with
print_r($ids);

FYI, you shouldn't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO, or MySQLi - this article will help you decide which. If you choose PDO, here is a good tutorial.

You're also wide open to SQL injections

MySQL/PHP Order By Where

1 Answers1