ReSharper telling me Boolean.TryParse() inside IF statement redundant?

Question

I would like some clarification on the following IF statement. I know this sort of statement can be written in many different ways... that's not what i'm asking. I am really curious why ReSharper 7 is telling me that comparing canceled == true is redundant.

bool canceled;
if (Boolean.TryParse(Request.QueryString["cancel"], out canceled) && 
    canceled == true)
{
    // Transaction canceled...
}

It's my understanding that Boolean.TryParse() will return true/false based on the success of the conversion, not the actual result of the out parameter. Why then would comparing canceled == true be redundant? It very well could be false at that point, right?

It's the use of `== true` that's redundant. You don't need to compare a bool to a bool to have it as a condition. =) — J. Steen, Feb 26 '13 at 17:47

score 11 · Accepted Answer · answered Feb 26 '13 at 17:46

11

Just use

if (Boolean.TryParse(Request.QueryString["cancel"], out canceled) && canceled)
{
    // Transaction canceled...
}

As canceled is not nullable, you don't need to explicitly compare with the true boolean, as (canceled == true) == canceled.

answered Feb 26 '13 at 17:46

ken2k

48,145
10
116
176

Ah, thanks... DOH! I just realized ReSharper is not telling me that the entire `canceled == true` condition is redundant... only the `== true`. – Derek Hunziker Feb 26 '13 at 17:47
check out http://stackoverflow.com/questions/2977365/which-is-clearer-form-ifvalue-or-ifflag-value/2977394#2977394 – Charles Bretana Feb 26 '13 at 17:50

ReSharper telling me Boolean.TryParse() inside IF statement redundant?

1 Answers1