Deleting rows from mysql database

Question

I have a problem deleting rows from table with parameters. Here is the code:

if ($dbProductImageIdNumber) {
$ImagesToDeleteNumber = $dbProductImageIdNumber -1 - $numItemImages;
echo "$dbProductImageIdNumber" . ' ';
echo "$numItemImages" . ' ';
echo "$ImagesToDeleteNumber" . ' ';
echo 'Deleting';
mysql_query("DELETE FROM wp_posts
WHERE post_parent = '$dbProductId' ,ID != '$dbProductThumbnail'");
}

Problem is that != seems to be understood wrongly, maybe I'm dooing syntax mistakes?

Will apreciate any help.

-----EDIT-----

Ok, here what I have now:

if ($dbProductImageIdNumber) {
$ImagesToDeleteNumber = $dbProductImageIdNumber -1 - $numItemImages;
echo "$dbProductImageIdNumber" . ' ';
echo "$numItemImages" . ' ';
echo "$ImagesToDeleteNumber" . ' ';
echo "$dbProductId" . ' ';
echo "$dbProductThumbnail" . ' ';
mysql_query("DELETE FROM wp_posts
WHERE post_parent = '$dbProductId' AND ID != '$dbProductThumbnail'");
}

Example: my $dbProductId is '16' and $dbProductThumbnail '17'. Qestion is, why this command do not delete any row where post_parent is '16' and ID isn't 17? Any leads?

score 3 · Answer 1 · edited May 23 '17 at 11:43

it should be AND and not comma.

DELETE FROM wp_posts
WHERE post_parent = '$dbProductId' AND ID != '$dbProductThumbnail'

As a sidenote, the query is vulnerable with SQL Injection if the value(s) of the variables came from the outside. Please take a look at the article below to learn how to prevent from it. By using PreparedStatements you can get rid of using single quotes around values.

How to prevent SQL injection in PHP?

score 0 · Answer 2 · answered Feb 28 '13 at 09:22

0

Use AND or OR in your WHERE statement

DELETE FROM wp_posts
WHERE post_parent = '$dbProductId' AND ID != '$dbProductThumbnail'

answered Feb 28 '13 at 09:22

Sumit Bijvani

8,154
17
50
82

Updated my post, please look there. `AND` was a mistake, but it didn't help. – Kazik Jarmolovski Feb 28 '13 at 10:47

score 0 · Accepted Answer · answered Feb 28 '13 at 09:53

0

Problem is not != but the problem was that you have used "," instead of AND in your code between post_parent = '$dbProductId' ,ID != '$dbProductThumbnail'"

mysql_query("DELETE FROM wp_posts WHERE post_parent = '$dbProductId' ,ID != '$dbProductThumbnail'"); }

So, corrent syntax is below.

DELETE FROM wp_posts WHERE post_parent = '$dbProductId' AND ID != '$dbProductThumbnail'

answered Feb 28 '13 at 09:53

Jwalin Shah

2,451
1
17
22

Updated my post, please look there. AND was a mistake, but it didn't help. – Kazik Jarmolovski Feb 28 '13 at 10:47
DELETE FROM wp_posts WHERE post_parent = '$dbProductId' AND ID <> '$dbProductThumbnail' – Jwalin Shah Feb 28 '13 at 10:50
With `<>` it deletes everything even a row where `ID` is `$dbProductThumbnail`. – Kazik Jarmolovski Feb 28 '13 at 10:55
Oh, that was my mistake.. `$dbProductThumbnail` was empty. So now it works! :) Thank you very much! It seems all these answers were rigth then, but I suppose I will mark yours as you helped me the most, and as I can see you need rep points the most too. :) – Kazik Jarmolovski Feb 28 '13 at 11:28

Deleting rows from mysql database

3 Answers3