import the list and show to content aswell as foreach name in the list it will add in public string gender

Question

I have 2 problems that I need help with:

The first problem is to show the strings in the list which I have imported from the file. Instead of showing the names, I get the name of the namespace + the name of the class ex. inupp_v9.boy. I've tried to override the strings ToString but then the list doesn't show anything at all after that.

The second thing that I need help is that I need to use gender as an argument in the constructor for the Person class, and that it is appropriate to use an enum for gender. But the problem is that I have no idea for what or how to use it. If anybody can come up with an idea that I can use, and how to use it would be great.

For example I have been thinking to use the gender that when I create a new name it will set the name to either male or female depending on which of the 2 radiobuttons I check. That will then export the name to either the girltxt.file or boytxt.file.

But I don't know how to do that so any example from you guys that I can use works for me.

form:

    private void collectg_Click(object sender, EventArgs e)
    {
        if (_hasBoys)
        {
            return;
        }

        _hasBoys = true;

        List<girl> girls = new List<girl>();

        foreach(var name in System.IO.File.ReadAllLines(@"C:\Path\tofile\girls.txt"))
        {
            girl g = new girl { Name = name };
            girls.Add(g);
        }

        listBox1.DataSource = girls;

    }

    private void collectb_Click(object sender, EventArgs e)
    {
        if (_hasGirls)
        {
            return;
        }

        _hasGirls = true;

        List<boy> boys = new List<boy>();
        foreach (var name in System.IO.File.ReadAllLines(C:\Path\tofile\boys.txt"))
        {
            boy b = new boy { Name = name };
            boys.Add(b);
        }

        listBox1.DataSource = boys;

    }

Classes:

namespace Inlämningsuppgift_v9
{
    class Person
    {
        public string Name { get; set; }

    }

    class girl : Person
    {
        public List<girl> girls { get; set; }

        //public override string  ToString()

        //{
        //    return girls.ToString();
        //}

    }
    class boy : Person
    {
        public List<boy> boys { get; set; }
    }
}

Answer 1

Override ToString method to see name value instead of class name:

class Person
{
    public Gender Gender { get; set; }
    public string Name { get; set; }

    public override string ToString()
    {
        return Name;
    }
}

enum Gender
{
     Male,
     Female
}

How to set gender from derived class:

class Girl : Person
{        
    public Girl()
    {
        Gender = Gender.Female;
    }
}

---

BTW Here is your code simplified:

private void collectg_Click(object sender, EventArgs e)
{
    if (_hasBoys)        
        return;        

    _hasBoys = true;

    listBox1.DataSource = File.ReadAllLines(@"C:\Path\tofile\girls.txt")
                              .Select(line => new Girl { Name = line })
                              .ToList();
}

private void collectb_Click(object sender, EventArgs e)
{
    if (_hasGirls)
        return;

    _hasGirls = true;

    listBox1.DataSource = File.ReadAllLines(@"C:\Path\tofile\boys.txt")
                              .Select(line => new Boy { Name = line })
                              .ToList();
}

Also I suggest you to move hard-coded file names to configuration file. And actually I don't see any reason for separate Girl and Boy classes. I think you can use one Person class here. Like this:

private IEnumerable<Person> GetPersons(Gender gender)
{
    string fileName = // get file name depending on gender
    return File.ReadAllLines(fileName)
               .Select(line => new Person { Name = line, Gender = gender })
               .ToList();
}

Instead of two classes which do not add any data or behavior to base class, you can use creation methods like this:

class Person
{
    public static Person CreateBoy(string name)
    {
        return new Person { Name = name, Gender = Gender.Male };
    }

    public static Person CreateGirl(string name)
    {
        return new Person { Name = name, Gender = Gender.Female };
    }

    public Gender Gender { get; private set; }
    public string Name { get; private set; }

    public override string ToString()
    {
        return Name;
    }
}

Then creating boys will look like: Person.CreateBoy(name)

Answer 2

You're asking a bunch of questions here, but I'll do my best to answer them. If the classes boy and girl are just supposed to have a name attribute which is shown when you call ToString(), I'd do it more like:

class girl : Person
{
    public override string  ToString()

    {
        return Name.ToString(); //ToString is redundant though.
    }

}

I'm not sure why you're putting a List<girl> in the class though, so I've removed it.

You can create an Enum very simply:

enum Gender{
   Male,
   Female
}

and then alter your class to accept a new parameter.

Answer 3

if you read this thread C# List<string> to string with delimiter may be is usefull to your question, also in this website explain ways to call member of a list of string and convert members of list to string http://www.dotnetperls.com/convert-list-string , http://msdn.microsoft.com/en-us/library/system.string.format.aspx Hope that helps.

Answer 4

Yeah, the ToString() on the person should fix your issue on the list box.

You could also set a specific display member.

listBox1.DisplayMember = "Name";

Answer 5

To display the name you can override ToString correctly in the Person class;

public override string ToString()
    {
        return Name;
    }

or set the DisplayMemer of the ListBox to "Name" as Kwel stated

listBox1.DisplayMember = "Name";

? Why do you want your boys and girls have lists of boys and girls? ? Why should gender as parameter in the constructor of Person apply a filter set by RadioButtons?

radioButton1.Checked ... Load girls.txt
radioButton2.Checked .. Load boys.txt