overloaded assignment operator bus error

Question

For some reason my assignment operator produces bus error when I try and use it:

hand1 = hand2;


//overload assignment operator
Hand Hand::operator=(Hand other_hand)
{

    if(&other_hand != this){
        name = other_hand.name;
        cards = other_hand.cards;

    }

    return *this;   
}

The error occurs right after the return statement

You're taking and returning copies, you probably don't want to do that. — Seth Carnegie, Mar 03 '13 at 01:39
Also, can you show us a definition of Hand? It is not clear if either name or cards have memory that needs to be managed i.e. are you doubling deleting something in the destructor? — Shafik Yaghmour, Mar 04 '13 at 01:57

score 1 · Answer 1 · edited May 23 '17 at 12:27

1

First of all assignment should have a signature that looks like this:

Hand & Hand::operator=(const Hand &other_hand)

You probably do not want to passing and returning a copy as was pointed out but also you want to allow operating chaining i.e.:

hand1 = hand2 = hand3 ....

This is a basic reference. Also copy and swap was mentioned, this previous thread does a perfect job of explaining it.

edited May 23 '17 at 12:27

Community

1
1

answered Mar 04 '13 at 01:41

Shafik Yaghmour

154,301
39
440
740

overloaded assignment operator bus error

1 Answers1