App keeps forgetting sharedpreferences on restart

Question

I don't know what to do with it any more

Seems to be working fine with android 3.0 and higher, but on android 2.3.3 every time I launch the application it is asking for the username/password again.

I'm using the shared preferences.

Here is how I save preferences:

        SharedPreferences preferences = MyApplication.getAppContext().getSharedPreferences("athopbalance", MODE_PRIVATE);
        SharedPreferences.Editor editor = preferences.edit();
        editor.putString("username", username).commit();
        editor.putString("password", password).commit();

And here is how I read them:

    SharedPreferences preferences = MyApplication.getAppContext().getSharedPreferences("athopbalance", Context.MODE_PRIVATE);
    String username = preferences.getString("username", "");
    String password = preferences.getString("password", "");

I also tried to save preferences using this code:

        SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(MyApplication.getAppContext());
        SharedPreferences.Editor editor = preferences.edit();
        editor.putString("username", username).commit();
        editor.putString("password", password).commit();

And the read them with this code:

    SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(MyApplication.getAppContext());
    String username = preferences.getString("username", "");
    String password = preferences.getString("password", "");

But it doesn't work either.

The problem is before I restart the application I can see that they are still there. However as soon as I do the restart - I end up with getting "" (empty string) for username and "" for password.

Any ideas would be greatly appreciated

agamov · Answer 1 · 2013-03-03T07:20:21.073

2

public class MyApplication extends Application {
    private static MyApplication instance;

    @Override
    public void onCreate() {
        super.onCreate();
        Log.d(TAG, "onCreate() called");
    }

    public MyApplication() {
        super();
        Log.d(TAG, "Constructor called");
        instance = this;
    }


    public static MyApplication getApplication() {
        if (instance == null) {
            instance = new MyApplication();
        }
        return instance;
    }
}

And usage:

MyApplication.getApplication().getSharedPreferences(MY_PREFERENCES, Context.MODE_PRIVATE)

edited Mar 03 '13 at 07:20

answered Mar 03 '13 at 07:02

agamov

4,407
1
27
31

Your example doesn't save the `new MyApplication` into instance before returning so the caching never happens. – mikebabcock Mar 03 '13 at 07:07

score 1 · Answer 2 · answered Mar 03 '13 at 07:00

1

Try this:

 SharedPreferences preferences = context.getSharedPreferences("YOUR_TAG", 0);
 String username = preferences.getString("username", "");
 String password = preferences.getString("password", "");


  SharedPreferences.Editor editor = preferences.edit();
    editor.putString("username", username).commit();
    editor.putString("password", password).commit();

where context is the context of your app:

  @Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);


        context = this;

answered Mar 03 '13 at 07:00

Gyonder

3,674
7
32
49

Hi, thank you very much for your comment. I'm doing pretty the same in my first example, but I'm afraid it doesn't work – Allan Spreys Mar 03 '13 at 07:08
try with your activity instead of MyApplication. – Gyonder Mar 03 '13 at 07:12
I was calling getApplicationContext() instead of passing the context from the activity. – Alberto M Jul 06 '16 at 07:28

score 1 · Answer 3 · edited May 23 '17 at 11:47

1

You have 2 options:

Get shared preference value during the life-cycle of the activity.
Call .clear before .commit

See my answer:

Android Persistent Checkable Menu in Custom Widget After Reboot Android

edited May 23 '17 at 11:47

Community

1
1

answered May 03 '16 at 08:44

iOSAndroidWindowsMobileAppsDev

2,846
30
32

score 0 · Accepted Answer · answered Mar 03 '13 at 08:29

0

I don't know exactly what happened, but after I've restarted the emulator issue is gone.

Sorry to waste your time

answered Mar 03 '13 at 08:29

Allan Spreys

5,287
5
39
44

Same issue here and it gone after restart just like yours. Really strange… – Victor Jul 23 '15 at 19:02

App keeps forgetting sharedpreferences on restart

4 Answers4

Linked