Getting the error "Java.lang.IllegalStateException Activity has been destroyed" when using tabs with ViewPager

Question

I have an application that consists of using ActionBarSherlock in tab mode.I have 5 tabs and the content of each tab is handled using fragments. For tab2 though, I have a fragment the xml file of which holds a ViewPager element which in turn has some fragment pages. When I initially start the application the application, I am able to switch between tabs no problem but when I press on tab2 for the second time I get the error mentioned above. The main activity is as follows:

public class MainActivity extends SherlockFragmentActivity
{
    @Override
    protected void onCreate(Bundle savedInstanceState) 
    {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        ActionBar actionBar = getSupportActionBar();

        ActionBar.Tab tab1 = actionBar.newTab().setText("Tab1");
        ActionBar.Tab tab3 = actionBar.newTab().setText("Tab3");
        ActionBar.Tab tab2 = actionBar.newTab().setText("Tab2");
        ActionBar.Tab tab4 = actionBar.newTab().setText("Tab4");
        ActionBar.Tab tab5 = actionBar.newTab().setText("Tab5");

        Fragment fragment1 = new Tab1();
        Fragment fragment3 = new Tab3();
        Fragment fragment2 = new Tab2();
        Fragment fragment5 = new Tab5();
        Fragment fragment4 = new Tab4();

        tab1.setTabListener(new MyTabListener(fragment1));
        tab3.setTabListener(new MyTabListener(fragment3));
        tab2.setTabListener(new MyTabListener(fragment2));
        tab5.setTabListener(new MyTabListener(fragment5));
        tab4.setTabListener(new MyTabListener(fragment4));

        actionBar.addTab(tab1);
        actionBar.addTab(tab2);
        actionBar.addTab(tab3);
        actionBar.addTab(tab4);
        actionBar.addTab(tab5); 

        actionBar.setNavigationMode(ActionBar.NAVIGATION_MODE_TABS);
    }

    class MyTabListener implements ActionBar.TabListener
    {
        Fragment fragment;

        public MyTabListener(Fragment fragment)
        {
            this.fragment = fragment;
        }

        @Override
        public void onTabSelected(com.actionbarsherlock.app.ActionBar.Tab tab,FragmentTransaction ft) 
        {
            ft.replace(R.id.fragment_container,fragment);
        }

        @Override
        public void onTabUnselected(com.actionbarsherlock.app.ActionBar.Tab tab,FragmentTransaction ft) 
        {

        }

        @Override
        public void onTabReselected(com.actionbarsherlock.app.ActionBar.Tab tab,FragmentTransaction ft) 
        {

        }
    }
}

The fragment class without the ViewPager is as follows:

public class Tab1 extends Fragment 
{
    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,Bundle savedInstanceState)
    {
        return inflater.inflate(R.layout.activity_tab1, container, false);
    }
}

The fragment class with the ViewPager is as follows:

public class Tab2 extends Fragment 
{
    ViewPager mViewPager;
    private MyFragmentPagerAdapter mMyFragmentPagerAdapter;  
    private static int NUMBER_OF_PAGES = 5;

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,Bundle savedInstanceState)
    {
        View view =  inflater.inflate(R.layout.activity_tab2, container, false); 
        return view;
    }

    @Override
    public void onViewCreated(View view,Bundle savedInstanceState)
    {
        super.onViewCreated(view, savedInstanceState);
        mViewPager = (ViewPager) view.findViewById(R.id.viewpager);
        mMyFragmentPagerAdapter = new MyFragmentPagerAdapter(getChildFragmentManager());  
        mViewPager.setAdapter(mMyFragmentPagerAdapter);  
    }

    private static class MyFragmentPagerAdapter extends FragmentPagerAdapter 
    {    
        public MyFragmentPagerAdapter(FragmentManager fm) 
        {  
             super(fm);  
        }  

        @Override  
        public Fragment getItem(int index) 
        {  
             return PageFragment.newInstance("My Message " + index);
        }  

        @Override  
        public int getCount() 
        {  
             return NUMBER_OF_PAGES;  
        }  
   }
}

From what I've read in different places (and please correct me if I'm wrong), this happens because the fragment manager on the second pass tries to reuse the fragments from the activity which doesn't exist anymore thus giving the error.But I'm not sure why this happens over here since I'm not using fragment activity. According to logcat the error is in the Tab2 class, onViewCreated method on the line that says mViewPager.setAdapter(mMyFragmentPagerAdapter). Any help is greatly appreciated...Thanks.

03-04 12:01:05.468: E/AndroidRuntime(2474): FATAL EXCEPTION: main
03-04 12:01:05.468: E/AndroidRuntime(2474): java.lang.IllegalStateException: Activity has been destroyed
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.support.v4.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:1342)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.support.v4.app.BackStackRecord.commitInternal(BackStackRecord.java:595)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.support.v4.app.BackStackRecord.commitAllowingStateLoss(BackStackRecord.java:578)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.support.v4.app.FragmentPagerAdapter.finishUpdate(FragmentPagerAdapter.java:139)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.support.v4.view.ViewPager.populate(ViewPager.java:1011)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.support.v4.view.ViewPager.populate(ViewPager.java:880)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.support.v4.view.ViewPager.setAdapter(ViewPager.java:433)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at com.example.tabs.Tab2.onViewCreated(Tab2.java:31)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:925)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1088)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.support.v4.app.BackStackRecord.run(BackStackRecord.java:682)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:1444)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.support.v4.app.FragmentManagerImpl$1.run(FragmentManager.java:429)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.os.Handler.handleCallback(Handler.java:587)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.os.Handler.dispatchMessage(Handler.java:92)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.os.Looper.loop(Looper.java:123)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at android.app.ActivityThread.main(ActivityThread.java:3687)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at java.lang.reflect.Method.invokeNative(Native Method)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at java.lang.reflect.Method.invoke(Method.java:507)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:842)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:600)
03-04 12:01:05.468: E/AndroidRuntime(2474):     at dalvik.system.NativeStart.main(Native Method)

So I think I may have found the problem. When looking at the variable mMyFragmentPagerAdapter(class Tab2) through the eclipse debugger, I saw that it had a FragmentManager variable which when clicking on Tab2 for the first time had a field called mActivity which was pointing to MainActivity.But on switching from tab2 to some other tab and looking at mActivity again it had a value of null, which perhaps explains why its giving the error Activity has been destroyed. — Yulric Sequeira, Mar 13 '13 at 01:16

score 286 · Accepted Answer · answered Mar 27 '13 at 10:18

286

This seems to be a bug in the newly added support for nested fragments. Basically, the child FragmentManager ends up with a broken internal state when it is detached from the activity. A short-term workaround that fixed it for me is to add the following to onDetach() of every Fragment which you call getChildFragmentManager() on:

@Override
public void onDetach() {
    super.onDetach();

    try {
        Field childFragmentManager = Fragment.class.getDeclaredField("mChildFragmentManager");
        childFragmentManager.setAccessible(true);
        childFragmentManager.set(this, null);

    } catch (NoSuchFieldException e) {
        throw new RuntimeException(e);
    } catch (IllegalAccessException e) {
        throw new RuntimeException(e);
    }
}

answered Mar 27 '13 at 10:18

Marcus Forsell Stahre

3,766
1
17
14

Thanks a lot.This also seems to work. Is there a reaosn why you are setting the childFragmentManager to null in onDetach()? – Yulric Sequeira Apr 03 '13 at 01:13
21

If you look at the implementation of Fragment, you'll see that when moving to the detached state, it'll reset its internal state. However, it doesn't reset mChildFragmentManager (this is a bug in the current version of the support library). This causes it to not reattach the child fragment manager when the Fragment is reattached, causing the exception you saw. – Marcus Forsell Stahre Apr 03 '13 at 10:32
if we use FragmentStatePagerAdapter in ViewPager, it will crash when adapter tries to restore its data. – handrenliang Jun 25 '13 at 01:12
14

You have got to be kidding me. Glad you found posted this, but good grief. – secureboot Jul 05 '13 at 18:09
2

It's amazing how flakey Android is; I swear it feels like Google just hates developers. – StackOverflowed Aug 27 '13 at 09:04
8

This bug is being tracked in the Android Open Source issue tracker: https://code.google.com/p/android/issues/detail?id=42601 – Kristopher Johnson Nov 08 '13 at 18:46
2

if we use FragmentStatePagerAdapter in ViewPager it crashes: java.lang.NullPointerException E/AndroidRuntime(13225): at android.support.v4.app.FragmentManagerImpl.getFragment(FragmentManager.java:569) E/AndroidRuntime(13225): at android.support.v4.app.FragmentStatePagerAdapter.restoreState(FragmentStatePagerAdapter.java:211) – apinho Mar 18 '14 at 18:31
what's `mChildFragmentManager` supposed to be? – Muhammed Refaat May 07 '14 at 10:59
@MuhammedRefaat that is the actual name in code of the child fragment manager field in the fragment class. – ocross Aug 01 '14 at 22:05
@ocross So, it's the actual name in the fragment class code not my own code? and so it has to be left as it is without any change? – Muhammed Refaat Aug 03 '14 at 10:53
3

A pinch of salt, but this is failing using the support-v4 version or the android.app version. So the bug not only occurs in the support library – gbero Aug 07 '14 at 12:25
1

Not any solution worked for me, i ended up with put it into try-catch... :-( i am using fragment into fragment which is into fragment.!!! another solution worked for me is i was using AsyncTask on start of nested fragment... i stop that asyncTask by calling mAsyncTask.cancel(true); – Rumit Patel Dec 25 '14 at 14:30
@MarcusForsellStahre Could you take a look at this question about ViewPager? Thank you http://stackoverflow.com/questions/27937250/viewpager-on-a-view-added-by-windowmanager-getting-java-lang-illegalargumentexc/27937559 – Hoa Vu Jan 15 '15 at 02:08
2

You saved my life. That issue seems fixed in API > 20, I was so pulling my hair when testing my app with kitkat.. – Kevin Prettre Jul 07 '15 at 10:13
2

Doesn't seem to be fixed in Lollipop!! wow more than 2 years and a half. – Driss Bounouar Dec 15 '15 at 17:19
2

Tried all solutions in [Android Open Source issue tracker](https://code.google.com/p/android/issues/detail?id=42601), as well as this solution, nothing helps. Using the latest Android SDK. Running the code both on API 16 and API 21 device. – azizbekian Dec 22 '15 at 14:13
thanks a lot. For anyone else having the same problem, if the error persists after applying this, you might wanna check if you're removing the fragment with "remove()" instead "detach()" . – Iman Akbari May 14 '16 at 15:19
I was doing this: ` TagCatFragment tagCatFragment = TagCatFragment.newInstance(name, authorId, "Author"); tagCatFragment.show(getChildFragmentManager(), "TagCAatFragment");` and appying this solution. Didn't work. – X09 Jul 06 '16 at 14:56
6

It seems fixed in support library version 24.0.0. The method 'performDetach()', of 'android.support.v4.app.Fragment', do 'mChildFragmentManager = null;'. – Emerson Dallagnol Jul 12 '16 at 22:00
Seems already fixed in this commit, see https://android.googlesource.com/platform/frameworks/base/+/eacacb5%5E%21/#F0 – 林果皞 Nov 21 '18 at 09:38
2

Is this still necessary or fixed in `androidx`? – virengujariya Jan 18 '19 at 18:48
You sir are a life savior! – Syed Arsalan Kazmi Jan 30 '20 at 15:37
Going to emphasis word **BUG** from original answer. Anyone still using this, even if it still works, is doing something very wrong. This solution makes framework to crash https://stackoverflow.com/questions/56618453/after-migrating-to-androidx-application-crashes-with-attempt-to-invoke-androidx – Peter Mar 11 '20 at 09:10

score 13 · Answer 2 · answered Mar 19 '13 at 23:53

13

I'm having exactly the same problem. The only workaround I've found, is to replace the fragments by a new instance, each time the tabs are changed.

ft.replace(R.id.fragment_container, Fragment.instantiate(PlayerMainActivity.this, fragment.getClass().getName()));

Not a real solution, but i haven't found a way to reuse the previous fragment instance...

answered Mar 19 '13 at 23:53

jekatt

221
2
6

1

Wow thanks a lot...that fixed the problem.Is it possible to give a explanation why it works?I was breaking my head trying to fix the error using the FragmentManager. – Yulric Sequeira Mar 24 '13 at 19:53
1

Have you analyzed your memory footprint? Because this workaround may increase it, at-least i suspect – nmxprime Nov 20 '14 at 05:07
dont know why it works..dont know how it works but it works lol – Jan 27 '17 at 10:39

score 7 · Answer 3 · edited Nov 08 '16 at 11:31

7

I encountered the same issue when calling super.onCreate() at the end of my method. The reason: attachActivity() is called in onCreate() of FragmentActivity. When overriding onCreate() and, for example, creating tabs, the Tab manager will try to switch to a fragment while not having the activity attached to the FragmentManager.

Simple solution: Move the call to super.onCreate() to the head of the function body.

In general, it seems there are loads of reasons this issue may occur. This is just another one ...

Matthias

edited Nov 08 '16 at 11:31

Lavekush Agrawal

6,040
7
52
85

answered Aug 09 '14 at 11:50

user1050133

324
5
12

Thank you very much, you saved my day! I had the same problem and could still not solve it after one week ;( . So im very happy you wrote this answer!!! – JonasPTFL Apr 15 '19 at 11:45

score 4 · Answer 4 · edited Nov 08 '16 at 11:32

4

Wanted to add that my problem was in an activity where I tried to make a FragmentTransaction in onCreate BEFORE I called super.onCreate(). I just moved super.onCreate() to top of function and was worked fine.

edited Nov 08 '16 at 11:32

Lavekush Agrawal

6,040
7
52
85

answered Jul 17 '14 at 18:28

sgarman

6,152
5
40
44

score 2 · Answer 5 · answered Jan 10 '14 at 14:47

2

I had this error because I was using LocalBroadcastManager and I did:

unregisterReceiver(intentReloadFragmentReceiver);

instead of:

LocalBroadcastManager.getInstance(this).unregisterReceiver(intentReloadFragmentReceiver);

answered Jan 10 '14 at 14:47

Malachiasz

7,126
2
35
49

1

this doesn't solve my prob. But Thanks it helped me to correct my mistakes on using BroadcastReceivers – nmxprime Nov 20 '14 at 05:21
What if your Activity context is null. Then 'this' wouldn't be valid. – IgorGanapolsky Feb 20 '15 at 18:07
when Activities context can be null? I think never. – Malachiasz Feb 23 '15 at 09:56

score 2 · Answer 6 · answered Dec 19 '14 at 06:41

2

I encountered the same issue and lateron found out that, I have missed call to super.onCreate( savedInstanceState ); in onCreate() of FragmentActivity.

answered Dec 19 '14 at 06:41

Swapnil Chaudhari

542
5
23

score 1 · Answer 7 · answered May 13 '14 at 06:03

I got the very same error when trying to access the child FragmentManager before the fragment was fully initialized (i.e. attached to the Activity or at least onCreateView() called). Else the FragmentManager gets initialized with a null Activity causing the aforementioned exception.

score 1 · Answer 8 · answered Jul 30 '15 at 17:17

1

I force the fragment containing the child fragment to NULL in onPause and it fixes my problem

fragment = null;

answered Jul 30 '15 at 17:17

MobileMon

8,341
5
56
75

score 1 · Answer 9 · answered Jul 15 '16 at 08:05

I know this is an old post, but the suggested answers didn't work on my end. I want to leave this here just in case someone will find it useful.

What i did is:

@Override
public void onResume() {
    super.onResume();
    // add all fragments
    FragmentTransaction fragmentTransaction = getChildFragmentManager().beginTransaction();
    for(Fragment fragment : fragmentPages){
        String tag = fragment.getClass().getSimpleName();
        fragmentTransaction.add(R.id.contentPanel, fragment, tag);
        if(fragmentPages.indexOf(fragment) != currentPosition){
            fragmentTransaction.hide(fragment);
        } else {
            lastTag = tag;
        }
    }
    fragmentTransaction.commit();
}

Then in:

@Override
public void onPause() {
    super.onPause();
    // remove all attached fragments
    for(Fragment fragment: fragmentPages){
        getChildFragmentManager().beginTransaction().remove(fragment).commit();
    }
}

score 0 · Answer 10 · answered Apr 03 '14 at 08:48

I had this problem and I couldn't find the solution here, so I want to share my solution in case someone else has this problem again.

I had this code:

public void finishAction() {
  onDestroy();
  finish();
}

and solved the problem by deleting the line "onDestroy();"

public void finishAction() {
  finish();
}

The reason I wrote the initial code: I know that when you execute "finish()" the activity calls "onDestroy()", but I'm using threads and I wanted to ensure that all the threads are destroyed before starting the next activity, and it looks like "finish()" is not always immediate. I need to process/reduce a lot of “Bitmap” and display big “bitmaps” and I’m working on improving the use of the memory in my app

Now I will kill the threads using a different method and I’ll execute this method from "onDestroy();" and when I think I need to kill all the threads.

public void finishAction() {
  onDestroyThreads();
  finish();
}

score 0 · Answer 11 · answered Jun 16 '15 at 15:41

0

I had this issue and realized it was because I was calling setContentView(int id) twice in my Activity's onCreate

answered Jun 16 '15 at 15:41

LukasE078

71
1
8

score 0 · Answer 12 · answered Apr 26 '17 at 08:11

This one drove me crazy for Xamarin.

I ran into this with a ViewPager implementation for TabLayout WITHIN a Fragment, that is itself implemented in the DrawerLayout:

 - DrawerLayout
   - DrawerFragment
     - TabLayout
     - TabViewPager
       - TabViewPagerFragments

So you have to implement the following code in your DrawerFragment. Be aware to choose the correct FragmentManager-Path. Because you might have two different FragmentManager References:

Android.Support.V4.App.FragmentManager
Android.App.FragmentManager

--> Choose the one you use. If you want to make use of the ChildFragmentManager, you had to use the class declaration Android.App.FragmentManager for your ViewPager!

Android.Support.V4.App.FragmentManager

Implement the following Method in your "Main" Fragment - in this example: DrawerFragment

public override void OnDetach() {
    base.OnDetach();
    try {
        Fragment x = this;
        var classRefProp = typeof(Fragment).GetProperty("class_ref", BindingFlags.NonPublic | BindingFlags.Static);
        IntPtr classRef = (IntPtr)classRefProp.GetValue(x);
        var field = JNIEnv.GetFieldID(classRef, "mChildFragmentManager", "Landroid/support/v4/app/FragmentManagerImpl;");
        JNIEnv.SetField(base.Handle, field, IntPtr.Zero);
    }
    catch (Exception e) {
        Log.Debug("Error", e+"");
    }
}

Android.App.FragmentManager

public class TabViewPager: Android.Support.V13.App.FragmentPagerAdapter {}

That means you had to init the ViewPager with Android.App.FragmentManager.

Implement the following Method in your "Main" Fragment - in this example: DrawerFragment

public override void OnDetach() {
    base.OnDetach();
    try {
        Fragment x = this;
        var classRefProp = typeof(Fragment).GetProperty("class_ref", BindingFlags.NonPublic | BindingFlags.Static);
        IntPtr classRef = (IntPtr)classRefProp.GetValue(x);
        var field = JNIEnv.GetFieldID(classRef, "mChildFragmentManager", "Landroid/app/FragmentManagerImpl;");
        JNIEnv.SetField(base.Handle, field, IntPtr.Zero);
    }
    catch (Exception e) {
        Log.Debug("Error", e+"");
    }
}

score 0 · Answer 13 · answered May 21 '20 at 08:00

0

The bug has been fixed in the latest androidx version. And the famous workaround will cause crash now. so we need not it now.

answered May 21 '20 at 08:00

vipcxj

840
5
10

score 0 · Answer 14 · edited Dec 28 '20 at 00:48

0

i found that i had a timer running in the background. when the activity is killed, yet the timer still running. in the timer finish callback i access fragment object to do some work, and here is the bug!!!! the fragment exists but the activity isn't.

if you have service of timer or any background threads, make sure to not access fragments objects.

edited Dec 28 '20 at 00:48

SherylHohman

16,580
17
88
94

answered Dec 28 '20 at 00:23

Baha'a Elden Khalilieh

1

This reads to me more like a Comment, than an Answer. Regardless, however, please note that grammar, punctuation, capitalization, spelling, etc is important. Please edit to fix the issues. You can find more info in the SO help center at StackOverflow.com/help. – SherylHohman Dec 28 '20 at 00:50

Getting the error "Java.lang.IllegalStateException Activity has been destroyed" when using tabs with ViewPager

14 Answers14

Linked

Related