BitmapFactory.decodeStream out of memory despite using reduced sample size

Question

I have read many related posts concerning memory allocation problems with decoding bitmaps, but am still unable to find the solution to the following problem even after using the code provided in the official website.

Here is my code:

public static Bitmap decodeSampledBitmapFromResource(InputStream inputStream, int reqWidth, int reqHeight) {

    ByteArrayOutputStream baos = new ByteArrayOutputStream();
    byte[] buffer = new byte[1024];
    int len;
    try {
        while ((len = inputStream.read(buffer)) > -1) {
        baos.write(buffer, 0, len);
        }
        baos.flush();
        InputStream is1 = new ByteArrayInputStream(baos.toByteArray());
        InputStream is2 = new ByteArrayInputStream(baos.toByteArray());

        final BitmapFactory.Options options = new BitmapFactory.Options();
        options.inJustDecodeBounds = true;
        BitmapFactory.decodeStream(is1, null, options);

        options.inSampleSize = calculateInSampleSize(options, reqWidth, reqHeight);
        options.inPurgeable = true;
        options.inInputShareable = true;
        options.inJustDecodeBounds = false;
        options.inPreferredConfig = Bitmap.Config.ARGB_8888;
        return BitmapFactory.decodeStream(is2, null, options);

    } catch (Exception e) {
        e.printStackTrace();

        return null;
    }
}

public static int calculateInSampleSize(BitmapFactory.Options options, int reqWidth, int reqHeight) {
    // Raw height and width of image
    final int height = options.outHeight;
    final int width = options.outWidth;
    int inSampleSize = 1;

    if (height > reqHeight || width > reqWidth) {

        // Calculate ratios of height and width to requested height and width
        final int heightRatio = Math.round((float) height / (float) reqHeight);
        final int widthRatio = Math.round((float) width / (float) reqWidth);

        // Choose the smallest ratio as inSampleSize value, this will guarantee
        // a final image with both dimensions larger than or equal to the
        // requested height and width.
        inSampleSize = heightRatio < widthRatio ? heightRatio : widthRatio;
    }


    return inSampleSize;
}

bitmap = decodeSampledBitmapFromResource(inputStream, 600, 600);

I am getting "Out of memory error on a 3250016 - byte allocation" in this line:

return BitmapFactory.decodeStream(is2, null, options);

It would seem to me that 3.2 MB is small enough to be allocated. Where am I going wrong? How can I solve this?

EDIT

After looking into this solution HERE by N-Joy it works fine with Required size 300 but my required size is 800, so i am still getting the error.

have a look at these solutions http://stackoverflow.com/questions/10314527/caused-by-java-lang-outofmemoryerror-bitmap-size-exceeds-vm-budget/10408877#10408877 — N-JOY, Mar 07 '13 at 05:41
int inSampleSize = this must be multiple of 2; change this and check it. — Harish, Mar 15 '13 at 12:56

score 36 · Answer 1 · answered Mar 13 '13 at 09:04

The method decodeSampledBitmapFromResource is not memory efficient because it uses 3 streams: the ByteArrayOutputStream baos, ByteArrayInputStream is1 and ByteArrayInputStream is2, each of those stores the same stream data of the image (one byte array for each).

And when I test with my device (LG nexus 4) to decode an 2560x1600 image on SDcard to target size 800 it takes something like this:

03-13 15:47:52.557: E/DecodeBitmap(11177): dalvikPss (beginning) = 1780
03-13 15:47:53.157: E/DecodeBitmap(11177): dalvikPss (decoding) = 26393
03-13 15:47:53.548: E/DecodeBitmap(11177): dalvikPss (after all) = 30401 time = 999

We can see: too much memory allocated (28.5 MB) just to decode 4096000 a pixel image.

Solution: we read the InputStream and store the data directly into one byte array and use this byte array for the rest work.
Sample code:

public Bitmap decodeSampledBitmapFromResourceMemOpt(
            InputStream inputStream, int reqWidth, int reqHeight) {

        byte[] byteArr = new byte[0];
        byte[] buffer = new byte[1024];
        int len;
        int count = 0;

        try {
            while ((len = inputStream.read(buffer)) > -1) {
                if (len != 0) {
                    if (count + len > byteArr.length) {
                        byte[] newbuf = new byte[(count + len) * 2];
                        System.arraycopy(byteArr, 0, newbuf, 0, count);
                        byteArr = newbuf;
                    }

                    System.arraycopy(buffer, 0, byteArr, count, len);
                    count += len;
                }
            }

            final BitmapFactory.Options options = new BitmapFactory.Options();
            options.inJustDecodeBounds = true;
            BitmapFactory.decodeByteArray(byteArr, 0, count, options);

            options.inSampleSize = calculateInSampleSize(options, reqWidth,
                    reqHeight);
            options.inPurgeable = true;
            options.inInputShareable = true;
            options.inJustDecodeBounds = false;
            options.inPreferredConfig = Bitmap.Config.ARGB_8888;

            int[] pids = { android.os.Process.myPid() };
            MemoryInfo myMemInfo = mAM.getProcessMemoryInfo(pids)[0];
            Log.e(TAG, "dalvikPss (decoding) = " + myMemInfo.dalvikPss);

            return BitmapFactory.decodeByteArray(byteArr, 0, count, options);

        } catch (Exception e) {
            e.printStackTrace();

            return null;
        }
    }

The method that does the calculation:

public void onButtonClicked(View v) {
        int[] pids = { android.os.Process.myPid() };
        MemoryInfo myMemInfo = mAM.getProcessMemoryInfo(pids)[0];
        Log.e(TAG, "dalvikPss (beginning) = " + myMemInfo.dalvikPss);

        long startTime = System.currentTimeMillis();

        FileInputStream inputStream;
        String filePath = Environment.getExternalStorageDirectory()
                .getAbsolutePath() + "/test2.png";
        File file = new File(filePath);
        try {
            inputStream = new FileInputStream(file);
//          mBitmap = decodeSampledBitmapFromResource(inputStream, 800, 800);
            mBitmap = decodeSampledBitmapFromResourceMemOpt(inputStream, 800,
                    800);
            ImageView imageView = (ImageView) findViewById(R.id.image);
            imageView.setImageBitmap(mBitmap);
        } catch (FileNotFoundException e) {
            e.printStackTrace();
        }
        myMemInfo = mAM.getProcessMemoryInfo(pids)[0];
        Log.e(TAG, "dalvikPss (after all) = " + myMemInfo.dalvikPss
                + " time = " + (System.currentTimeMillis() - startTime));
    }

And the result:

03-13 16:02:20.373: E/DecodeBitmap(13663): dalvikPss (beginning) = 1823
03-13 16:02:20.923: E/DecodeBitmap(13663): dalvikPss (decoding) = 18414
03-13 16:02:21.294: E/DecodeBitmap(13663): dalvikPss (after all) = 18414 time = 917

Using this I only get a gray/black bitmap and not the picture I was decoding, any idea why? — Donal Rafferty, Jul 31 '13 at 09:57
Fantastic solution, exactly what I was looking for. The only thing I had to change was the fact that I am not storing my files on an external SD Card, therefore simply moved them from my drawable folder to raw folder. — SingleWave Games, Nov 22 '13 at 17:38
This worked for me, for relatively small images (200Kb JPGs). Not tested on huge ones. Thanks anyway. — philippe, Jun 20 '14 at 21:40
How would anyone know the resolution to pass in? I don't want to blindly use any two numbers because that will ruin the aspect ratio of the images. I want to maintain ratio and simply avoid this memory error. — Paul, Mar 03 '15 at 20:27

score 4 · Answer 2 · edited May 23 '17 at 12:18

This is a common issue which user normally faces while playing with large bitmaps and there are lots a questions discussed on site, here, here, here and here and many more, even though user not able to manipulate the exact solution.

I stumbled upon a library sometime back which manages bitmaps smoothly and others links which I listed below. Hope this helps!

smoothie-Library

Android-BitmapCache

Android-Universal-Image-Loader Solution for OutOfMemoryError: bitmap size exceeds VM budget

nidhi_adiga · Answer 3 · 2013-05-16T13:16:28.227

2

ARGB_8888 uses more memory as it takes Alpha color value so my suggestion is to use RGB_565 as stated HERE

Note: Quality will be little low compared to ARGB_8888.

edited May 16 '13 at 13:16

answered Mar 14 '13 at 14:30

nidhi_adiga

1,114
1
16
27

score 1 · Answer 4 · answered Mar 06 '13 at 17:48

1

You're probably holding on to previous bitmap references. I'm guessing that you're executing this code several times and never executing bitmap.recycle(). Memory will inevitably run out.

answered Mar 06 '13 at 17:48

Paul Lammertsma

37,593
16
136
187

Whenever you're done with the bitmap you should recycle it. I can't answer that since I don't know what or how you're using it. – Paul Lammertsma Mar 06 '13 at 17:49
yes i tried your solution but still no luck :( anything else which i am missing? – Goofy Mar 06 '13 at 18:05

score 1 · Answer 5 · answered Mar 07 '13 at 06:09

I had many problems with Bitmap memory usage.

Results:

Most devices have limited heap memory for graphics, most small devices are limited to 16MB for overall apps, not just your app
Use 4 bit or 8 bit or 16 bit bitmaps if applicable
Try to draw shapes from scratch, omit bitmaps if possible.

score 1 · Answer 6 · answered Mar 07 '13 at 06:29

1

Use WebView to dynamically load as many images as you like, it's built using NDK (low level) so has no GDI heap memory restrictions. It works smooth and fast :)

answered Mar 07 '13 at 06:29

AVEbrahimi

17,993
23
107
210

It's great replacement for scrolling images layouts, like ViewFlipper – AVEbrahimi Mar 07 '13 at 06:30

score 1 · Answer 7 · edited May 23 '17 at 10:30

Out of memory problems when decoding bitmaps are not often linked with the image size you are decoding. Of course if you try to open an image 5000x5000px you will fail with a OutOfMemoryError, but with the size of 800x800px it is totally reasonable and should work fine.

If your device is out of memory with a 3.2 MB image it's likely because you are leaking context somewhere in the app.

It's the first part of this post:

I guess problem is not in your layout, problem is somewhere else in your code. and probably you are leaking context somewhere.

What it means it's that you are using Activity Context in components that should not, preventing them to be garbage collected. Because there components often are held by activities, those activities are not GC and your java heap will grow very fast and your app will crash at one time or another.

As Raghunandan said, you will have to use MAT to find wich Activity/Component is held and remove the context leak.

The best way I found for now to detect context leak is orientation change. For example, rotate your ActivityMain multiple times, run MAT and check if you have only one instance of ActivityMain. If you have multiple ones (as much as rotation changes) it means there is a context leak.

I found years ago a good tutorial on using MAT. Maybe there is better one now.

Other posts on memory leaks:

Android - memory leak or?

Out of memory error on android emulator, but not on device

score 0 · Answer 8 · answered Mar 06 '13 at 17:47

0

Have a look at this video. http://www.youtube.com/watch?v=_CruQY55HOk. Do not use system.gc() as suggested in the video. Use a MAT Analyzer to find out memory leaks. The returned bitmap is too huge causing memory leak i guess.

answered Mar 06 '13 at 17:47

Raghunandan

132,755
26
225
256

even if i remove that it will not solve the problem, is there any way please tell i am stuck from long time – Goofy Mar 06 '13 at 17:48
removing won't solve the problem. TO solve ur problem use a mat analyzer to find out how much memory bitmap takes. My guess it takes too much space which causes memory leak. – Raghunandan Mar 06 '13 at 17:57
yes its talking much memory, but how to solve this?thats the big question – Goofy Mar 06 '13 at 18:00
compressing should reduce some memory usage. But if its still huge to cause memory leak i am afraid nothing can be done. Try compressing the bitmap. – Raghunandan Mar 06 '13 at 18:02
how to compress it? and will it reduce the quality? – Goofy Mar 06 '13 at 18:04
Try Paul Lammertsma solution of recycling bitmap when not in use along with solution in the link http://stackoverflow.com/questions/8417034/how-to-make-bitmap-compress-without-change-the-bitmap-size. – Raghunandan Mar 06 '13 at 18:06

score 0 · Answer 9 · edited May 23 '17 at 12:18

0

It seems you have large image to display.

You can download image and save to sdcard (example) then you can user this code to display image from sdcard.

edited May 23 '17 at 12:18

Community

1
1

answered Mar 06 '13 at 17:50

MAC

15,799
8
54
95

That will use *precisely* the same amount of memory as his current implementation, supposing `calculateInSampleSize()` returns `8`. – Paul Lammertsma Mar 06 '13 at 17:52
No i cannot do that because i have around 200 images – Goofy Mar 06 '13 at 17:52
But you have to download only **first time**. Then you can display image from sdcard that will also help you run your app in faster way. – MAC Mar 06 '13 at 17:54
@MAC No there are some issues like what if the user deletes the files from the sdcard? and also it will unnecessary take the space of the users sdcard, – Goofy Mar 06 '13 at 17:56
But if you are gonna use this way it will waste band width and time for each iteration. – MAC Mar 06 '13 at 17:57
Also, you can make the folder as hidden from gallery by writing the folder name as `.FolderName`... – PrincessLeiha Mar 07 '13 at 06:08

score -1 · Answer 10 · edited May 23 '17 at 12:10

i also had same problem earlier.. and i have managed it by using this function where you can get scale as your required width and height.

private Bitmap decodeFile(FileInputStream f)
{
    try
    {
        //decode image size
        BitmapFactory.Options o = new BitmapFactory.Options();
        o.inJustDecodeBounds = true;
        BitmapFactory.decodeStream(f,null,o);

        //Find the correct scale value. It should be the power of 2.
        final int REQUIRED_SIZE=70;
        int width_tmp=o.outWidth, height_tmp=o.outHeight;
        int scale=1;
        while(true)
        {
            if(width_tmp/2<REQUIRED_SIZE || height_tmp/2<REQUIRED_SIZE)
                break;
            width_tmp/=2;
            height_tmp/=2;
            scale*=2;
        }

        //decode with inSampleSize
        BitmapFactory.Options o2 = new BitmapFactory.Options();
        o2.inSampleSize=scale;
        return BitmapFactory.decodeStream(f, null, o2);
    } 
    catch (FileNotFoundException e) {}
    return null;
}

and refer Memory Leak Error Android and error in loading images to gridview android

BitmapFactory.decodeStream out of memory despite using reduced sample size

10 Answers10

Linked

Related