9

I am thinking of using a base controller for the entire MVC 4 project that I am working on. I have found conflicting views online about it and not really sure if it is against best practices or if it is just a matter of personal preference.

Here is a stackoverflow post that says dont do it

Here is a post that has shown how to do it like there are no harmful effects of it. Here and here as well they explain its usage where no one really is pointing out that it is bad practice or could lead to any issues going forward.

So what really is the view on using a couple of base controllers in an MVC 4 project? Good? Bad?

Edit

I'd also like to point out that my immediate goal for using a base controller is so that I can have the Authorization done in one controller and so that all the controllers dont need to have the Authorize attribute. I will create separate base controllers for each role. Since the roles are never going to change I will never need to create another base controller for another role. What do you think of this way of going about designing the controllers?

Thanks for your time.

Community
  • 1
  • 1
user20358
  • 14,182
  • 36
  • 114
  • 186

2 Answers2

4

IMHO what the post you reference says is absolutely true, but that's not a reason to not use a base controller. In fact I use a base controller in some of my ASP.NET MVC applications because of commodity.

This is no longer advisable:

Having a base controller to apply the [Authorize] attribute once is a common practice, and I don't see anything wrong on it.

Since MVC3 you can register global action filters like this:

GlobalFilters.Filters.Add(new MyAuthorizeAttribute());

JotaBe
  • 38,030
  • 8
  • 98
  • 117
eiximenis
  • 628
  • 4
  • 8
  • Thanks for your reply. Would you think having multiple roles be a problem? Then for each role I would need a separate controller. One base controller for Admin. So that admin only pages inherit from that particular controller only. Similarly for other roles.. – user20358 Mar 14 '13 at 09:30
  • If all actions of a controller are authorized for the same roles i don't see a problem using a separated base controller for each role. But if you have controllers with actions authorized to one set of roles and other actions authorized to another set of roles maybe you should try an alternate approach. – eiximenis Mar 14 '13 at 11:46
3

I have used a base controller before when dealing with things like overriding the User principal (see here for an old question of mine describing the idea: Is this Custom Principal in Base Controller ASP.NET MVC 3 terribly inefficient?).

I honestly couldn't think of a better way of doing this, so I feel that in this kind of scenario using a base controller can be a good thing.

I probably wouldn't have different base controllers for different authorization roles though as it is fairly simple (and less code) just to decorate the controller with [Authorize(Roles="whatever")] and it will be easier to see exactly what is happening.

It may be worth considering a custom AuthorizeAttribute.

Community
  • 1
  • 1
Tom Chantler
  • 14,753
  • 4
  • 48
  • 53
  • see thats the thing. I was trying to avoid decorating each controller with the authorize attribute. I just want the junior developers to know that if they are working on page which only an Admin can access then they should inherit from AdminController. I would enum each of these roles out with Admin being number 1 on the list.. so in my custom authorize attribute I can only have a check on greater than or less than the enum value provided by the base controller – user20358 Mar 14 '13 at 09:59
  • The problem may arise if you have complex requirements about which roles are allowed to do which things. I'm talking about if the requirements change later on. Decorating the controllers with some kind of custom `AuthorizateAttribute` is probably better (see link in edited answer). – Tom Chantler Mar 14 '13 at 10:55