Save Bitmap into File and return File having bitmap image

Question

I have a problem to save Bitmaps into files. My method is like this:

private File savebitmap(Bitmap bmp) {
    String extStorageDirectory = Environment.getExternalStorageDirectory()
            .toString();
    OutputStream outStream = null;

    File file = new File(bmp + ".png");
    if (file.exists()) {
        file.delete();
        file = new File(extStorageDirectory, bmp + ".png");
        Log.e("file exist", "" + file + ",Bitmap= " + bmp);
    }
    try {
        outStream = new FileOutputStream(file);
        bmp.compress(Bitmap.CompressFormat.PNG, 100, outStream);
        outStream.flush();
        outStream.close();
    } catch (Exception e) {
        e.printStackTrace();
    }
    Log.e("file", "" + file);
    return file;

}

It gives me error of file.I am calling this method like this:

Drawable d = iv.getDrawable();
Bitmap bitmap = ((BitmapDrawable) d).getBitmap();
File file = savebitmap(bitmap);

Please help me...

What is the meaning of this line File file = new File(bmp + ".png");? — Festus Tamakloe, Mar 15 '13 at 09:44
@FestusTamakloe I guess he falsely assumes that `bmp.toString()` will return the `name` of the bmp, — Rafael T, Mar 15 '13 at 09:48
You have to give your file a real name, bmp + ".png" won't work. Please post your error stack also — the-ginger-geek, Mar 15 '13 at 09:52

Festus Tamakloe · Accepted Answer · 2013-03-15T18:11:16.053

I try to make some corrections on your code I assume that you want to use filename instead of bitmap as parameter

 private File savebitmap(String filename) {
      String extStorageDirectory = Environment.getExternalStorageDirectory().toString();
      OutputStream outStream = null;

      File file = new File(filename + ".png");
      if (file.exists()) {
         file.delete();
         file = new File(extStorageDirectory, filename + ".png");
         Log.e("file exist", "" + file + ",Bitmap= " + filename);
      }
      try {
         // make a new bitmap from your file
         Bitmap bitmap = BitmapFactory.decodeFile(file.getName());

         outStream = new FileOutputStream(file);
         bitmap.compress(Bitmap.CompressFormat.PNG, 100, outStream);
         outStream.flush();
         outStream.close();
      } catch (Exception e) {
         e.printStackTrace();
      }
      Log.e("file", "" + file);
      return file;

   }

score 2 · Answer 2 · answered Mar 15 '13 at 09:50

2

You can't write like this

 File file = new File(bmp + ".png");

and this line is also wrong

file = new File(extStorageDirectory, bmp + ".png");

You have to give string value and not bitmap.

 File file = new File(filename + ".png");

answered Mar 15 '13 at 09:50

Nirali

13,571
6
40
53

score 0 · Answer 3 · answered Mar 15 '13 at 09:50

0

Change File file = new File(bmp + ".png"); to File file = new File(extStorageDirectory,"bmp.png"); like you did nearly the second time.

answered Mar 15 '13 at 09:50

greenapps

11,154
2
16
19

Save Bitmap into File and return File having bitmap image

3 Answers3

Linked