Confirm dialog box on delete button

Question

I am working with an app using Angular.

I currently have a delete button, that has a confirmation attached to onClick()

<a class="delete button" href="#" onClick="return confirm('Are you absolutely sure you want to delete?')" ng-click="remove_user(user, $event)" ></a>

The problem is when the confirmation pops up, both "OK' and "Cancel" delete the item, what am I missing to get "Cancel" to simply cancel?

You *are* cancelling the click event when you click cancel, but you're not cancelling `ng-click` (whatever that is, I'm not familiar with angularjs). Maybe this will help: http://stackoverflow.com/questions/15385914/angular-js-cancel-ng-click-event — bfavaretto, Mar 15 '13 at 14:54

score 52 · Answer 1 · edited Feb 12 '15 at 02:57

Maybe just using the angular click handler and doing the confirm logic there is worth a try.

function FooController($scope, $window) {
  $scope.removeUser = function() {
    var deleteUser = $window.confirm('Are you absolutely sure you want to delete?');

    if (deleteUser) {
      $window.alert('Going to delete the user');
    }
  }
}

function FooController($scope, $window) {
  $scope.removeUser = function() {
    var deleteUser = $window.confirm('Are you absolutely sure you want to delete?');

    if (deleteUser) {
      $window.alert('Going to delete the user');
    }
  }
}

body {
  padding: 0;
  margin: 0;
  background: #3FA8C6;
  background-image: -moz-linear-gradient(top, #3fa8c6 0%, #3fa8c6 0%, #399ab2 100%);
  background-image: -webkit-gradient(linear, left top, left bottom, color-stop(0%, #3fa8c6), color-stop(0%, #3fa8c6), color-stop(100%, #399ab2));
  background-image: -webkit-linear-gradient(top, #3fa8c6 0%, #3fa8c6 0%, #399ab2 100%);
  background-image: -o-linear-gradient(top, #3fa8c6 0%, #3fa8c6 0%, #399ab2 100%);
  background-image: -ms-linear-gradient(top, #3fa8c6 0%, #3fa8c6 0%, #399ab2 100%);
  background-image: linear-gradient(to bottom, #3fa8c6 0%, #3fa8c6 0%, #399ab2 100%);
  color: #fff;
  font-family: 'Doppio One', sans-serif;
  text-shadow: 0 1px 0 rgba(0, 0, 0, .3);
  line-height: 1.5;
  -webkit-font-smoothing: antialiased;
}
.wrapper {
  width: 50%;
  margin: 0 auto;
}
h1,
h2,
h3,
h4,
h5,
h6 {
  letter-spacing: -0.03em;
  font-size: 2em;
}
a {
  border-bottom: 1px solid #fff;
  border-bottom: 1px solid rgba(255, 255, 255, 0.7);
  padding-bottom: 0.15em;
  position: relative;
  color: white;
  text-decoration: none;
}
a:after {
  content: '';
  position: absolute;
  height: 1px;
  left: 0;
  right: 0;
  bottom: -2px;
  background: rgba(0, 0, 0, .1);
}
a:hover {
  color: #C0E3EC;
}
h1 {
  margin: 0.667em 0 0;
  padding-left: 0.5em;
  text-align: left;
}
h2 {
  font-size: 1.5em;
}
small {
  margin-top: 1em;
  display: block;
  font-style: italic;
  font-size: 0.667em;
}
p em {
  font-style: none;
}
#welcome {
  position: relative;
  overflow: hidden;
  padding-bottom: 1em;
  padding-left: 20px;
}
#welcome > div {
  padding-top: 1px;
}
#dave {
  float: left;
  margin-top: 3em
}
#welcome > h2 {
  margin-top: 0.5em;
  padding-left: 0.5em;
  margin-bottom: 0;
}
.bubble p {
  line-height: 22px;
}
.bubble {
  background: rgba(255, 255, 255, 0.1);
  border-color: rgba(255, 255, 255, 0.1);
  padding: 0.667em 1em;
  position: relative;
}
.bubble:after {
  content: "";
  position: absolute;
  width: 0;
  height: 0;
  border-top: 20px solid transparent;
  border-bottom: 20px solid transparent;
  border-right: 20px solid white;
  border-right-color: inherit;
  top: 50px;
  left: -20px;
}
#features {
  margin: 0.444em 0 0;
  clear: both;
}
#features > h2 {
  margin: 0;
}
#features ol {
  position: relative;
  padding: 1em 0 1.5em;
  background: rgba(0, 0, 0, .1);
  border-color: rgba(0, 0, 0, .1);
  margin: 0;
  overflow: hidden;
  list-style: none;
  counter-reset: item;
}
#features li {
  width: 30%;
  padding: 0 1.5%;
  float: left;
  text-align: center;
  margin-bottom: 1em;
}
#features li h2 {
  display: block;
  padding: 1em;
  margin: 0.667em auto 1em;
  font-size: 1em;
  line-height: 1em;
  text-align: center;
  background: rgba(0, 0, 0, .1);
  border-radius: 2em;
  box-shadow: inset 0 0 1em rgba(0, 0, 0, .1), 0 2px 2px rgba(255, 255, 255, .1);
}
#next > div {
  width: 45%;
  float: left;
  padding: 0 2.5%;
}
img {
  z-index: 1;
  -webkit-transition: -webkit-transform 2s ease-in-out;
  -moz-transition: -moz-transform 2s ease-in-out;
  -o-transition: -o-transform 2s ease-in-out;
  -ms-transition: -ms-transform 2s ease-in-out;
  transition: transform 2s ease-in-out;
  position: relative;
}
img:active {
  -webkit-transform: rotate(1440deg) scale(1.2);
  -moz-transform: rotate(1440deg) scale(1.2);
  -o-transform: rotate(1440deg) scale(1.2);
  -ms-transform: rotate(1440deg) scale(1.2);
  transform: rotate(1440deg) scale(1.2);
}
@media screen and (max-width: 1200px) {
  .wrapper {
    width: 80%;
  }
}
@media screen and (max-width: 768px) {
  .wrapper {
    width: auto;
    margin: 0;
  }
  #welcome {
    margin-right: 2.5%;
  }
}
@media screen and (max-width: 500px) {
  .wrapper {
    text-align: center;
  }
  #dave {
    float: none;
  }
  #welcome {
    padding: 0 1.5em;
    margin: 0;
  }
  h1 {
    text-align: center;
    margin-bottom: 0;
    padding-left: 0;
    font-size: 1.8em;
  }
  #welcome > h2 {
    margin-bottom: 0.667em;
  }
  .bubble {
    text-align: center;
  }
  .bubble:after {
    display: none;
  }
  #features li {
    width: 47%;
  }
  #features li:last-child {
    float: none;
    clear: both;
    margin: 0 auto;
  }
  #next > div {
    float none;
    width: auto;
  }
}

<html ng-app ng-controller="FooController">

<body>
  <a class="delete button" href="#" ng-click="removeUser(user, $event)">Delete</a> 

  <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.0.5/angular.min.js"></script>
</body>
</html>

This method works somewhat, what would the else statement look like? In order to trigger a cancel (no action)? — FluxEngine, Mar 15 '13 at 15:11
That's going to be hard to unit test. You'll either want to inject $window and use $window.confirm, or you'll want to make a confirm service and inject that. — Ben Lesh, Aug 19 '13 at 03:02

Shay · Answer 2 · 2015-05-20T22:13:25.050

16

This is a little late but for future reader, like me 15 minutes ago:

The "angular way" will be to create a directive as suggested here:

'use strict';

angular.module('confirm', [])
    .directive('confirm', [function () {
        return {
            priority: 100,
            restrict: 'A',
            link: {
                pre: function (scope, element, attrs) {
                    var msg = attrs.confirm || "Are you sure?";

                    element.bind('click', function (event) {
                        if (!confirm(msg)) {
                            event.stopImmediatePropagation();
                            event.preventDefault;
                        }
                    });
                }
            }
        };
    }]);

Usage:

<button ng-click="save()" confirm="Save Changes?">Save</button>

edited May 20 '15 at 22:13

answered May 20 '14 at 23:12

Shay

1,680
2
26
39

what's the usage ? lets say I have something like that ? – Tzvi Gregory Kaidanov Sep 29 '14 at 06:59
Simple yet recyclable. Love it! – Tiago Mar 16 '16 at 11:02
I'm new to angular so I can't adequately compare this against the currently most-voted answer but this is excellent for it's brevity and reusability by only changing the `confirm` value (or not). – ChiefTwoPencils Jul 03 '16 at 05:20
Original link has disappeared, unfortunately. But @shay-nissel, please could you explain what the `priority` and `restrict` values do? – CJBrew Sep 06 '16 at 10:17
It's OK, I think I found the source: http://zachsnow.com/#!/blog/2013/confirming-ng-click/ and also: http://stackoverflow.com/questions/18313576/confirmation-dialog-on-ng-click-angularjs – CJBrew Sep 06 '16 at 10:21
@CJBrew Original snippet was take down, but what you found is close enough. `priority` hints angular the execution priority of the "linked" function in case multiple directives are defined (0 is default, higher is executed first). `restrict` is used to restrict of usage of the directive (A - Attribute, E - Element, C - Class). In this case "confirm" can be used an attribute only. – Shay Sep 08 '16 at 03:05

score 5 · Answer 3 · edited May 20 '14 at 18:38

If you are using bootstrap for UI, I'd recommend using angular-dialog-service. Once you include the module dependencies, you can confirm it like this.

function FooController($scope, $dialogs)
{
  $scope.removeUser = function() {
    var dlg = dialogs.confirm('Please Confirm', 'Are you absolutely sure you want to delete?');
    dlg.result.then(function () {
      console.log("User has confirmed");//do something when user confirms
    },function(){
      console.log("User has cancelled");//do something when user cancels. Can omit the 2nd function if no handling is required
    });
  }
}

See this example for more details.

I think you are injecting $dialogs, isn't it dialogs only – nabin Mar 04 '16 at 07:07 — nabin, Mar 04 '16 at 07:07

score 3 · Answer 4 · edited Aug 28 '17 at 20:51

It might help to others

The HTML Code-sample

<button confirmed-click="removeRowIndex(col, row)" 
        ng-confirm-box-click="Are you sure want to delete?" 
        class="btn btn-xs btn-default"/>

The AngularJs code-sample

app.directive('ngConfirmBoxClick', [

      function () {
          return {
              link: function (scope, element, attr) {
                  var msg = attr.ngConfirmBoxClick;
                  var clickAction = attr.confirmedClick;
                  element.bind('click', function (event) {
                      if (window.confirm(msg)) {
                          scope.$eval(clickAction)
                      }
                  });
              }
          };
      }
]);

score 2 · Answer 5 · edited Mar 20 '14 at 08:47

2

Just replace the onclick methods like below and it will work.

onclick="javascript:return confirm('Are you absolutely sure you want to delete?')"

edited Mar 20 '14 at 08:47

ndsmyter

6,535
3
22
37

answered Feb 20 '14 at 09:36

Deo

82
5

score 0 · Answer 6 · answered Mar 15 '13 at 14:55

0

<a class="delete button" href="#" onClick="return false" ng-click="if(confirm('Are you absolutely sure you want to delete?')){remove_user(user, $event);}" ></a>

Try this? I think it has to do with the fact that you're stopping the default "onclick" listener but not affecting the "ng-click" listener. Instead I moved the confirm logic into the "ng-click" listener and "return false" onclick because you don't want the link to take you away.

answered Mar 15 '13 at 14:55

cciollaro

354
4
10

I tried this method with no luck, thanks for the suggestion though. – FluxEngine Mar 15 '13 at 15:14

score 0 · Answer 7 · edited Feb 20 '14 at 09:16

0

Well I would create a function that will tick a global variable and check it on submit

<form onsubmit='check_delete()'
<input type='submit' onclick='set_delete()'

Javascript

 function set_delete(){delete_flag = 1 ;} // this is a global var set by default to 0
 function check_delete(){if(delete_flag == 1) confirm(''sure?);}

edited Feb 20 '14 at 09:16

karthik

17,453
70
78
122

answered Feb 20 '14 at 08:59

Anwar Saiah

179
8

Confirm dialog box on delete button

7 Answers7