MySQL Select Query Won't Work

Question

In my database, I have a table of IPs that I have banned from accessing certain things in my PHP script. When I enter my IP into the database (as a string, example "123.4.5.6") and it doesn't seem to echo "banned", when I have clearly entered my IP into the banned database table.

<?php
require_once('config.php');
$ip = $_SERVER['REMOTE_ADDR'];
$checkipban "SELECT * FROM banned WHERE bannedip = '$ip'
";
$banquery = mysql_query($checkipban,$con);
if(mysql_num_rows($banquery) > 0)
echo "banned";
}
?>

$con is the connection to the database in config.php and it works because other MySQL queries in the script work. The database table is called banned and there is only one column called bannedip.

check whether your script compiles, check `$ip`, check whether your query succeeded. and what's that trailing `}` ? — Karoly Horvath, Mar 16 '13 at 18:06

score 3 · Accepted Answer · edited May 25 '19 at 14:27

3

Seems typo. You missed =

$checkipban = "SELECT * FROM banned WHERE bannedip = '$ip'";
            ^

NOTE:

Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO, or MySQLi - this article will help you decide which.

edited May 25 '19 at 14:27

Zoe

27,060
21
118
148

answered Mar 16 '13 at 18:06

Rikesh

26,156
14
79
87

2

I just realized that it has been deprecated and I am going to use MySQLi instead – user1008096 Mar 16 '13 at 18:42
+1 for explaining deprecated mysql_* functions. – Jimbo Mar 18 '13 at 15:51

score 1 · Answer 2 · answered Mar 16 '13 at 18:07

1

You left = for assigning it to varaible $checkipban,

$checkipban  = "SELECT * FROM banned WHERE bannedip = '$ip'";

answered Mar 16 '13 at 18:07

Muthu Kumaran

17,682
5
47
70

MySQL Select Query Won't Work

2 Answers2