2

I'm loading the contents of a database into a GridView using a CursorLoader and a ContentProvider.

The application is working but in the log is written several times "close() was never explicitly called on database.

I found some topics about this issue and the response to "close database in ContentProvider is": "A content provider is created when its hosting process is created, and remains around for as long as the process does, so there is no need to close the database".

So, whats going wrong? As the database is opened within the ContentProvider, if I close it the cursor returned will be empty, how I resolve this issue?

BenMorel
  • 34,448
  • 50
  • 182
  • 322
cpinheiro
  • 41
  • 4
  • 1
    Make sure you are opening the database in `ContentProvider.onCreate` method and not somewhere else(e.g. in `insert` or query``) – Vladimir Mironov Mar 17 '13 at 17:52
  • 1
    You don't need to close database, see [this thread](http://stackoverflow.com/questions/4547461/closing-the-database-in-a-contentprovider). – Simon Dorociak Mar 17 '13 at 17:58
  • 1
    @vmironov The [documentation](https://developer.android.com/reference/android/content/ContentProvider.html#onCreate%28%29) advises the exact: potentially slow operations should not be called in `onCreate()`. – Sam Mar 17 '13 at 18:03

1 Answers1

2

That message is printed when the db is garbage collected before being closed. There is a lot of discussion about the issue here:

Closing the database in a ContentProvider

tl;dr: don't worry about it. It is, in general, actually counter-productive to close the db. Close your transactions and your cursors and let android manage the DB.

BTW, take care opening the DB in onCreate. If you open your DB using a SQLiteDatabaseHelper, the onUpdate method might be called. There isn't too much that could be worse than having your program killed by an ANR, in the middle of updating the DB.

Community
  • 1
  • 1
G. Blake Meike
  • 6,615
  • 3
  • 24
  • 40