C++ vector compile error, when using vector::push_back() method

Question

I'm using std::vector in my program and I get this error when compiling:

/usr/lib/gcc/i686-pc-cygwin/3.4.4/include/c++/bits/vector.tcc: In member function `User& User::operator=(const User&)':

/usr/lib/gcc/i686-pc-cygwin/3.4.4/include/c++/bits/vector.tcc:238: instantiated from void std::vector<_Tp, _Alloc>::_M_insert_aux(__gnu_cxx::__normal_iterator<typename _Alloc::pointer, std::vector<_Tp, _Alloc> >, const _Tp&) [with _Tp = User, _Alloc = std::allocator<User>]' /usr/lib/gcc/i686-pc-cygwin/3.4.4/include/c++/bits/stl_vector.h:564: instantiated fromvoid std::vector<_Tp, _Alloc>::push_back(const _Tp&) [with _Tp = User, _Alloc = std::allocator]'

main.cpp:100: instantiated from here

/usr/lib/gcc/i686-pc-cygwin/3.4.4/include/c++/bits/vector.tcc:238: error: non-static const member `const std::string User::NAME', can't use default assignment operator

I have classes "User" and "Users":

class User {
    public:
        const string NAME;

        User(const string &name, const bool &isMain = false) : NAME(name), isMain(isMain) {};
        void addFollower(User * user);
        void addReplier(User * user, const int &count);
        void addMentioner(User * user, const int &count);
        void addRetweeter(User * user, const int &count);

    private:
        vector<User *> followedBy, repliedBy, mentionedBy, retweetedBy;
        vector<int> replyCount, mentionCount, retweetCount;
        bool isMain;
    };


class Users {
    public:
        vector<User> users;

        void addUser(const string &name, bool isMain = false);
        User * findUser(const string &name);
        friend ostream & operator <<(ostream &outStream, const Users &users);
        User & operator [] (unsigned int index);
    };

Here is the thing. The error is caused by the method Users::addUser():

void Users::addUser(const string &name, bool isMain) {
    User newUser(name, isMain);
    users.push_back(newUser);
}

If I erase the second line

users.push_back(newUser);

it works fine, but well, it doesn't work as like as you see because it prevents me from adding new records into the "users" vector array. I'll be thankful if anyone tells me what is the cause. Thanks

possible duplicate of [Non-static const member, can't use default assignment operator](http://stackoverflow.com/questions/634662/non-static-const-member-cant-use-default-assignment-operator) — Patrick B., Mar 30 '13 at 21:57

score 7 · Accepted Answer · answered Mar 30 '13 at 21:58

7

You have to provide a copy-constructor in order to use push_back, since your class contains a non-static const member.

You could fix this easily by using a getter instead:

class User{
public:
    string NAME() const { return m_name; }
    /* ... */
private:
    string m_name;
    /* ... */
};

answered Mar 30 '13 at 21:58

Zeta

103,620
13
194
236

@MichalArtazov: You're welcome. However, if you use the copy constructor approach don't forget to implement the assignment operator too, since you might accidentally use it. – Zeta Mar 30 '13 at 22:26

score 2 · Answer 2 · answered Mar 30 '13 at 22:02

2

Most of the time, the compiler will provide a copy assignment operator for you, but since you have a const member variable, it is not possible for the compiler to do so.

answered Mar 30 '13 at 22:02

Alex Chamberlain

4,147
2
22
49

C++ vector compile error, when using vector::push_back() method

2 Answers2