Undefined method error when I add method to model in Rails

Question

I have the error

undefined method events_and_repeats' for #<Class:0x429c840>

app/controllers/events_controller.rb:11:in `index'

my app/models/event.rb is

class Event < ActiveRecord::Base
  belongs_to :user

  validates :title, :presence => true,
                    :length => { :minimum => 5 }
  validates :shedule, :presence => true

  require 'ice_cube'
  include IceCube

  def events_and_repeats(date)
    @events = self.where(shedule:date.beginning_of_month..date.end_of_month)

    return @events
  end

end

app/controllers/events_controller.rb

def index
    @date = params[:month] ? Date.parse(params[:month]) : Date.today
    @repeats = Event.events_and_repeats(@date)

    respond_to do |format|
      format.html # index.html.erb
      format.json { render json: @events }
    end
  end

What is wrong?

just need a 'self' - you made an instance method, but called a class method — Mark Swardstrom, Apr 03 '13 at 23:21
Self where? Please give me an example. And what is difference? Thanks — Gabi, Apr 03 '13 at 23:24

score 12 · Accepted Answer · answered Apr 03 '13 at 23:26

12

Like Swards said, you called a instance method on a class. Rename it:

def self.events_and_repeats(date)

I am only writting this in an answer because it's too long for a comment, checkout the ice-cube github page, it strictly says:

Include IceCube inside and at the top of your ActiveRecord model file to use the IceCube classes easily.

Also i think it you don't need the require in your model.

answered Apr 03 '13 at 23:26

Zippie

6,018
6
31
46

Thanks a lot!! May be you may help me resolve one more issue http://stackoverflow.com/questions/15790909/gem-ice-cube-for-reccurence-events – Gabi Apr 03 '13 at 23:55

score 4 · Answer 2 · answered Apr 03 '13 at 23:25

4

You can do it both ways:

class Event < ActiveRecord::Base
  ...

  class << self
    def events_and_repeats(date)
      where(shedule:date.beginning_of_month..date.end_of_month)
    end
  end

end

or

class Event < ActiveRecord::Base
  ...

  def self.events_and_repeats(date)
    where(shedule:date.beginning_of_month..date.end_of_month)
  end    
end

answered Apr 03 '13 at 23:25

Luís Ramalho

10,018
4
52
67

1

Thank you! Now I will know it ) – Gabi Apr 04 '13 at 00:07
1

You're welcome! A couple of thing, you don't need the `@events`at all, ruby methods will return the last evaluated statement. Moreover, `self.where()` is also not necessary because you're calling `where()` already inside `self`. Glad I was able to help you! – Luís Ramalho Apr 04 '13 at 00:09

score 0 · Answer 3 · answered Sep 28 '15 at 07:45

Just for more clarity:

class Foo
  def self.bar
    puts 'class method'
  end

  def baz
    puts 'instance method'
  end
end

Foo.bar # => "class method"
Foo.baz # => NoMethodError: undefined method ‘baz’ for Foo:Class

Foo.new.baz # => instance method
Foo.new.bar # => NoMethodError: undefined method ‘bar’ for #<Foo:0x1e820>

Class method and Instance method

Undefined method error when I add method to model in Rails

3 Answers3