ListView onclick not functioning accrodingly

Question

Hi I am using list view in my list view i have veg and non-veg.so when i click on veg it should move to next activity and display the items and when i click on Non-veg it should to next activity.I have written setonclickitemlistener() for both list items but when i press veg or non-veg it is going to Non-veg activity only.Here is the code

public class MainActivity extends Activity {

String[] items={"veg","non-veg"};


protected void onCreate(Bundle savedInstanceState) {

    super.onCreate(savedInstanceState);

    setContentView(R.layout.activity_main);

     ListView lv= (ListView)findViewById(R.id.listView1);

  ArrayAdapter<Object> adapter1 = new ArrayAdapter<Object (this,android.R.layout.simple_list_item_1,items);

  lv.setAdapter(adapter1);      

    lv.setOnItemClickListener(new OnItemClickListener() {


        public void onItemClick(AdapterView<?> arg0, View v, int arg2,
                long arg3) {

            {
            Toast.makeText(getBaseContext(),"YOU HAVE SELECTED VEG", 4000).show();
        Intent i=new Intent(MainActivity.this,veg.class);
        startActivity(i);
            }
        }
    });




  lv.setOnItemClickListener(new OnItemClickListener() {         

            public void onItemClick(AdapterView<?> arg0, View arg1, int arg2,
                    long arg3) {

                Toast.makeText(getBaseContext(),"YOU HAVE SELECTED NON-VEG", 4000).show();
            Intent i=new Intent(MainActivity.this,Nonveg.class);
            startActivity(i);


            }
        });

} }

please tell me how to identify id for veg and non veg and how to write setonclicklistener() method.

you do not understand code flow ... there can be only 1 OnItemClickListener ... `(String)arg0.getItemAtPosition(arg2)` will return veg or non-veg in your `onItemClick` implementation — Selvin, Apr 05 '13 at 12:51
@Rawkode lol ... just check what is after whole code in questio ... two small "}}" :) — Selvin, Apr 05 '13 at 12:53
Just check the item in onItemClick() and then start relevant activity... — RajaReddy PolamReddy, Apr 05 '13 at 12:56

score 0 · Answer 1 · answered Apr 05 '13 at 12:50

0

You can only have one OnItemClickListener... That is going to have to check the view to determine where to go.

answered Apr 05 '13 at 12:50

snowCrabs

785
5
11

Then what about other item if i give only one onitemclick – SANJEEV REDDY Apr 05 '13 at 12:56
The list view can only have one registered OnClickListener. This is registered for whenever ANY item is clicked. You have to determine from getting the information from the adapter what view you have and determine how to proceed from there. – snowCrabs Apr 05 '13 at 12:59

Marko Niciforovic · Accepted Answer · 2013-04-05T13:01:45.170

0

this code is fully working:

public class MainActivity extends Activity{

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        // TODO Auto-generated method stub
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);

        final ListView lv = (ListView)findViewById(R.id.listView1);
        lv.setChoiceMode(ListView.CHOICE_MODE_SINGLE);

        final String[] values = new String[] { "Veg", "Non-veg" };

                // Define a new Adapter
                // First parameter - Context
                // Second parameter - Layout for the row
                // Third parameter - ID of the TextView to which the data is written
                // Forth - the Array of data

                ArrayAdapter<String> adapter = new ArrayAdapter<String>(this,
                        android.R.layout.simple_list_item_1, android.R.id.text1, values);


                // Assign adapter to ListView
                lv.setAdapter(adapter); 

                lv.setOnItemClickListener(new OnItemClickListener() {

                    @Override
                    public void onItemClick(AdapterView<?> arg0, View arg1,
                            int arg2, long arg3) {
                        if (arg2 == 0) {
                        Intent intent = new Intent(MainActivity.this, veg.class);
                        startActivity(intent);
                        }
                        if (arg2 ==1) {
                            Intent intent = new Intent(MainActivity.this, Nonveg.class);
                            startActivity(intent);
                        }
                    }
                });
}

arg2 is position of item in list

edited Apr 05 '13 at 13:01

answered Apr 05 '13 at 12:54

Marko Niciforovic

3,561
2
21
28

sorry they are ending braces }} – SANJEEV REDDY Apr 05 '13 at 12:58
thanks for your answer can you please tell what is the use of base adapter – SANJEEV REDDY Apr 05 '13 at 13:05
no problem, it is base class of common implementation for an Adapter that can be used in both ListView. read here http://stackoverflow.com/questions/4799380/understanding-baseadapters-and-how-to-use-them – Marko Niciforovic Apr 05 '13 at 13:08
again i getting the same problem it is going to nonveg activity for both veg and nonveg – SANJEEV REDDY Apr 05 '13 at 13:08
I just tested please check again it works for me, try adding Log.d("1","1"); below arg2 == 0 and Log.d("2","2"); below arg2 == 1 and check log, if it shows different for different clicks then its your manifest or activies. – Marko Niciforovic Apr 05 '13 at 13:11
Hey tell me what actually adapter dose and how many adapters are there? – SANJEEV REDDY Apr 05 '13 at 13:25
adapter connects data to view (listview in your example), there are many adapters, baseAdapter, arrayAdapter, SimpleAdapter, CursorAdapter etc.. – Marko Niciforovic Apr 05 '13 at 13:27
what makes the difference or suggest me any some nice portal i am beginer – SANJEEV REDDY Apr 05 '13 at 13:29
well depends on your need, this answer tells you a little http://stackoverflow.com/questions/4799380/understanding-baseadapters-and-how-to-use-them and here is everything http://developer.android.com/reference/android/widget/Adapter.html – Marko Niciforovic Apr 05 '13 at 13:31

Raghunandan · Answer 3 · 2013-04-05T13:02:57.630

On click of listview item get the item at the position in listview.. Check if its veg or non veg

public class MainActivity extends Activity {
String[] items={"veg","non-veg"};
ListView lv;
protected void onCreate(Bundle savedInstanceState) {

super.onCreate(savedInstanceState);

 setContentView(R.layout.activity_main);

 lv= (ListView)findViewById(R.id.listView1);
 setContentView(lv);
 ArrayAdapter<Object> adapter1 = new ArrayAdapter<Object> (this,android.R.layout.simple_list_item_1,items);

 lv.setAdapter(adapter1);      

 lv.setOnItemClickListener(new OnItemClickListener() {


    public void onItemClick(AdapterView<?> arg0, View v, int arg2,
            long arg3) {

        {
             String itemselected =(String) (lv.getItemAtPosition(arg2));
             if(itemselected.equals("veg")){

             Toast.makeText(getBaseContext(),"YOU HAVE SELECTED VEG", 4000).show();
             Intent i=new Intent(MainActivity.this,veg.class);
             startActivity(i); 
          }
            else if(itemselected .equals("non-veg"))
            {
                Toast.makeText(getBaseContext(),"YOU HAVE SELECTED NON VEG",4000).show();
                     Intent i=new Intent(MainActivity.this,nonveg.class);
                      startActivity(i); 
            }

        }
    }


});

}
});

ListView onclick not functioning accrodingly

3 Answers3