How to set connection timeout for JSONParser.makeHttpRequest in Android?

Question

I am getting and posting some data with JSONParser.makeHttpRequest. When the connection is slow it takes a while to get a response and I would like to set the timeout limit to 5 seconds. I found this post showing how to set HttpResponse timeout but couldn't integrate it with JSONParser.

Here is the code I use for HttpRequest

JSONParser jParser = new JSONParser();
List<NameValuePair> params = new ArrayList<NameValuePair>();
JSONObject json = jParser.makeHttpRequest(url, "GET", params);

I will be grateful if I can get a code snippet or a link to another post somewhere else.

score 2 · Answer 1 · edited Nov 02 '13 at 23:07

Here is the code:

public class JSONParser {

    static InputStream is = null;
    static JSONObject jObj = null;
    static String json = "";
    int timeout;

// constructor
public JSONParser() {
    timeout = new Values().gettimeout();
}

// function get json from url
// by making HTTP POST or GET method
public JSONObject makeHttpRequest(String url, String method,
        List<NameValuePair> params) {

    // Making HTTP request
    try {
         HttpParams httpParameters = new BasicHttpParams();
         HttpConnectionParams.setSoTimeout(httpParameters, timeout);
        // check for request method
        if(method == "POST"){
            // request method is POST
            // defaultHttpClient
            DefaultHttpClient httpClient = new DefaultHttpClient(httpParameters);
            HttpPost httpPost = new HttpPost(url);
            httpPost.setEntity(new UrlEncodedFormEntity(params));

            HttpResponse httpResponse = httpClient.execute(httpPost);
            HttpEntity httpEntity = httpResponse.getEntity();
            is = httpEntity.getContent();

        }else if(method == "GET"){
            // request method is GET
            DefaultHttpClient httpClient = new DefaultHttpClient(httpParameters);
            String paramString = URLEncodedUtils.format(params, "utf-8");
            url += "?" + paramString;
            HttpGet httpGet = new HttpGet(url);

            HttpResponse httpResponse = httpClient.execute(httpGet);
            HttpEntity httpEntity = httpResponse.getEntity();
            is = httpEntity.getContent();
        }           

    } catch (UnsupportedEncodingException e) {
        e.printStackTrace();
    } catch (ClientProtocolException e) {
        e.printStackTrace();
    } catch (IOException e) {
        e.printStackTrace();
    }

    try {
        BufferedReader reader = new BufferedReader(new InputStreamReader(
                is, "iso-8859-1"), 8);
        StringBuilder sb = new StringBuilder();
        String line = null;
        while ((line = reader.readLine()) != null) {
            sb.append(line + "\n");
        }
        is.close();
        json = sb.toString();
    } catch (Exception e) {
        Log.e("Buffer Error", "Error converting result " + e.toString());
    }

    // try parse the string to a JSON object
    try {
        jObj = new JSONObject(json);
    } catch (JSONException e) {
        Log.e("JSON Parser", "Error parsing data " + e.toString());
    }

    // return JSON String
    return jObj;

}
}

the secret is :

     HttpParams httpParameters = new BasicHttpParams();
     HttpConnectionParams.setSoTimeout(httpParameters, timeout);

and set de HttpParams in

 DefaultHttpClient httpClient = new DefaultHttpClient(httpParameters);

Adapt you code to do that ;)

All fine. But what occurs when the connection times out. I don't see any handling code (exception or whatever...). Thanks. — wmac, Jan 14 '15 at 19:48
This worked for me for slower connection increasing the value of request timeout will do the work. My app was performing well on wifi but crashing on mobile data but when i increased my timeout it worked perfectly. credit goes to @Tobias S. Lucian — Dipen, Jan 21 '15 at 16:21

score 0 · Accepted Answer · edited May 23 '17 at 12:13

0

You can use Asynctask, and stop the request after some time. See examples here.

edited May 23 '17 at 12:13

Community

1
1

answered Apr 07 '13 at 21:29

MeNa

1,467
9
23

Why didn't I think about that, I already use Asynctask but couldn't think about that very simple way. Thanks! – Engin Yapici Apr 07 '13 at 21:30

How to set connection timeout for JSONParser.makeHttpRequest in Android?

2 Answers2

Linked