multiple file upload sql/php

Question

i am trying to upload multiple files and then insert the files names in mysql db my problem is with inserting the names it only store the last file name

for($i=0;$i<count($_FILES['file']['size']);$i++){
    if(strstr($_FILES['file']['type'][$i], 'image')!==false){
        $file = 'uploads/'.time().' - '.$_FILES['file']['name'][$i];
        move_uploaded_file($_FILES['file']['tmp_name'][$i],$file);
        $na=$_FILES['file']['name'][$i];

        $sql="INSERT INTO img (img_name) VALUES ('$na');";
    }
}

notice that all the files are uploaded successfully

Are you calling mysql_query() function outside your for loop? If yes then you know the solution now... — Jay Bhatt, Apr 09 '13 at 16:43
looks like you are actually running the query after the loop. Try `$sql .="query here;";` — Nic, Apr 09 '13 at 16:46
@Nic: That probably won't work. PHP doesn't like you running multiple queries in one call. — gen_Eric, Apr 09 '13 at 16:48
@Jay yeah i have an error chick after the loop if (!mysqli_query($con,$sql)) { die('Error: ' . mysqli_error()); } — layal sherif, Apr 09 '13 at 16:48
thank you it worked !!! by just removing the error chick and put it inside the loop — layal sherif, Apr 09 '13 at 17:07
Mmm. You could add it in an array and do a `foreach` loop after. but I guess adding `mysql_query()` inside your main loop is better as the accepted solution shows — Nic, Apr 10 '13 at 17:17

score 1 · Accepted Answer · answered Apr 09 '13 at 17:18

for($i=0;$i<count($_FILES['file']['size']);$i++){
    if(strstr($_FILES['file']['type'][$i], 'image')!==false){
        $file = 'uploads/'.time().' - '.$_FILES['file']['name'][$i];
        move_uploaded_file($_FILES['file']['tmp_name'][$i],$file);
        $na=$_FILES['file']['name'][$i];

        $sql="INSERT INTO img (img_name) VALUES ('$na');";
    }
}

you are just creating a string and storing some value. you have not executed it .. Say $str = "apple"; Its just a declaration. I presume you have executed the query after the loop. Say you have 10 files. loop gets executed 10 times and $na has the last filename which gets inserted.

Soln: move your execute query inside the for loop.

for($i=0;$i<count($_FILES['file']['size']);$i++){
    if(strstr($_FILES['file']['type'][$i], 'image')!==false){
        $file = 'uploads/'.time().' - '.$_FILES['file']['name'][$i];
        move_uploaded_file($_FILES['file']['tmp_name'][$i],$file);
        $na=$_FILES['file']['name'][$i];

        $sql="INSERT INTO img (img_name) VALUES ('$na');";
        mysql_query($con,$sql); // note: $con is your connection string
    }
}

multiple file upload sql/php

1 Answers1

Linked