Link to download doesn't work

Question

When I click on a link, I can't download the image, only visualize it. What is my mistake?

PHP:

  require('conecta.php');
  ini_set('display_errors',1); error_reporting(E_ALL);  
    $cSQL="SELECT ID_PIC, PIC, NOMBRE FROM FOTOS";
    $stmt=$oConni->prepare($cSQL) or die($oConni->error);
    $stmt->execute(); 
    $stmt->store_result();
    $stmt->bind_result($id, $pic, $nombre);
    //$i=0;
    echo '<table cellspacing="0">';
    while ($stmt->fetch()) {

        if (!empty($pic)){ 
            echo'<tr><td><img class="sifoto" src="images.php? id='.$id.'" width="100" height="100"  /></td></tr>';
        }
        echo'<tr><td value='.$id.'><a href='.$nombre.'>DOWNLOAD</a></td></tr>'; 
        //$i++;
    }   
    $stmt->close();
    echo'</table>';

 ?>

What are you trying to do? What link? Where do you expect it to do? What is supposed to link to? What does it link to? (P.S. Your `` tag has nothing inside it) — gen_Eric, Apr 10 '13 at 19:40
when i click in Download, I want to download this image, but I only can watch it. — jal, Apr 10 '13 at 19:41
@jal: What is `$nombre`? (Also, shouldn't `DOWNLOAD` be `DOWNLOAD`?) — gen_Eric, Apr 10 '13 at 19:42
@WesleySchleumer: Good eye! He needs to quote his `href` attribute. — gen_Eric, Apr 10 '13 at 19:44
@jal: What does the generated HTML look like (not the PHP code)? — gen_Eric, Apr 10 '13 at 19:44
@jal: it looks like KPheasey's answer would have helped you here. Would you consider accepting it? It is a good way to express thanks on Stack Overflow. — halfer, Apr 21 '13 at 18:00

score 2 · Accepted Answer · edited May 23 '17 at 11:56

2

Thgis question is similar to another. Please check here - Force file download with php using header()

You need to set the headers for a file transfer.

edited May 23 '17 at 11:56

Community

1
1

answered Apr 10 '13 at 19:46

KPheasey

1,765
16
22

Make sure to set that header in the php file serving the image, not the one linking to it (which is what was pasted) – MrGlass Apr 10 '13 at 19:57

MrGlass · Answer 2 · 2013-04-10T19:55:01.640

0

As @WesleySchleumer said, you need to add quotes to the download link. change:

echo'<tr><td value='.$id.'>DOWNLOAD<a href='.$nombre.'></a></td></tr>';

to:

echo'<tr><td value='.$id.'><a href="'.$nombre.'">DOWNLOAD</a></td></tr>';

edited Apr 10 '13 at 19:55

answered Apr 10 '13 at 19:46

MrGlass

9,094
17
64
89

You should also probably put `DOWNLOAD` *inside* the `` tag. – gen_Eric Apr 10 '13 at 19:48
I just try it and the same... cant download the image. – jal Apr 10 '13 at 19:58
1

@jal: What do you mean by "can't download"? What *exactly* happens when you click on the link? – gen_Eric Apr 10 '13 at 20:02
When I click on the link the image is loaded in real size, but is not downloaded to save on disk – jal Apr 10 '13 at 20:06
For that, you need to set a header for the image file. check this link @kpheasey provided http://stackoverflow.com/questions/8485886/force-file-download-with-php-using-header – MrGlass Apr 10 '13 at 20:23

Link to download doesn't work

2 Answers2