calloc(), malloc() vs new-ing a struct that has an unordered_map inside

Question

I am creating a struct that has a field that is an unordered_map on the heap. When I use new, I can add to it with no problem. But with calloc, I get an error inserting because the bucket size is 0. It works fine after I call reserve.

So, when calloc is called on the struct, does the unordered_map constructor not run? I am confused why if it was in a struct that was new-ed, it seems to have a non-zero bucket size. And is there a better way to go about this besides calling the reserve? (I can't use delete in this case, so I need to stick with the calloc call)

it's legacy code. I'm just adding a new field to it which happens to be an unordered map. — jamesatha, Apr 11 '13 at 07:47
Fair enough. I suppose that means you can't use placement new either? — Pubby, Apr 11 '13 at 07:49

score 5 · Accepted Answer · edited May 23 '17 at 10:28

You are correct, malloc() et al don't run constructors, whereas new does.

You can't rely on the fact that calling reserve() after calloc() appears to fix the problem. It doesn't. The behaviour of your code is still undefined, and it can blow up at any moment and in any way it pleases.

One way to fix the problem is to use placement new to call the unordered_map's constructor.

Alternatively, you could turn the field into a pointer, calloc() the struct, and then use new to allocate and construct the unordered_map. If you do this, you'll have to manually delete it.

score 1 · Answer 2 · edited May 23 '17 at 11:55

1

C memory allocation functions don't usually call constructors. See malloc vs new. The first answer sums it up quite nicely: don't use malloc in C++.

edited May 23 '17 at 11:55

Community

1
1

answered Apr 11 '13 at 07:47

Martin Törnwall

9,299
2
28
35

Usually? They'll *never* call the constructor. (well, `char` may be the one exception) – Pubby Apr 11 '13 at 07:48
Seeing as I cannot possibly know the behaviour of every implementation, I stuck with usually. – Martin Törnwall Apr 11 '13 at 07:50

score 0 · Answer 3 · answered Apr 11 '13 at 07:47

calloc does nothing to initialize your objects qua objects. It's basically handing you a pointer to some memory filled with zeroes. So any internal fields that require initialization, like your map, don't get it. You shouldn't be using calloc in conjunction with objects. (Indeed, you probably shouldn't need it at all.)

calloc(), malloc() vs new-ing a struct that has an unordered_map inside

3 Answers3