Data not inserting into table in Mysql/Php

Question

Dont know where the problem is.. but data is not showing up in the data base..

if(isset($_POST['sign up']))
{
$name=$_REQUEST['username'];
$password=$_REQUEST['password'];
$fname=$_REQUEST['fname'];
$lname=$_REQUEST['lname'];
$email=$_REQUEST['email'];
mysql_query("insert into sign_up ('username','password','fname','lname','email')         VALUES('$name' , md5('$password') , '$fname' , '$lname','$email'");
}

This is the obligatory notice that you shouldn't be using the deprecated mysql_* functions. Instead mysqli_* or PDO is strongly recommended. More here: http://stackoverflow.com/questions/12859942/why-shouldnt-i-use-mysql-functions-in-php — pilsetnieks, Apr 16 '13 at 14:44
this question is closed but simply you can add one ) small bracket at the end of your mysql_query before you have ended your query with double quotes ". Try it it will simply solve your problem — Php developer, Aug 07 '13 at 04:56

score 3 · Answer 1 · edited May 23 '17 at 12:04

The problem is with your column in the INSERT clause, they should not be wrap with single quotes as they are identifiers not string literals.

insert into sign_up (username,password,fname,lname,email) VALUES(...)

Since none of them are reserved keywords, backticks are optional around them.

MySQL - when to use single quotes, double quotes, and backticks?

As a sidenote, the query is vulnerable with SQL Injection if the value(s) of the variables came from the outside. Please take a look at the article below to learn how to prevent from it. By using PreparedStatements you can get rid of using single quotes around values.

How to prevent SQL injection in PHP?

score 0 · Answer 2 · answered Apr 16 '13 at 14:08

0

Use mysql_error() to get the error that is occurring. If this is all your code, it doesn't look like you're making a database connection first.

answered Apr 16 '13 at 14:08

Camron

308
1
7

score 0 · Answer 3 · answered Apr 16 '13 at 14:12

Just remove the single quotes around your database column names and it should work:

mysql_query("insert into sign_up (username, password, fname , lname , email) VALUES('$name' , md5('$password') , '$fname' , '$lname','$email'");

You also need to at least escape your data before inserting, and it is not safe to use MD5() for hashing passwords.

A really nice thing to read is here: It has covered a LOT with just little (enough) text - not only hashing:

http://www.phptherightway.com/#password_hashing

score 0 · Answer 4 · answered Apr 16 '13 at 14:13

I know the answer section is the wrong place for this but I can not seem to comment on your post, I think it might be because I am a new user...

Please read up on SQL injection before you put this on the internet. You need to put protection into your inputs.

Data not inserting into table in Mysql/Php

4 Answers4