ListView setOnItemClickListener Does Not Trigger When An Item Has a Link In It

Question

I am working on integrating Twitter in an app and while all works as it should I am stumped on the setOnItemClickListener() not triggering when a ListView item has a link in it. It works just fine when an item does not have a link (URL) in it.

Clicking on the URL itself opens the web page in a Browser.

Please see the screenshots added as reference at the end of the post.

It is a custom ListView that employs a BaseAdapter. I am not sure which piece of code to put in but on being pointed to a code block that the folks here may need, I will add it immediately.

The idea behind needing to ignore the links (URLs) in an item is to provide a functionality that shows the tweet details when a user clicks on one. Something similar to what the Twitter Android app does.

So what do I do to make the setOnItemClickListener() ignore the links in items?

UPDATED:

Okay. SO I am not sure if it is relevant to the question, but, from a combination of a few solutions from SO which led me to the TweetLanes Open Source project, I have managed to get a few things working. But unfortunately, it doesn't address my primary question.

How do I make the setOnItemClickListener() ignore the links in an item so I can click it and show the details in another Activity and yet, when I click on a link, not trigger the setOnItemClickListener()? I keep getting partial solutions in every attempt I make. But at times, when I click on a link, the setOnItemClickListener() triggers too.

This is how it the flow looks at the moment:

In the top two screenshots, it works as it should. Not clicking on a link after all.

In the bottom two, however, when I click on the @ibnlive link, it shows the Profile for the user (@ibnlive). This part is derived from the TweetLanes source. The problem is, the click listener is also triggered. This is one of the solutions I am trying out. In this case, I have commented out the setOnItemClickListener() and am using a OnClickListener() on the TextView. This is the one method which has partial success so far.

Answer 1

In order to support listItem's click events and supporting links inside records, you should set android:descendantFocusability="blocksDescendants" at the top-level layout of your list-record's xml.

Answer 2

That's because link is clickable and listItem is also clickable, so here, link takes the focus and hence listItem cannot be clicked.

You just need to set :

Set all items android:focusable="false"

and android:focusableInTouchMode="false" of listItem.

Answer 3

Have you tried the next code (based on this link) :

textView.setMovementMethod(null);

?

---

EDIT: here's a working solution:

textView.setOnTouchListener(new OnTouchListener() 
    {
    @Override
    public boolean onTouch(final View v, final MotionEvent event) 
        {
        if (event.getAction() == MotionEvent.ACTION_UP)
          {
          // <=handle clicking here
          }
        return true;
        }
   });

Answer 4

You probably want to take a look at babay's answer on ListView: TextView with LinkMovementMethod makes list item unclickable?

He presents a TextView that issues this problem basically by introducing a different LinkMovementMethod:

public static class LocalLinkMovementMethod extends LinkMovementMethod{
    static LocalLinkMovementMethod sInstance;


    public static LocalLinkMovementMethod getInstance() {
        if (sInstance == null)
            sInstance = new LocalLinkMovementMethod();

        return sInstance;
    }

    @Override
    public boolean onTouchEvent(TextView widget, Spannable buffer, MotionEvent event) {
        int action = event.getAction();

        if (action == MotionEvent.ACTION_UP ||
                action == MotionEvent.ACTION_DOWN) {
            int x = (int) event.getX();
            int y = (int) event.getY();

            x -= widget.getTotalPaddingLeft();
            y -= widget.getTotalPaddingTop();

            x += widget.getScrollX();
            y += widget.getScrollY();

            Layout layout = widget.getLayout();
            int line = layout.getLineForVertical(y);
            int off = layout.getOffsetForHorizontal(line, x);

            ClickableSpan[] link = buffer.getSpans(off, off, ClickableSpan.class);

            if (link.length != 0) {
                if (action == MotionEvent.ACTION_UP) {
                    link[0].onClick(widget);
                } else if (action == MotionEvent.ACTION_DOWN) {
                    Selection.setSelection(buffer,
                            buffer.getSpanStart(link[0]),
                            buffer.getSpanEnd(link[0]));
                }

                if (widget instanceof TextViewFixTouchConsume){
                    ((TextViewFixTouchConsume) widget).linkHit = true;
                }
                return true;
            } else {
                Selection.removeSelection(buffer);
                Touch.onTouchEvent(widget, buffer, event);
                return false;
            }
        }
        return Touch.onTouchEvent(widget, buffer, event);
    }
}

---

Solution NOT TESTED

Based on it, I advice you to fix the file TwitterLinkify.java (the function that sets the link movement) like this:

private static final void addLinkMovementMethod(TextView t) {
    MovementMethod m = t.getMovementMethod();

    if ((m == null) || !(m instanceof LocalLinkMovementMethod)) {
        if (t.getLinksClickable()) {
            t.setMovementMethod(LocalLinkMovementMethod.getInstance());
        }
    }
}

Thanks

Answer 5

Please have a look at this .

text_url.setText(Html.fromHtml(url.toString().trim()));
        Linkify.addLinks(text_url, Linkify.ALL);

This is the line i am using to show the url in list view. if you do the above lines in your getview the link will become blue color with the underline automatically.if you click that one it will open the browser automatically.

Hope this will help you.

EDIT

Hi have a look at this edited answer. i have verified it. it will open the correct url . hope this will help you.

 String url="www.google.com";
        String name="@sampleuser";  
     textview1.setText(Html.fromHtml("<a href='http://"+url+"'>http://"+name+"</a>")); 
     textview1.setMovementMethod(LinkMovementMethod.getInstance());

EDIT 2 Hi have a look at this sample. hope this will help you .

package com.example.listwithclick;
import java.util.ArrayList;
import android.app.Activity;
import android.content.Context;
import android.os.Bundle;
import android.text.Html;
import android.text.method.LinkMovementMethod;
import android.view.LayoutInflater;
import android.view.Menu;
import android.view.View;
import android.view.ViewGroup;
import android.widget.BaseAdapter;
import android.widget.ListView;
import android.widget.TextView;

public class MainActivity extends Activity {


    ListView listView1;
    Activity activity;
    ArrayList<String>urls=new ArrayList<String>();
    ArrayList<String>name=new ArrayList<String>();

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        activity=this;

        urls.add("www.google.com");
        name.add("@googleuser");

        urls.add("www.yahoo.com");
        name.add("@yahoouser");
        urls.add("www.facebook.com");
        name.add("@facebookuser");
        urls.add("www.linkedin.com");
        name.add("@linkedinuser");

        listView1=(ListView)findViewById(R.id.listView1);
        listView1.setAdapter(new MyAddapter(MainActivity.this));

    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.main, menu);
        return true;
    }
     class MyAddapter extends BaseAdapter {
            Context rContext;
            private LayoutInflater rInflater;

            public MyAddapter(Context c) {

                rInflater = LayoutInflater.from(c);

                rContext = c;

            }      

            public MyAddapter(Activity imagebinding) {
                // TODO Auto-generated constructor stub

                activity = imagebinding;        

                rContext = imagebinding;
                rInflater = LayoutInflater.from(imagebinding);
                rContext = imagebinding;
                rInflater = (LayoutInflater) activity
                        .getSystemService(Context.LAYOUT_INFLATER_SERVICE);



            }

            @Override
            public int getCount() {
                // TODO Auto-generated method stub  


                return urls.size();
            }

            @Override
            public Object getItem(int arg0) {
                // TODO Auto-generated method stub
                return null;
            }

            @Override
            public long getItemId(int position) {
                // TODO Auto-generated method stub
                return 0;
            }

            @Override
            public View getView(final int position, View convertView,
                    ViewGroup parent) {
                // TODO Auto-generated method stub
                convertView = rInflater.inflate(R.layout.child, null);
                final MyDat mydat = new MyDat();                

                mydat.textview = (TextView) convertView.findViewById(R.id.textview_name);
                mydat.textview.setText(Html.fromHtml("<a href='http://"+urls.get(position).toString()+"'>"+name.get(position).toString()+"</a>")); 
                mydat.textview.setMovementMethod(LinkMovementMethod.getInstance());

                return convertView;
            }

            class MyDat {


                TextView  textview;


            }

        }

}