Issue Incrementing a Value Inside an ActionListener

Question

I'm trying to increment/decrement a user score as appropriate inside a text field on a (very) basic GUI. How, I only succeed in decrementing even though there is proof my conditional works correctly. Here is the pertinent code; I can supply more as needed.

//buttons: array of JButtons
//scoretxt: JTextField holding the score
//name- object name stored as string in separate string array
//check- odd numbers pass incorrect, evens pass correct
//safe: JTextArea for output

for (int i = 0; i < 18; i++) {
    final String myname = "" + (buttons[i].getClientProperty("name"));
    final String myval = "" + (buttons[i].getClientProperty("value"));
    final String corr = "" + (buttons[i].getClientProperty("check"));
    buttons[i].addActionListener(new ActionListener() {
        public void actionPerformed(ActionEvent e) {
            safe.append(myname + " " + ("" + myval));
            if (corr == "correct") {
                safe.append(" " + corr + "\n");
                scoretxt.setText("" + ((Integer.parseInt(scoretxt.
                        getText())) + 1));
            } else {
                safe.append(" " + corr + "\n");
                scoretxt.setText("" + ((Integer.parseInt(scoretxt.
                        getText())) - 1));
            }
        }
    });

    mygui.add(buttons[i]);
}

I have tried various approaches but I always rely on scoretxt.getText() to pass a value. Any and all help is appreciated, thanks.

this probably won't help, but just to clean up the code, have you tried saving getText() to a variable? e.g. int score = Integer.parseInt(scoretxt.getText()) — Johnathan Au, Apr 28 '13 at 00:11
yes, i have- final int mytemp = Integer.parseInt(scoretxt.getText()); for one version — Antidiscrete, Apr 28 '13 at 00:13
@Antidiscrete, Did you check if the condition `corr=="correct"` gets true and goes inside `if` block where increment happens ? — Ravi Trivedi, Apr 28 '13 at 00:14
On top of what Ravi said. It should be corr.equals("correct"). Never do a comparison with Strings with == — Johnathan Au, Apr 28 '13 at 00:16
@JohnathanAu, you are right. String comparison does not work like that. good catch. That is the problem. Antidiscrete needs to use string.equal method. — Ravi Trivedi, Apr 28 '13 at 00:18
@Ravi Trivedi I have and to confirm the condition is met the output looks like this: onelft 5 - correct onergt 9 - incorrect(format is "name" value" "corr") — Antidiscrete, Apr 28 '13 at 00:19
@Antidiscrete, how you are comparing strings is wrong. You need to use string.equals method. That should fix the problem. — Ravi Trivedi, Apr 28 '13 at 00:20
Lol, the .equals change actually solved it. Boy do I feel stupid. +1 to all of you for a quick and effective solution, thank you. — Antidiscrete, Apr 28 '13 at 00:21
Don't worry. Everyone makes silly mistakes when programming! — Johnathan Au, Apr 28 '13 at 00:22

score 1 · Answer 1 · edited May 23 '17 at 11:49

1

You should be using the equals() method to compare two strings.

corr.equals("correct");

Please refer to How do I compare strings in Java?

edited May 23 '17 at 11:49

Community

1
1

answered Apr 28 '13 at 00:18

Johnathan Au

5,244
18
70
128

Issue Incrementing a Value Inside an ActionListener

1 Answers1