Better way to constantly run function periodically in C#

Question

I have a C# program that is constantly checking for new additions to an online DB. I have this code to have it check every 10 seconds

    static void Main(string[] args)
    {
        boolean run = true;
        while (run)
        {
            DBConnect Db = new DBConnect();

            // do amazing awesome mind blowing cool stuff

            Db.closeConnection();

            // wait for 10 seconds
            int wait = 10 * 1000;
            System.Threading.Thread.Sleep(wait);
        }
    }

i have error reporting that posts to the DB and if a major error occurs the program shuts down. Outside of the specific errors within my function, is this method secure and efficient?

Efficient = not using unnecessary resources, secure = stable program for constant operation @PeteBaughman — Dan, May 02 '13 at 22:43
i am relatively new to C#, i may have overlooked a better way to accomplish my goal. @AshBurlaczenko — Dan, May 02 '13 at 22:44
This sounds like a good case for using Sql Dependency http://msdn.microsoft.com/en-CA/library/a52dhwx7(v=vs.80).aspx — Justin Bicknell, May 02 '13 at 22:46
Also you can run a timer instead of a thread sleep, it's a minor thing though. — oleksii, May 02 '13 at 22:49

Scott Chamberlain · Accepted Answer · 2017-01-11T14:40:11.373

You should rewrite your program as a windows service, that way you do not need to rely on a user to be logged for your program to run.

If you do go with the service route, I would swap out the infinite loop for a timer.

public partial class Service1 : ServiceBase
{
    public Service1()
    {
        InitializeComponent();
        int wait = 10 * 1000;
        timer = new Timer(wait);
        timer.Elapsed += timer_Elapsed;

        // We don't want the timer to start ticking again till we tell it to.
        timer.AutoReset = false;
    }

    private System.Timers.Timer timer;

    protected override void OnStart(string[] args)
    {
        timer.Start();
    }

    void timer_Elapsed(object sender, ElapsedEventArgs e)
    {
        try
        {
            DBConnect Db = new DBConnect())
            try
            {
                // do amazing awesome mind blowing cool stuff
            }
            finally
            {
                Db.closeConnection(); //We put this in a finally block so it will still happen, even if an exception is thrown.
            }
            timer.Start();
         }
         catch(SomeNonCriticalException ex)
         {
             MyExecptionLogger.Log(ex, Level.Waring); //Log the exception so you know what went wrong
             timer.Start(); //Start the timer for the next loop
         }
         catch(Exception ex)
         {
             MyExecptionLogger.Log(ex, Level.Critical); //Log the exception so you know what went wrong
             this.Stop(); //Stop the service
         }
    }

    protected override void OnStop()
    {
        timer.Stop();
    }
}

very cool, so a windows service essentially runs in background regardless of which user is logged? like svchost? — Dan, May 02 '13 at 22:47
very simple and effective, thank you for taking the time to enlighten me! — Dan, May 02 '13 at 22:54
@Dan You want to handle what your program does in situations where stuff goes wrong. I updated my code to log to a fictitious function then stop the service when an exception is thrown. — Scott Chamberlain, May 02 '13 at 23:06

score 5 · Answer 2 · answered May 02 '13 at 22:49

5

Write it as a console program without the wait and set up a scheduled task to run it periodically. You want to run it every 10 seconds? Every minute? Just change the scheduled task.

You can use the Task Scheduler GUI, or the schtasks command line tool.

See Programs are not cats.

answered May 02 '13 at 22:49

Jim Mischel

131,090
20
188
351

Oh man, this is a great alternative as well - i don't know which answer to pick! – Dan May 02 '13 at 22:52
1

What's the thing about cats? :) Also a good alternative, vote up – Luis Filipe May 02 '13 at 23:19

score 3 · Answer 3 · answered May 02 '13 at 22:56

I would setup a windows service and use SqlDependency http://msdn.microsoft.com/en-CA/library/a52dhwx7(v=vs.80).aspx. That way when a change (which you specify) occurs in the database, it will trigger the OnChange event which you specify to do whatever it is you need to do. See the link for implementation details.

Better way to constantly run function periodically in C#

3 Answers3

Linked

Related