File opened with readfile is not being shown

Question

<p>
<?php
$filename = $_GET['package'];
echo readfile("$filename.txt");
?></p>

This is a part of my html, and I want to use this url to read the filename of a txt:

http://example.com/something.html?package=new

if I am using this, the html must show the contents of new.txt, but nothing.

I've set error_reporting(-1) but there is no error.

What was my error?

Yogesh Suthar · Answer 1 · 2013-05-03T12:45:57.220

1

You have done wrong concatenation here

change this

echo readfile("$filename.txt");

to

readfile($filename . ".txt");

edited May 03 '13 at 12:45

answered May 03 '13 at 12:38

Yogesh Suthar

hek2mgl · Accepted Answer · 2013-05-03T12:53:31.113

0

you need no echo for readfile. readfile() will output the contents directly

readfile("$filename.txt");

Manual:

Reads a file and writes it to the output buffer.

Note that this causes problems as readfile() will return the number of bytes read from the file. So your content - if exist - will look like:

hello world
12

(note the linefeed, that's why 12, not 11)

But this doesn't cause the problem, that the file isn't found. You should check if $filename really exists!

edited May 03 '13 at 12:53

answered May 03 '13 at 12:39

hek2mgl

@Cydie What gives you `var_dump($filename);`? – hek2mgl May 03 '13 at 12:49
And what gives you `var_dump(file_exists($filename . '.txt'));` ? – hek2mgl May 03 '13 at 13:02
the answer with extension's was good. – Robin Vekety May 03 '13 at 13:27
Looks like it is working now? :) – hek2mgl May 03 '13 at 13:33
yes, but in this site looks like they are doing something similar with html, (i mean the url): `http://sphinxsearch.com/forum/forum.html?id=1` – Robin Vekety May 03 '13 at 13:36
Yes you can configure your web server to parse other extensions as php as well. but this is not the default configuration. – hek2mgl May 03 '13 at 13:45
ohh ok, that was the best answer today ;) – Robin Vekety May 03 '13 at 13:48

score -1 · Answer 3 · answered May 03 '13 at 12:38

-1

try this

<p>
<?php
  $filename = $_GET['package'].".txt";
  echo readfile($filename);
?></p>

answered May 03 '13 at 12:38

deepi

3 Answers3