identify iPhone 3, 4 and 5 in the same #define

Question

I've been using the next line in my constants to differentiate between devices and get back the number of the device. What's the appropriate way to identify iPhone 5 and still keep it in a one line format?

#define iPhoneType [[UIScreen mainScreen] scale]==2 || [UIDevice currentDevice].userInterfaceIdiom == UIUserInterfaceIdiomPad ? @"4" : @"3"

Thanks

Edit: A lot of good answers but my goal is to keep it in a one line format for all devices.

Edit: Based on the comments, this question needs some clarification. Here are the requirements:

1. A single-line macro that returns either @"3", @"4", or @"5" depending on the iOS device.
2. The 4" devices (currently iPhone 5 and 5th gen iPod touch) should return @"5".
3. All iPads and all remaining retina iPhones and iPod touches should return @"4".
4. All remaining non-retina iPhones and iPod touches should return @"3".

Answer 1

According to your question I'm assuming you want to identify the hardware device, not the iOS version.

/*
Erica Sadun, http://ericasadun.com
iPhone Developer's Cookbook, 6.x Edition
BSD License, Use at your own risk
*/

#include <sys/sysctl.h>

NSString* getSysInfoByName(char* typeSpecifier) {
    size_t size;
    sysctlbyname(typeSpecifier, NULL, &size, NULL, 0);
    char *answer = malloc(size);
    sysctlbyname(typeSpecifier, answer, &size, NULL, 0);
    NSString *results = [NSString stringWithCString:answer encoding: NSUTF8StringEncoding];
    free(answer);
    return results;
}

NSString* platform() {
    return getSysInfoByName("hw.machine");
}

Import those functions in the .pch, then you are free to call this one liner:

BOOL isIphone5 = [platform() hasPrefix:@"iPhone5"];

It works for any device. See UIDevice-Hardware.m for a list of the strings returned.

Answer 2

Define Following Constants in .pch file of your project

#define IS_IPHONE5          ([[UIScreen mainScreen] bounds].size.width >= 568 || [[UIScreen mainScreen] bounds].size.height >= 568)?YES:NO
#define IS_IPHONE           (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPhone)?YES:NO
#define IS_IPAD             (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad)?YES:NO

#define DeviceType          ((IS_IPAD)?@"IPAD":(IS_IPHONE5)?@"IPHONE 5":@"IPHONE")

Now Check device type

NSLog(@"%@ %@",DeviceType,[DeviceType isEqualToString:@"IPAD"]?@"YES":@"NO");

Use following sequence to Identify Device Type

if(IS_IPAD)
    NSLog(@"IPAD");
else if(IS_IPHONE5)
    NSLog(@"IPHONE 5");
else
    NSLog(@"IPHONE");

Answer 3

Assuming the updated requirements are correct, the following should work:

#define iPhoneType (fabs((double)[UIScreen mainScreen].bounds.size.height - (double)568) < DBL_EPSILON) ? @"5" : ([UIScreen mainScreen].scale==2 || UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad ? @"4" : @"3")

This will return @"5" for the 4" screened iPhones and iPod touches. This will return @"4" for all iPads and retina iPhones and iPod touches. And it will return @"3" for non-retina iPhones and iPod touches.

Answer 4

The best way to identify the different iOS devices programatically is their screen resolution. I done same in my application it is working great. Please refer my code.

- (NSString *) getDeviceScreenWidth
{
    CGRect screenBounds = [[UIScreen mainScreen] bounds];
    CGFloat width = CGRectGetWidth(screenBounds);
    NSNumber* number = [NSNumber numberWithFloat:width];
    NSNumberFormatter *numberFormatter = [[NSNumberFormatter alloc] init];
    [numberFormatter setNumberStyle:kCFNumberFormatterDecimalStyle];
    NSString* commaString = [numberFormatter stringForObjectValue:number];
    NSString *screenWidth = [NSString stringWithFormat:@"%@",commaString];
    NSLog(@"screen Width is: %@",screenWidth);
    return screenWidth;
}

- (NSString *) getDeviceScreenHeight
{
    CGRect screenBounds = [[UIScreen mainScreen] bounds];
    CGFloat height = CGRectGetHeight(screenBounds);
    NSNumber* number = [NSNumber numberWithFloat:height];
    NSNumberFormatter *numberFormatter = [[NSNumberFormatter alloc] init];
    [numberFormatter setNumberStyle:kCFNumberFormatterDecimalStyle];
    NSString* commaString = [numberFormatter stringForObjectValue:number];
    NSString *screenHeight = [NSString stringWithFormat:@"%@",commaString];
    NSLog(@"screen height is: %@",screenHeight);
    return screenHeight;
}

Answer 5

As sample you may found this code in cocos2d framework:

-(NSInteger) runningDevice
{
    NSInteger ret=-1;

#ifdef __CC_PLATFORM_IOS

    if( UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad)
    {
        ret = (CC_CONTENT_SCALE_FACTOR() == 2) ? kCCDeviceiPadRetinaDisplay : kCCDeviceiPad;
    }
    else if( UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPhone )
    {
        // From http://stackoverflow.com/a/12535566
        BOOL isiPhone5 = CGSizeEqualToSize([[UIScreen mainScreen] preferredMode].size,CGSizeMake(640, 1136));

        if( CC_CONTENT_SCALE_FACTOR() == 2 ) {
            ret = isiPhone5 ? kCCDeviceiPhone5RetinaDisplay : kCCDeviceiPhoneRetinaDisplay;
        } else
            ret = isiPhone5 ? kCCDeviceiPhone5 : kCCDeviceiPhone;
    }

#elif defined(__CC_PLATFORM_MAC)

    // XXX: Add here support for Mac Retina Display
    ret = kCCDeviceMac;

#endif // __CC_PLATFORM_MAC

    return ret;
}

I hope this code helps change your macro.