Issue with a variable in my batch script

Question

I want my script to:

What is wrong with the following code? The ECHO statement just prints Your directory is set to; the DIR statement works as expected.

@ECHO OFF
SET custompath = "C:\Users\%1"
ECHO  Your directory is set to %custompath%
DIR %custompath%

score 2 · Accepted Answer · edited May 23 '17 at 12:00

2

It's the space around the =.

@ECHO OFF
SET custompath="C:\Users\%1"
ECHO  Your directory is set to %custompath%
DIR %custompath%

edited May 23 '17 at 12:00

Community

answered May 09 '13 at 20:56

MrCleanX

`echo DIR %custompath%` --> `DIR` `echo DIR %custompath %` --> `DIR "C:\Users\"` – Endoro May 09 '13 at 21:19
Works fine, as long as the path exists ;) – MrCleanX May 09 '13 at 21:28

score 0 · Answer 2 · answered May 09 '13 at 23:45

0

Personally, I would do it this way:

@ECHO OFF
SET /P "custompath=Enter a custom windows path: "
ECHO Showing contents of directory ^"%custompath%^"
DIR /b "%custompath%"
pause

answered May 09 '13 at 23:45

djangofan

2 Answers2