Can using lambdas as event handlers cause a memory leak?

Question

Say we have the following method:

private MyObject foo = new MyObject();

// and later in the class

public void PotentialMemoryLeaker(){
  int firedCount = 0;
  foo.AnEvent += (o,e) => { firedCount++;Console.Write(firedCount);};
  foo.MethodThatFiresAnEvent();
}

If the class with this method is instantiated and the PotentialMemoryLeaker method is called multiple times, do we leak memory?

Is there any way to unhook that lambda event handler after we're done calling MethodThatFiresAnEvent?

As indicated in the answers below, there is no way to unhook it without conserving a reference. However, you can have it unhook itself: http://stackoverflow.com/questions/1747235/weak-event-handler-model-for-use-with-lambdas/1747236#1747236 — Benjol, Nov 17 '09 at 07:57

score 16 · Accepted Answer · answered Aug 19 '08 at 16:08

Yes, save it to a variable and unhook it.

DelegateType evt = (o, e) => { firedCount++; Console.Write(firedCount); };
foo.AnEvent += evt;
foo.MethodThatFiresAnEvent();
foo.AnEvent -= evt;

And yes, if you don't, you'll leak memory, as you'll hook up a new delegate object each time. You'll also notice this because each time you call this method, it'll dump to the console an increasing number of lines (not just an increasing number, but for one call to MethodThatFiresAnEvent it'll dump any number of items, once for each hooked up anonymous method).

score 4 · Answer 2 · answered Aug 19 '08 at 16:11

4

You wont just leak memory, you will also get your lambda called multiple times. Each call of 'PotentialMemoryLeaker' will add another copy of the lambda to the event list, and every copy will be called when 'AnEvent' is fired.

answered Aug 19 '08 at 16:11

Wilka

28,701
14
75
97

score 3 · Answer 3 · answered Aug 19 '08 at 16:31

3

Well you can extend what has been done here to make delegates safer to use (no memory leaks)

answered Aug 19 '08 at 16:31

Vaibhav

11,310
11
51
70

score 2 · Answer 4 · answered Aug 19 '08 at 16:19

Your example just compiles to a compiler-named private inner class (with field firedCount and a compiler-named method). Each call to PotentialMemoryLeaker creates a new instance of the closure class to which where foo keeps a reference by way of a delegate to the single method.

If you don't reference the whole object that owns PotentialMemoryLeaker, then that will all be garbage collected. Otherwise, you can either set foo to null or empty foo's event handler list by writing this:

foreach (var handler in AnEvent.GetInvocationList()) AnEvent -= handler;

Of course, you'd need access to the MyObject class's private members.

score 0 · Answer 5 · edited Jun 27 '12 at 13:20

0

Yes in the same way that normal event handlers can cause leaks. Because the lambda is actually changed to:

someobject.SomeEvent += () => ...;
someobject.SomeEvent += delegate () {
    ...
};

// unhook
Action del = () => ...;
someobject.SomeEvent += del;
someobject.SomeEvent -= del;

So basically it is just short hand for what we have been using in 2.0 all these years.

edited Jun 27 '12 at 13:20

user7116

63,008
17
141
172

answered Aug 19 '08 at 16:09

Nick Berardi

54,393
15
113
135

Can using lambdas as event handlers cause a memory leak?

5 Answers5

Linked