Why shouldn't we simply use
string s=product.Name+" has been saved";
instead of:
string s=string.Format("{0} has been saved", product.Name);
Asked
Active
Viewed 203 times
0
Aparan
- 1,263
- 3
- 12
- 17
-
6Coz in the first case you missed a `space` after the product name – V4Vendetta May 28 '13 at 10:41
-
1I tend to use it because you can put a lot of different data types in there, for example numbers without using .ToString (). It just looks neater IMO – Andrew May 28 '13 at 10:41
-
http://blogs.msdn.com/b/ricom/archive/2004/03/12/performance-quiz-1-of-a-series.aspx – Freelancer May 28 '13 at 10:42
-
@Andrew: Can you give an example for that? – Aparan May 28 '13 at 10:43
3 Answers
4
One naive reason would be that it helps to prevent exactly the string formatting issue that you've presented in your original (unedited) question i.e.
string s=product.Name+"has been saved";
requires an extra space. The format method aids readability.
Brian Agnew
- 268,207
- 37
- 334
- 440
3
You could do that, no one say that you cannot. But mainly for readability, the second approach is prefered. It's even more obvious as soon as you concat more than 2 strings, it gets really messy, hard to read and mantain.
Claudio Redi
- 67,454
- 15
- 130
- 155
-
-
1@Aparan go through this once http://blogs.msdn.com/b/ricom/archive/2004/03/12/performance-quiz-1-of-a-series.aspx – Freelancer May 28 '13 at 10:44
-
1@Aparan There actually should be an advantage if you have more than one variable to format. – toasted_flakes May 28 '13 at 10:45
-
@Aparan: the performance advantage is very irrelevant for the very most of the cases, readability impact is much more important to pick one or other approach. – Claudio Redi May 28 '13 at 10:48
3
If you have many strings that you want to add, each + operation create new string.
For adding many strings you can use StringBuilder Class or String.Format
Mzf
- 5,210
- 2
- 24
- 37