IF/ELSE password in Android

Question

I'm very new to Android programming so please forgive me if this is a stupid query.

I have an Edittext for a password field, and a button to submit the password. I also have a couple of Textviews which are hidden (shows if password is correct/incorrect), which I'd like to turn visible using an if/else statement.

When I run the code (on an AVD), nothing happens when I click the submit button. At all, ever.

I know this is probably really simple, but looking at other answers on questions similar to this was no help, I've been trying for days to figure out what I'm doing wrong...

..So ANY help would be really really appreciated. Thank you!! :D

-I use Eclipse, and Android 4.2.2

Here's the Java part:

final TextView success = (TextView) findViewById(R.id.textView1);
final TextView failure = (TextView) findViewById(R.id.textView2);
Button firstButton = (Button)findViewById(R.id.button1);
final EditText userPassword  = (EditText)findViewById(R.id.passwordField);
firstButton.setOnClickListener(
new View.OnClickListener(){
    public void onClick(View v){ 
        if(userPassword.getText().toString() == "pa$$word"){
            success.setVisibility(View.VISIBLE);
        }
        else{
           failure.setVisibility(View.VISIBLE);
        }
    }
});

XML:

<Button android:layout_height="wrap_content" 
android:layout_width="wrap_content" 
android:text="@string/button" 
android:layout_marginBottom="75dp" 
android:layout_centerHorizontal="true" 
android:layout_alignParentBottom="true" 
android:id="@+id/button1"/> 

<EditText android:layout_height="wrap_content" 
android:layout_width="wrap_content" 
android:layout_centerHorizontal="true" 
android:id="@+id/passwordField" 
android:inputType="textPassword" 
android:ems="10" 
android:layout_above="@+id/button1"> 

<requestFocus/> 
</EditText> 
<TextView android:layout_height="wrap_content"
 android:layout_width="wrap_content"
 android:text="@+string/pwCorrect"
 android:layout_marginBottom="124dp"
 android:layout_centerHorizontal="true"
 android:id="@+id/textView1"
 android:layout_above="@+id/passwordField"
 android:visibility="gone"/> 

<TextView android:layout_height="wrap_content"
android:layout_width="wrap_content" 
android:text="@+string/pwIncorrect" 
android:layout_centerHorizontal="true" 
android:id="@+id/textView2" 
android:visibility="gone" 
android:layout_centerVertical="true"/>

You should compare strings with equals, not `==`. – assylias May 28 '13 at 13:42 — assylias, May 28 '13 at 13:42

score 2 · Answer 1 · answered May 28 '13 at 13:42

2

 if(userPassword.getText().toString() == "pa$$word"){

Strings in java have to compared with equals or equalsIgnoreCase. Using == you will compare the address of the String

answered May 28 '13 at 13:42

Blackbelt

156,034
29
297
305

Thanks, unfortunately it still doesn't work with 'if(userPassword.getText().toString().equals("pa$$word"))' – newbie May 28 '13 at 13:47
what does "it does not work" mean ? What are you expectiong to happen? – Blackbelt May 28 '13 at 13:50
i'm hoping it'll show one of the textviews i hid in there – newbie May 28 '13 at 13:52
either will do! i just want to know it can read the input – newbie May 28 '13 at 13:57
he's text is pwCorrect and pwInCorrect.. My guess is that he's positioning those textview out of line – Carnal May 28 '13 at 14:05
it definitely didn't like pwCorrect/pwIncorrect. i *think* the id's are fine, although i'm not entirely sure why i have "pwCorrect" and "pwIncorrect" at all if theyre not id's, there must be some reason though – newbie May 28 '13 at 14:06
You should remove + from @+string, it should be @string/pwCorrect and @string/pwInCorrect – Blackbelt May 28 '13 at 14:10
still made no difference. i'm sorry my ide hates me :-( – newbie May 28 '13 at 14:19
are you able to see it in the Android Xml Graphical editor ? – Blackbelt May 28 '13 at 14:22
just when i change it back to android:visibility="visible" – newbie May 28 '13 at 14:29
Can you see both of them? – Blackbelt May 28 '13 at 14:33
yep, as long as they're both visible – newbie May 28 '13 at 14:36
are you sure the onClick is fired? Comment all your code and put only success.setVisibility(View.VISIBLE) – Blackbelt May 28 '13 at 14:41
what am i looking for when i do that? – newbie May 28 '13 at 14:56
Imo the onClick is not fired. Can you check with the debugger or adding a Log? – Blackbelt May 28 '13 at 14:57
I think you're right i just don't know how to fix it. – newbie May 28 '13 at 15:25
What does "I think you're right" mean ? what have you tried – Blackbelt May 28 '13 at 15:29
i don't think onClick is running because someone mentioned something about it earlier today but supposedly fixed it. i've not tried anything new – newbie May 28 '13 at 15:35

score 2 · Answer 2 · answered May 28 '13 at 13:42

2

Compare string with equals or equalsIgnoreCase

try this

if(userPassword.getText().toString().equals("pa$$word"))

answered May 28 '13 at 13:42

Pragnani

20,075
6
49
74

score 0 · Answer 3 · answered May 28 '13 at 13:44

0

When comparing strings in Java you want to use the following syntax:

if(userPassword.getText().toString().equals("pa$$word"))

Also, I don't think the final is necessary on your EditTexts.

answered May 28 '13 at 13:44

TronicZomB

8,667
7
35
50

I don't know why I have them, Eclipse told me I needed them. Thank you for the help, unfortunately it's still not doing anything. – newbie May 28 '13 at 13:51
Can you post your entire AlertDialog java code? – TronicZomB May 28 '13 at 13:52
@user2428680 if you don't need final modifier declare edittext as a class variable. Initialize in onCreate() – Raghunandan May 28 '13 at 13:53
Actually, I think those do need to be `final` since they're being accessed from an anonymous inner class. – Reinstate Monica -- notmaynard May 28 '13 at 13:59
it's not an alertDialog.. i'm REALLY new to this, it's just on a page. @Raghunandan, thank you for the advice! – newbie May 28 '13 at 14:02

score 0 · Answer 4 · answered May 28 '13 at 13:45

0

Use this, sometime password are in alphabet with caps-lock so better use equalsIgnoreCase

if(userPassword.getText().toString().equalsIgnoreCase("pa$$word"))

answered May 28 '13 at 13:45

Sunil Kumar

7,086
4
32
50

1

For passwords, I don't think you'd want `equalsIgnoreCase()`. They are generally case-sensitive. – Reinstate Monica -- notmaynard May 28 '13 at 13:52

score 0 · Answer 5 · answered May 28 '13 at 13:45

0

use this code snippet

if(userPassword.getText().toString().equalsIgnoreCase("your valid passwor")){

    // do something

}else{

 //wrong password

}

enjoy:) Please don't forget to give +1

answered May 28 '13 at 13:45

Deepak Sharma

4,999
5
51
61

This is my first time not-lurking on this site so I can't +1, sorry :-( – newbie May 28 '13 at 13:50
1

For passwords, I don't think you'd want `equalsIgnoreCase()`. They are generally case-sensitive. – Reinstate Monica -- notmaynard May 28 '13 at 13:51
yeah you are rite..please use equals() in place of equalsIgnoreCase() – Deepak Sharma May 29 '13 at 05:38
that didn't work, read the top comments for my current status. i'm getting nowhere fast! – newbie May 29 '13 at 08:07

IF/ELSE password in Android

5 Answers5