Javascript - Where i'm making a mistake?

Question

i'm creating that script if someone delete the text or link on footer of my template it will redirect to my site, but its redirecting without removing anything.

function loadBody() {
 var elem = document.getElementById("mycontent");
if(elem.innerHTML !== "MySite" || elem.href !== "http://mysite.com")
  window.location="mysite.com"; 
}

here is the footer html

 <div id='mycontent'>       
  <p>&#169; Template is designed by  <a href='http://mysite.com' title=''>Mysite</a></p>
  </div>

thanks in advance.

Is that because the `href` is in fact `"http://mysite.com"` which causes the second clause of your conditional statement to fail thereby always redirecting?! — Travis J, May 29 '13 at 23:15
@anakata It can be either. !== checks type, whereas != does not. For example, 4!=="4". — Brian Hannay, May 29 '13 at 23:17
@anakata - type coercion.. read this: http://stackoverflow.com/a/5101991/1026459 — Travis J, May 29 '13 at 23:17
Just saying that this is really unuseful. If the guy can remove your footer, he can easily remove the script. — Henrique Barcelos, May 29 '13 at 23:20
but i will encode my script like other templates designers :) — user2397942, May 29 '13 at 23:21

score 2 · Accepted Answer · answered May 29 '13 at 23:23

2

This doesn't work because of the structure:

function loadBody() {
    var elem = document.getElementById("mycontent");
if(elem.innerHTML !== "MySite" || elem.href !== "http://mysite.com")
    window.location="mysite.com"; 
}

<div id='mycontent'>       
    <p>&#169; Template is designed by  <a href='http://mysite.com' title=''>Mysite</a></p>
</div>

You are assuming thag the a tag has the mycontent id attribute, but it is on the div above it. So, either you change for this:

<div>       
    <p>&#169; Template is designed by  <a id='mycontent' href='http://mysite.com' title=''>Mysite</a></p>
</div>

Or you have to alter the verification on Javascript.

answered May 29 '13 at 23:23

Henrique Barcelos

7,670
1
41
66

But I insist: this is useless. If someone WANTS to wipe this out, he will. – Henrique Barcelos May 29 '13 at 23:32
i will encode the script and i will add style tag on this script if someone delete the script all the stylesheet of template will be deleted – user2397942 May 29 '13 at 23:37
And what if the guy disables the Javascript of the browser? – Henrique Barcelos May 29 '13 at 23:41
hmmm dontknow more for some bloggers it will work fine my site will got backlins :) – user2397942 May 29 '13 at 23:44

Yotam Omer · Answer 2 · 2013-05-29T23:28:10.627

1

Did you forget http://? + EDIT: use getAttribute. Updated with the new innerHTML

function loadBody() {
 var elem = document.getElementById("mycontent");
if(elem.innerHTML != "<p>&#169; Template is designed by  <a href='http://mysite.com' title=''>Mysite</a></p>")
  window.location="mysite.com"; 
}

edited May 29 '13 at 23:28

answered May 29 '13 at 23:16

Yotam Omer

15,310
11
62
65

Is this an answer or a question? – jsedano May 29 '13 at 23:17
sorry but i remove because of stackover flow i was think link are not allowed – user2397942 May 29 '13 at 23:19

Javascript - Where i'm making a mistake?

2 Answers2