If logical condition with string in C

Question

puts("Type your name");
gets(name);
if(name=="exit"){
    exit(0);
}

My logical conditional in if is wrong, how I can repair it?

How is it wrong? What do you expect it to do and what does it do instead? Do you get error messages? — JJJ, Jun 02 '13 at 18:02
possible duplicate of [Why is "a" != "a" in C?](http://stackoverflow.com/questions/4843640/why-is-a-a-in-c) — Sergey Kalinichenko, Jun 02 '13 at 18:06

score 3 · Accepted Answer · answered Jun 02 '13 at 18:04

3

Since name is a string why don't you use strcmp function?

if (strcmp(name, "exit") == 0)
{
  exit(0);
}

answered Jun 02 '13 at 18:04

Soumik Das

score 1 · Answer 2 · answered Jun 02 '13 at 18:03

1

You can't compare strings that way, use strcmp, or preferably, strncmp

answered Jun 02 '13 at 18:03

Kninnug

1

Why do you recommend `strncmp`? That'd give a false positive for any string starting "exit". – simonc Jun 02 '13 at 18:04
Hmm, that's right, but it is slightly safer. – Kninnug Jun 02 '13 at 18:05
4

@Kninnug No. None of the strings are being written, so `strncmp()` is not any safer. No risk for buffer overflow for properly NUL-terminated strings at all. – Jun 02 '13 at 18:07

2 Answers2