Get view of Fragment from FragmentActivity

Question

I have a FragmentActivity where I add a Fragment. Depending on some situation, I want to access Buttons from that fragment's layout and change click listeners of them.

What I do is:

View view = myFragment.getView();
Button myButton = (Button) view.findViewById(R.id.my_button);
myButton.setOnClickListener(new MyClickListener());

But the view variable is always null.

How can I get the view of the activity?

Note that you're calling `findViewById()` on your activity's view hierarchy, not `view`'s. — laalto, Jun 10 '13 at 12:09
When you do : `Button myButton = (Button) findViewById(R.id.my_button);`, you try to find out the button for your current view which is not your `fragment view` . Hence it's not working as expected . — The Dark Knight, Jun 10 '13 at 12:11
Yes, it is. I am trying to implement SlidingMenu feature. Actually, everything worked fine before adding this feature. — Drastamat, Jun 10 '13 at 12:11

score 34 · Accepted Answer · edited Feb 13 '14 at 13:19

34

If you want to access your component and set some data, I suggest you to make a method inside the fragment like this:

import android.os.Bundle;
import android.support.v4.app.Fragment;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.Button;

public class DetailFragment extends Fragment {

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
            Bundle savedInstanceState) {
        View view = inflater.inflate(R.layout.details, container, false);
        return view;
    }


    public void setSettings(){
        Button button = (Button) getView().findViewById(R.id.my_button);
        button.setOnClickListener(new MyClickListener());
    }
}

edited Feb 13 '14 at 13:19

Mr_and_Mrs_D

32,208
39
178
361

answered Jun 10 '13 at 12:10

Jarvis

1,527
12
17

4

getView() might return null and it does so in many cases. If I call setSettings from Activity's OnCreate method the exception will be thrown – Varvara Kalinina Jan 13 '16 at 13:52
@VarvaraKalinina So `getView ` only works from inside a fragment and not from an activity? – John Aug 07 '19 at 06:57
Just tested it with an activity, there is no such method as `getView` in an activity ([doc link](https://developer.android.com/reference/android/app/Activity)), and you need to keep a member variable for the xml root view, not really ideal to keep a reference to the parent element. [doc link](https://developer.android.com/reference/android/app/Fragment) for fragment which shows `getView` method – John Aug 07 '19 at 07:21
@John In case of Activity you can use findViewById(android.R.id.content) – Varvara Kalinina Aug 07 '19 at 12:24

Volodymyr Yatsykiv · Answer 2 · 2014-12-24T15:58:23.253

try this:

public class YourFragment extends Fragment {

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
          return inflater.inflate(R.layout.your_fragment, null);
    }

    @Override
    public void onActivityCreated(Bundle savedInstanceState) {
        super.onActivityCreated(savedInstanceState);

        View view = getView();
        if(view != null) {
            view.findViewById(R.id.my_button).setOnClickListener(new MyClickListener());
        }
    }
}

this code must works fine. I hope, this will help you.

score 4 · Answer 3 · edited May 23 '17 at 12:02

To set OnClickListeners in fragments, override onViewCreated in your fragment class.

@Override
public void onViewCreated(View view, Bundle savedInstanceState) {
    super.onViewCreated(view, savedInstanceState);
    view.findViewById(R.id.yourId).setOnClickListener(this);
    //or
    getActivity().findViewById(R.id.yourId).setOnClickListener(this);
}

I was trying to set a timertask to automatically reload a webview in a fragment and this method was the only thing that worked for me. My project is on github.

Source: this answer

score 1 · Answer 4 · edited Dec 10 '15 at 15:17

1

When you initialize your button inside a class that extends Fragment it's better to do it inside the onViewCreated() method. This will guarantee that the view already exists.

edited Dec 10 '15 at 15:17

Mokus

3,339
1
24
30

answered Dec 10 '15 at 15:09

Alex P

131
1
6

Aman Gupta - ΔMΔN · Answer 5 · 2017-01-04T14:21:09.140

0

Simply Use the getRootView() method to get the data of your fragment in Activity.

//below block of code write in activity.

EditText et = (EditText) v.getRootView().findViewById(R.id.name);
Log.d("Name", et.getText().toString());

name is the field of fragment.

edited Jan 04 '17 at 14:21

answered Nov 23 '16 at 07:54

Aman Gupta - ΔMΔN

2,971
2
19
39

Get view of Fragment from FragmentActivity

5 Answers5

Linked