Break an external while loop from an inner for loop

Question

I want to break the outer while loop when the condition stop=true is reached in the inner for loop. Is this possible?

urlsToScrape.addAll(startUrls);

    boolean stop=false;

    while(stop==false){
        for(Link url:urlsToScrape){
p.rint(url.depth+" >= "+depth);
            if(url.depth>=depth){
                p.rint("STOP!");
                stop=true;
                break;
            }
p.rint("scrape(): "+url.link+" / "+url.depth);
            processLinks(url.link,url.depth);
            urlsToScrape.remove(url);
            scrapedUrls.add(url);
        }
    }

`while(!stop){` is a better style than `while(stop==false){` — jlordo, Jun 11 '13 at 13:37
Isn't that what already happens? The entire body of the `while` loop is the `for` loop, so if you set `stop` to `true` inside that, then break out of it, the `while` loop will stop iterating. — Anthony Grist, Jun 11 '13 at 13:38
@Anthony I thought that was how it should work, but it didn't seem to. The label technique worked. — Ankur, Jun 11 '13 at 13:39

score 10 · Answer 1 · answered Jun 11 '13 at 13:37

10

Use a label :

 outofthere:
 while (stop==false){
      for(Link url:urlsToScrape){
            p.rint(url.depth+" >= "+depth);
            if(url.depth>=depth){
                p.rint("STOP!");
                stop=true;
                break outofthere;
            }
            p.rint("scrape(): "+url.link+" / "+url.depth);
            processLinks(url.link,url.depth);
            urlsToScrape.remove(url);
            scrapedUrls.add(url);
      }
  }

See Oracle's documentation.

answered Jun 11 '13 at 13:37

Denys Séguret

372,613
87
782
758

1

+1. I always forget to use label in loop and sometimes they are very useful. – Alexis C. Jun 11 '13 at 13:38
@Ankur Just waiting for what exactly ? :) – Denys Séguret Jun 14 '13 at 11:11

Break an external while loop from an inner for loop

1 Answers1