Possible mixed indentation in Python?

Question

Looking at this question, I tried OP's the code on my machine. Here are a text version and a screenshot:

bad square

What just happened? This supposed to be a square function, and it is implemented correctly. To be sure, I copy-pasted the code, and tried it again:

good square

Well, I can't see any difference between these versions of square, but only the latter works.

The only reason I can think of is that I may have mixed tabs and spaces, so the return statement is actually indented, and so the loop is executed exactly once. But I could not reproduce it, and it looks like an unbelievable flaw in the interpreter's mixed-indentation-check. So I have two questions, or maybe three:

What do I miss?
If this is a mixed indentation thing, what it may be, exactly?
If this is a mixed indentation thing, why wasn't it caught by the interpreter? Obviously the whole idea of indentation in python (and in general) is to avoid such problems. And it's too important to let such things slip.

It's helpful if you have your text editor highlight whitespace: http://i.imgur.com/C6fgBgt.png — Blender, Jun 12 '13 at 22:26
@Blender yes it's a good thing. The gnome-terminal doesn't have such an option though. — Elazar, Jun 12 '13 at 22:28
@DavidC.: Sublime Text. It shows whitespace when you highlight text. — Blender, Aug 30 '17 at 17:24

kirelagin · Accepted Answer · 2021-03-12T01:53:05.900

2

Easy!

def square(x):
    runningtotal = 0
    for counter in range(x):
        runningtotal = runningtotal + x
<tab>return runningtotal

First, tabs are replaced (from left to right) by one to eight spaces such that the total number of characters up to and including the replacement is a multiple of eight <...>

So this tab on the last line is replaced with 8 spaces and it gets into the loop.

edited Mar 12 '21 at 01:53

answered Jun 12 '13 at 22:21

kirelagin

13,248
2
42
57

1

and another fact is important: copy-paste from a gnome-terminal removes the tabs. – Elazar Jun 12 '13 at 22:24

John La Rooy · Answer 2 · 2013-06-12T22:39:01.303

For Python indenting - a tab is counted as equivalent to 8 spaces

Since people almost never have their tab width set to 8 spaces, it's never a good idea to mix the two.

Like many people, I used to prefer tabs for indenting, but found that it is a constant source of confusion when emailing code or posting in forums, etc. Which is what has happened here

The most common thing these days is to just have the tab key in your editor insert 4 spaces.

The point is that Python has to respect tabs because of backward compatibility, but it's not a good idea to use them anymore.

As mentioned by @Fredrik, there is the -t option from the man page

      -t     Issue a warning when a source file mixes  tabs  and  spaces  for
              indentation  in a way that makes it depend on the worth of a tab
              expressed in spaces.  Issue an error when the  option  is  given
              twice.

Here the return runningtotal has a tab.

$ python -tt
Python 2.7.4 (default, Apr 19 2013, 18:28:01) 
[GCC 4.7.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> def square(x):
...     runningtotal = 0
...     for counter in range(x):
...         runningtotal = runningtotal + x
...     return runningtotal
  File "<stdin>", line 5
    return runningtotal
                      ^
TabError: inconsistent use of tabs and spaces in indentation

perhaps mention the `-t : issue warnings about inconsistent tab usage (-tt: issue errors)` parameter as well... — Fredrik Pihl, Jun 12 '13 at 22:28
is there a way to make `-t` a default? alias (etc.) is ugly. — Elazar, Jun 12 '13 at 22:33

score 0 · Answer 3 · answered May 03 '21 at 07:02

0

I've faced similar issue, for me the error was Mixed Indentation: Spaces found.

Solution: In Eclipse with Pydev, Source menu -> Convert tabs to space-tabs.

answered May 03 '21 at 07:02

Barun

1,520
2
12
18

Possible mixed indentation in Python?

3 Answers3

Linked