PHP Sort By Drop down

Question

I've taken an answer from a similar question on this site:

and adapted it to my needs but have come stuck on creating a drop down menu to sort products by.

My form code is:

<form name="myform">
        <select name="order_by" onchange="if(this.value != '') document.location = '/equipment.php?cat=<?= $prodCategory;?>&subCat=<?=$subCategory;?>&order_by=' + this.value">
            <option<?php if(isset($_GET['order_by']) && $_GET['order_by'] == 'choose') echo ' selected="selected"'; ?> value="choose">Sort By</option>
            <option<?php if(isset($_GET['order_by']) && $_GET['order_by'] == 'name') echo ' selected="selected"'; ?> value="name">Name</option>
            <option<?php if(isset($_GET['order_by']) && $_GET['order_by'] == 'price') echo ' selected="selected"'; ?> value="price">Price</option>
        </select>
</form>

and my switch statement and query look like this:

 switch($_GET['order_by']) {
            case 'name':
              $order_by = " ORDER BY shortDescription ASC";
              break;
            case 'price':
              $order_by = " ORDER BY rrp ASC";
              break;
          }
        $productQuery = 'SELECT * FROM ********* WHERE subCategory = "' . $subCat[0]['categoryID'] . $order_by . '"';

But for some reason its not sorting them by either of the selections if i choose them.

can someone see any problems with my code?

What do you get when echo the `$productQuery ` – Ghazanfar Mir Jun 14 '13 at 10:29 — Ghazanfar Mir, Jun 14 '13 at 10:29

score 2 · Accepted Answer · answered Jun 14 '13 at 10:29

This is because you have a syntax error. You are not closing quote ' after subCategory value.

$productQuery = 'SELECT * FROM ********* WHERE subCategory = "' . $subCat[0]['categoryID'] . $order_by . '"';
                                                                                         //^ here

So change quotes with double quotes and concatenate correctly to fix your query

$productQuery = "SELECT * FROM ********* WHERE subCategory = '" . $subCat[0]['categoryID'] . "'" .  $order_by;

Thank you thats perfect. I will remember that in future :) Thanks again — Kevlar, Jun 14 '13 at 10:33

score 1 · Answer 2 · answered Jun 14 '13 at 10:54

you were required to change the query section and you have got the right answer, while i have another solution for your sorting.

You can sort all you mySQL data using Ajax and PHP. you will not needed to refresh your page in that case. just follow the URL Sorting MySQL data using PHP and Ajax

PHP Sort By Drop down

2 Answers2

Linked