PHP - While / Else error?

Question

I have the following php code:

<?php




if (!isset($_REQUEST['search'])){

    while(($write=mysql_fetch_array($gamesearched)) != null){
    echo "Found!";
    }else{
    echo "No results";
    }

    }
?>

And it's giving me an error:

Parse error: syntax error, unexpected 'else' (T_ELSE) in C:\php\www\Gameplay\backgame.php on line 41

Because that is not valid syntax... `else` can only be paired with `if`. — DCoder, Jun 15 '13 at 08:46
You've still got the `else` paired with the `while`, not with the `if`. — jcsanyi, Jun 15 '13 at 08:57
Welcome ;). If you find an answer, no need to close this topic. What you can do is "accept" the answer below: press the check on the answer that fixes it. If there isn't one, you might want to write down your own solution and mark that as the correct answer. The goal is to have a clear question-and-answer page here, not a forum-topic to throw away :). Also, I don't see what the other question you asked is about that is different from this one, don't open duplicates! Good luck with your code though :) — Nanne, Jun 15 '13 at 09:15

score 2 · Answer 1 · answered Jun 15 '13 at 08:47

2

PHP doesn't support else in while statements. You will need to use a sentinel instead.

answered Jun 15 '13 at 08:47

Ignacio Vazquez-Abrams

776,304
153
1,341
1,358

1

else is not in while actually. but i know what you meant – Brian Jun 15 '13 at 08:47
@A.S.Roma: It is in the *statement*, even if it isn't in the *block*. – Ignacio Vazquez-Abrams Jun 15 '13 at 08:48
Yes but not in "while statement" :) – Brian Jun 15 '13 at 08:49
@A.S.Roma The *statement* that you have written is `while (something) { ... } else { ... }`. That is not valid PHP - the only valid form of a while statement is `while (something) { ... }`. The error message means exactly what it says - unexpected "else". – jcsanyi Jun 15 '13 at 08:53
Ok, this can be understood in both ways...no more arguments, agree – Brian Jun 15 '13 at 08:56

Brian · Answer 2 · 2013-06-15T09:08:21.120

1

Where is your if??? You are missing IF

Also pay attention that if/else structure is as follows: if() {} -> else {} You still misplaced else, should be outside of if statement.

edited Jun 15 '13 at 09:08

answered Jun 15 '13 at 08:46

Brian

4,958
8
40
56

Nagarjun · Answer 3 · 2013-06-15T09:10:19.083

1

I guess you have misplaced the closing brace. See the possible correct codes below.

if (!isset($_REQUEST['search'])){
  while($write=mysql_fetch_array($gamesearched)){
    if($write != null) {
      echo "Found!";
    }else{
      echo "No results";
    }
  } 
}

or

while(($write=mysql_fetch_array($gamesearched)) != null){
  if (!isset($_REQUEST['search'])){
    echo "Found!";
  } else {
    echo "No results";
  }
}

edited Jun 15 '13 at 09:10

answered Jun 15 '13 at 08:47

Nagarjun

2,346
19
28

Edited the topic, please read the code again (?) – John Lemon Jun 15 '13 at 08:54
That would only display the No Results message if the user isn't clicking in the search button that I have... – John Lemon Jun 15 '13 at 09:06
Since there isn't any while-else statement, how would I do? – John Lemon Jun 15 '13 at 09:07
Your requirement is not clear, check if the edited post is what you are looking for. – Nagarjun Jun 15 '13 at 09:10

score 0 · Accepted Answer · edited May 23 '17 at 10:25

In PHP, a while statement can't have an else clause. You need something external to the while that can tell you if it was executed at least once.

How about something like this?

$total = mysql_num_rows($gamesearched);
if ($total > 0) {
    while (($write=mysql_fetch_array($gamesearched)) !== false) {
        echo "Found!";
    }
} else {
    echo "No results";
}

In this case, I've looked up the total number of rows found before I start, but I could also have started by setting a counter to zero and then incrementing it inside the while loop. That would look something like this:

$total = 0;
while (($write=mysql_fetch_array($gamesearched)) !== false) {
    $total++;
    echo "Found!";
}
if ($total == 0) {
    echo "No results";
}

Note that mysql_fetch_array() returns false if there are no more rows, so I've updated the while condition for you as well.

All that being said, there are good reasons not to use mysql_* functions in new code. See this question for more details, and some better alternatives: Why shouldn't I use mysql_* functions in PHP?

score -1 · Answer 5 · answered Jun 15 '13 at 09:35

-1

1)

if(xxxx){
   //do if
}else{
   //do else
}

2)

if(1):
    echo '123';
else:
    echo '456';
endif;

answered Jun 15 '13 at 09:35

jw.john

362
4
9

PHP - While / Else error?

5 Answers5

Linked

Related