Error and warnings with C program

Question

I have an error on line 41: expected expression before 'int' line 45: suggest parentheses around comparison in operand of '&'

Also I wanted to make sure if the code from 43-45 made sense.

I am posting on this forum for the first time and I am new to C so please bear with the amateur nature of this post

#include<stdio.h>
#include<math.h>
int main(void)

{
 // LOCAL DECLARATIONS

 int bricks; //the number of bricks available
 int spheres; //the number of spheres available
 int prisms; //the number of prisms available
 int final_string(int bricks, int spheres, int prisms); //the longest possible string with the given shapes in an alternating fashion

 // EXECUTABLE STATEMENTS

 printf("\nEnter the number of bricks: ");
 scanf("%d", &bricks);
 printf("Enter the number of spheres: ");
 scanf("%d", &spheres);
 printf("Enter the number of prisms: ");
 scanf("%d", &prisms);
 printf("\nLongest possible string of alternating shapes usuing only two different shapes: %d", int final_string(int bricks, int spheres, int prisms));

 int final_string(int bricks,int spheres,int prisms);
{
 return bricks * (bricks > spheres & bricks > prisms) + spheres * (spheres > bricks & spheres > prisms) + prisms * (prisms > bricks & prisms > spheres);
}

return(0);

You multiply a bool with an integer.This is certainly no right. — Varvarigos Emmanouil, Jun 24 '13 at 16:45
Really? "Line 41 and 45" is a useful *title* for a question?! — Kerrek SB, Jun 24 '13 at 16:46
the code in 43-45 doesn't make sense, to answer your question. It looks like you are trying to define a function inside `main` — tay10r, Jun 24 '13 at 16:46
@PHIfounder - improvement is not needed on the terminal but on its operator :) — dtech, Jun 24 '13 at 17:42
Sorry about the messy code. I will improve and fix things. Thank you for the help. — user2517061, Jun 24 '13 at 18:23

score 4 · Accepted Answer · edited May 23 '17 at 10:25

Remove all the ints from the line:

printf("\nLongest possible string of alternating shapes usuing only two different shapes: %d", int final_string(int bricks, int spheres, int prisms));

Remove the semicolon after the function signature in the definition of final_string
Move final_string outside of main
Use the logical && operator instead of the bitwise &
Buy and read a C book
In the future ask "questions" like this on http://codereview.stackexchange.com

VoidPointer · Answer 2 · 2013-06-24T16:54:36.803

The line,

printf("\nLongest possible string of alternating shapes usuing only two different shapes: %d",  int final_string(int bricks, int spheres, int prisms));

is wrong. In this line, int final_string(int bricks, int spheres, int prisms) is declaration of function and not calling it. Replace it with final_string(bricks, spheres, prisms).

And define that function outside main. In C, function can't nest. So your corrected code would look,

#include<stdio.h>
#include<math.h>
int main(void)
{
    // LOCAL DECLARATIONS

   int bricks; //the number of bricks available
   int spheres; //the number of spheres available
   int prisms; //the number of prisms available
   int final_string(int bricks, int spheres, int prisms); //the longest possible string with the given shapes in an alternating fashion

   // EXECUTABLE STATEMENTS

   printf("\nEnter the number of bricks: ");
   scanf("%d", &bricks);
   printf("Enter the number of spheres: ");
   scanf("%d", &spheres);
   printf("Enter the number of prisms: ");
   scanf("%d", &prisms);
   printf("\nLongest possible string of alternating shapes usuing only two different   shapes: %d", final_string( bricks,  spheres, prisms));
   return(0);
}

int final_string(int bricks,int spheres,int prisms)
{
    return bricks * (bricks > spheres & bricks > prisms) + spheres * (spheres > bricks & spheres > prisms) + prisms * (prisms > bricks & prisms > spheres);
}

score 0 · Answer 3 · answered Jun 24 '13 at 17:17

0

Here you go :

http://cfiddle.net/TyZAKw

As said above you put too many "int" ";" after the function signature when implementing it and & instead of &&

answered Jun 24 '13 at 17:17

Avner Solomon

1,486
11
17

Error and warnings with C program

3 Answers3