PHP Header not redirecting on HTTPS

Question

I want to redirect to a specific url after saving data.

I used:

header('Location: https://linkbook.co/index.php/site/saveUrl');

and it did not worked.

Why?

The entire code:

public function actionSaveUrl(){
            $criteria = new CDbCriteria();
            $criteria->limit = 1;
            $criteria->order = 'id asc';
            $model_url = Url::model()->FindByAttributes(array('saved_to_file'=>0,'status'=>1),$criteria);
            if($model_url){
                echo $model_url->link;
                CurlTool::downloadFile($model_url->link,'url_' . $model_url->id . '.html');
                $model_url->saved_to_file = 1;
                if( $model_url->validate() && $model_url->save() ){
                    echo 1;
                    header('Location: https://linkbook.co/index.php/site/saveUrl');
                    exit();
                }
                else{
                    echo 2;
                }
            }
        }

have you tested commenting these two lines out echo $model_url->link; and echo 1? — Fallen, Jun 25 '13 at 13:34

score 8 · Accepted Answer · answered Jun 25 '13 at 13:31

8

Here's your problem:

echo 1;

You can't send headers after you've already sent output to the browser (unless you are buffering the output). You should have gotten a warning message from PHP when you did this.

answered Jun 25 '13 at 13:31

Eric Petroelje

59,820
9
127
177

nope, even without the echo, is still doesn't work – Ionut Flavius Pogacian Jun 25 '13 at 13:31
@lonut - Is some other part of your code sending output to the browser before that function is called? – Eric Petroelje Jun 25 '13 at 13:32
2

There is also `echo $model_url->link;`. – gen_Eric Jun 25 '13 at 13:33
i removed the echo's and now ... it redirects until time out .... let me see what happenned; yu might be right because this is a wrapper after all – Ionut Flavius Pogacian Jun 25 '13 at 13:34
@Rocket - yup, good catch. – Eric Petroelje Jun 25 '13 at 13:34
this worked. this i must remember – Ionut Flavius Pogacian Jun 25 '13 at 13:34
this is the answer, will accept in 9 minutes – Ionut Flavius Pogacian Jun 25 '13 at 13:35
1

Thank you for taking the time to answer this user. However your answer did only lead to the next question: http://stackoverflow.com/questions/17298921/php-header-location-with-to-many-redirects - By the definition of the book this means that your answer *was not helpful* so technically a -1. Please consider to choose wisely which questions to answer and which better not. We only have to clean up after those users. – hakre Jun 25 '13 at 13:47
@hakre - I think 'helpful' there means it was helpful to the person asking the question, not 'was it helpful to hakre in keeping the riff-raff out' – Eric Petroelje Jun 25 '13 at 14:19
Well if we don't take it out, it rams sometime later into the moderator queue. And helpfulness is in the meaning of the community not only the OP. This Q&A lives longer than the single problem someone has. – hakre Jun 25 '13 at 14:23

score 3 · Answer 2 · edited May 23 '17 at 12:28

There cannot be any output before the header, output can be:

Unintentional:
- Whitespace before
- UTF-8 Byte Order Mark
- Previous error messages or notices
Intentional:
- print, echo and other functions producing output (like var_dump)
- Raw areas before

For more info take a look at this answer!

Also in the future it could be helpful if you enable errors in php, that way you will get an error telling you where other output was generated. You can enable the errors by putting this on top of your php page:

<?php 
ini_set('display_errors', 'On'); 
error_reporting(E_ALL); 
?>

score 2 · Answer 3 · answered Jun 25 '13 at 13:33

The manual explicitly says:

Remember that header() must be called before any actual output is sent, either by normal HTML tags, blank lines in a file, or from PHP. It is a very common error to read code with include, or require, functions, or another file access function, and have spaces or empty lines that are output before header() is called. The same problem exists when using a single PHP/HTML file.

You do:

 // <-- THIS LINE OUTPUTS SOMETHING
 echo $model_url->link;
 ...
 echo 1; // <-- THIS LINE OUTPUTS SOMETHING AS WELL
 // SO THIS WON'T WORK
 header('Location: https://linkbook.co/index.php/site/saveUrl');

So: scan your program for any program line that may output something, and move your header() call before that line.

@RocketHazmat I was just editing that, thanks for the heads up! — fvu, Jun 25 '13 at 13:35

score -1 · Answer 4 · answered Jun 25 '13 at 13:32

-1

First off, you shouldn't have any output before redirection (what is echo 1; for?)

Second, in Yii, you can redirect like this:

$this->redirect('https://linkbook.co/index.php/site/saveUrl');

answered Jun 25 '13 at 13:32

casraf

21,085
9
56
91

1

There is no mentioning of yii anywhere in the question - where did you get that from? – Aleks G Jun 25 '13 at 13:33
1

I can see the structure of his code, I work with Yii myself and I recognized it. Is this really a reason to downvote? Like all others I also mentioned the fact he's showing output before changing headers :/ – casraf Jun 25 '13 at 13:34
@ChenAsraf no one here listens especially if they have high rep. – DevZer0 Jun 25 '13 at 13:38
:( I got downvoted for nothing – casraf Jun 25 '13 at 13:43

PHP Header not redirecting on HTTPS

4 Answers4