2
function gbid(s) {
    return document.getElementById(s);
}

function GetData(cell,row) {
    var excel = new ActiveXObject("Excel.Application");
    var excel_file = excel.Workbooks.Open("Z:/SunCenter/Medicare Customer Experience/Hub/CaliforniaHUB/Plans/H0562_2013_082_EOC.xlsx");
    var excel_sheet = excel.Worksheets("Sheet1");

    gbid('span1').innerText = excel_sheet.Cells(1191,1).Value;  
    gbid('span2').innerText = excel_sheet.Cells(1192,1).Value;  
    gbid('span3').innerText = excel_sheet.Cells(1192,3).Value;  

    excel_file.Close()
    excel.Quit()
}

Whenever the javascript runs (onload) it creates a process in the taskmanager/Processes. The problem is that it wont close it after use. When I run it again, it creates another one. Right now it's just pulling info from an excel file which is working just fine, but it just wont close the exe file in the taskmanager. I thought that excel_file.close would do it and I even put in another one, excel.quit, just in case. Sorry, I just wanted to make sure it worked. I've even taken one away now just in case of conflict but nada. Any help?

Simon MᶜKenzie
  • 8,344
  • 13
  • 50
  • 77
user1739280
  • 73
  • 1
  • 3
  • 14
  • possible duplicate of [Windows 7 Gadget not releasing ActiveX object](http://stackoverflow.com/questions/7249465/windows-7-gadget-not-releasing-activex-object) – Simon MᶜKenzie Jun 26 '13 at 00:27

2 Answers2

4

You need to call excel.Application.Quit(); instead of just excel.Quit();

Justin Self
  • 6,137
  • 3
  • 33
  • 48
  • 1
    Why? [MSDN states](http://msdn.microsoft.com/en-us/library/office/ff839269(v=office.14).aspx) that `excel.Quit` should be sufficient to quit excel. I'm not saying you're wrong, I'd just like to know why this would make a difference. – Simon MᶜKenzie Jun 26 '13 at 00:09
  • It worked! Thank you! Someone needs to put 1 on the answer! It wont let me. – user1739280 Jun 26 '13 at 01:12
1

According to Microsoft, because you're still holding a reference to excel when you call Quit(), Excel can't cleanly shut down. The recommendation is to call Quit(), set excel = null, then run CollectGarbage after a brief wait:

var idTmr = "";

function GetData() { 
    //...

    excel.Quit(); 
    excel = null;
    idTmr = window.setInterval("Cleanup();",1);
}

function Cleanup() {
    window.clearInterval(idTmr);
    CollectGarbage();
}

Original sources:

http://support.microsoft.com/kb/266088

Windows 7 Gadget not releasing ActiveX object

Community
  • 1
  • 1
Simon MᶜKenzie
  • 8,344
  • 13
  • 50
  • 77