My query doesn't work when updating database

Question

I have a form like the following:

<form action="campionat.php?competitii='.$idcompetitie.'">
    <input type="submit" name="upgrade" value="inainte" />
</form>

On campionat.php:

    if($_POST['upgrade']=="inainte")
    {    
        $lvlupstadion   = $levelstadio+1;
        $cost               = 10000000*$lvlupstadion;
        $bugetnou       = $buget - $cost;

        $q = mysql_query("UPDATE echipa SET levelstadion='".$lvlupstadion."' , buget='".$bugetnou."' WHERE (`echipa`='".$echipa."') AND (`user`='".$id."') AND (`competitie`='".$competitie."')") ;
        if (!$q)
        {
            echo  mysql_error($q);
        }
        echo $lvlupstadion.$bugetnou.$echipa.$id.$competitie;
    }

Why my database does not change and my script doesn't alert me about errors?

because your $_POST['upgrade'] is not getting value from form action — Afsar, Jun 26 '13 at 08:28
add like this `mysql_query() or die(mysql_error())` to track the errors. — ejo, Jun 26 '13 at 08:31

score 2 · Answer 1 · edited May 23 '17 at 11:50

The default method of a <form> tag is GET.

Since your form has no method specified, it'll send a get. In which case $_POST['upgrade'] is not available.

If you change

<form action="campionat.php?competitii='.$idcompetitie.'">
    <input type="submit" name="upgrade" value="inainte" />
</form>

to

<form method="post" action="campionat.php?competitii='.$idcompetitie.'">
    <input type="submit" name="upgrade" value="inainte" />
</form>

it should work.

Please refer to this question: What is the default form HTTP method?

score 1 · Answer 2 · edited Jun 20 '20 at 09:12

1

Your form does not have a method, therefore it will default to GET. This is a problem because you are trying to access $_POST['upgrade'] which will never be set.

Set the method to post.

<form method="post" ... >

From W3C docs:

method

Possible (case-insensitive) values are "get" (the default) and "post"

edited Jun 20 '20 at 09:12

Community

1
1

answered Jun 26 '13 at 08:34

MrCode

63,975
10
90
112

sorry for my fault that is the form

– Ashima Petrisor Jun 26 '13 at 09:14

score 1 · Answer 3 · answered Jun 26 '13 at 09:53

1

Your form is missing things . You have to choose between $_GET and $_POST. + What are you doing with $q?

answered Jun 26 '13 at 09:53

Loko

6,539
14
50
78

score 0 · Answer 4 · answered Jun 26 '13 at 08:29

0

If

(`user`='".$id."')

Is an ID (int) you don't need simple quote. It might help you

answered Jun 26 '13 at 08:29

marshallino16

2,645
15
29

1

-1 won't make any difference (please do not submit guesses as answers) – AD7six Jun 26 '13 at 08:30
@AD7six suggestion will be good enough and had an answer either edit it or post it... – Rajeev Ranjan Jun 26 '13 at 08:34
When posted it, there was no anwser yet, so please stop trolling. I just try to help, and you'r just borring me. – marshallino16 Jun 26 '13 at 08:41

score 0 · Answer 5 · answered Jun 26 '13 at 08:33

0

Store the value in hidden field and then send it to another page

<form action="campionat.php" method="post">
<input type="hidden" name="competitii" value="<?php echo $idcompetitie; ?>">
<input type="submit" name="upgrade" value="inainte" />
</form>

your redirection is not sending the value from form post method.

answered Jun 26 '13 at 08:33

Afsar

3,104
2
25
35

1

Moving the id from the url (form action) to a hidden field does not address the original error (which is corrected by this answer, but not mentioned). – AD7six Jun 26 '13 at 08:36

My query doesn't work when updating database

5 Answers5