50

I want to read text data fixtures (CSV files) at the start on my application and put it in my database.

For that, I have created a PopulationService with an initialization method (@PostConstruct annotation).

I also want them to be executed in a single transaction, and hence I added @Transactional on the same method.

However, the @Transactional seems to be ignored : The transaction is started / stopped at my low level DAO methods.

Do I need to manage the transaction manually then ?

Raphael Jolivet
  • 3,940
  • 5
  • 36
  • 56

7 Answers7

96

Quote from legacy (closed) Spring forum:

In the @PostConstruct (as with the afterPropertiesSet from the InitializingBean interface) there is no way to ensure that all the post processing is already done, so (indeed) there can be no Transactions. The only way to ensure that that is working is by using a TransactionTemplate.

So if you would like something in your @PostConstruct to be executed within transaction you have to do something like this:

@Service("something")
public class Something {
    
    @Autowired
    @Qualifier("transactionManager")
    protected PlatformTransactionManager txManager;

    @PostConstruct
    private void init(){
        TransactionTemplate tmpl = new TransactionTemplate(txManager);
        tmpl.execute(new TransactionCallbackWithoutResult() {
            @Override
            protected void doInTransactionWithoutResult(TransactionStatus status) {
                //PUT YOUR CALL TO SERVICE HERE
            }
        });
   }
}
radistao
  • 14,889
  • 11
  • 66
  • 92
Platon
  • 1,513
  • 13
  • 12
  • Is there anyway we can intercept the container's "post processing done" event so that we know transaction is now available? – gerrytan Oct 16 '14 at 00:17
  • @gerrytan I believe that such a thing could be achieved via use of Spring's [ApplicationListener](http://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/context/ApplicationListener.html) which allows for listening on various events including Context lifecycle events. – Platon Oct 16 '14 at 14:22
  • @gerrytan Specifically [ContextRefreshedEvent](http://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/context/event/ContextRefreshedEvent.html) should satisfy your needs. Per [documentation](http://docs.spring.io/spring/docs/current/spring-framework-reference/html/beans.html#context-functionality-events): _"... all beans are loaded, post-processor beans are detected and activated, singletons are pre-instantiated, and the ApplicationContext object is ready for use..."_ – Platon Oct 16 '14 at 14:32
  • @PlatonSerbin For a testing environment is there a way to make sure the `@PostConstruct` is called after the `@Sql` annotation so that during the `@PostConstruct` method I can access the database and load settings? – j will Apr 15 '15 at 19:46
  • 1
    Authoritative source: https://github.com/spring-projects/spring-framework/issues/10670#issuecomment-453340914 – Arend v. Reinersdorff Sep 28 '20 at 14:21
  • This answer saved me an issue that has been rattled all day. I needed to schedule a long running task when Spring boot starts up so it doesnt time out on aws gateway. Service method in different thread couldnt access session. However running it within the transation template saved the day. Thanks alot. – tksilicon Jun 21 '22 at 21:28
  • for me it runs much slower than @EventListener(ContextRefreshedEvent.class) + @Transactional while making 500k updates, 1200 in 6 mins vs 300k in 6 mins – wutzebaer Jul 04 '23 at 19:47
17

I think @PostConstruct only ensures the preprocessing/injection of your current class is finished. It does not mean that the initialization of the whole application context is finished.

However you can use the spring event system to receive an event when the initialization of the application context is finished:

public class MyApplicationListener implements ApplicationListener<ContextRefreshedEvent> {
  public void onApplicationEvent(ContextRefreshedEvent event) {
    // do startup code ..
  }    
}

See the documentation section Standard and Custom Events for more details.

micha
  • 47,774
  • 16
  • 73
  • 80
10

As an update, from Spring 4.2 the @EventListener annotation allows a cleaner implementation:

@Service
public class InitService {

    @Autowired
    MyDAO myDAO;

    @EventListener(ContextRefreshedEvent.class)
        public void onApplicationEvent(ContextRefreshedEvent event) {
        event.getApplicationContext().getBean(InitService.class).initialize();
    }

    @Transactional
    public void initialize() {
        // use the DAO
    }

}

DBE
  • 290
  • 4
  • 9
  • Note that this might call the initialize() method twice, see https://stackoverflow.com/questions/6164573/why-is-my-spring-contextrefreshed-event-called-twice – Stefnotch May 21 '22 at 18:26
8

Inject self and call through it the @Transactional method

public class AccountService {

    @Autowired
    private AccountService self;

    @Transactional
    public void resetAllAccounts(){
        //... 
    }

    @PostConstruct
    private void init(){
        self.resetAllAccounts();
    }

}

For older Spring versions which do not support self-injection, inject BeanFactory and get self as beanFactory.getBean(AccountService.class)

EDIT

It looks like that since this solution has been posted 1.5 years ago developers are still under impression that if a method, annotated with @Transactional, is called from a @PostContruct-annotated method invoked upon the Bean initialization, it won't be actually executed inside of Spring Transaction, and awkward (obsolete?) solutions get discussed and accepted instead of this very simple and straightforward one and the latter even gets downvoted.

The Doubting Thomases :) are welcome to check out an example Spring Boot application at GitHub which implements the described above solution.

What actually causes, IMHO, the confusion: the call to @Transactional method should be done through a proxied version of a Bean where such method is defined.

  1. When a @Transactional method is called from another Bean, that another Bean usually injects this one and invokes its proxied (e.g. through @Autowired) version of it, and everything is fine.

  2. When a @Transactional method is called from the same Bean directly, through usual Java call, the Spring AOP/Proxy machinery is not involved and the method is not executed inside of Transaction.

  3. When, as in the suggested solution, a @Transactional method is called from the same Bean through self-injected proxy (self field), the situation is basically equivalent to a case 1.

igor.zh
  • 1,410
  • 15
  • 19
3

@Platon Serbin's answer didn't work for me. So I kept searching and found the following answer that saved my life. :D

The answer is here No Session Hibernate in @PostConstruct, which I took the liberty to transcribe:

@Service("myService")
@Transactional(readOnly = true)
public class MyServiceImpl implements MyService {

@Autowired
private MyDao myDao;
private CacheList cacheList;

@Autowired
public void MyServiceImpl(PlatformTransactionManager transactionManager) {

    this.cacheList = (CacheList) new TransactionTemplate(transactionManager).execute(new TransactionCallback(){

        @Override
        public Object doInTransaction(TransactionStatus transactionStatus) {

            CacheList cacheList = new CacheList();
            cacheList.reloadCache(MyServiceImpl.this.myDao.getAllFromServer());

            return cacheList;
        }

    });
}
carolnogueira
  • 499
  • 5
  • 10
1

The transaction part of spring might not be initialized completely at @PostConstruct.

Use a listener to the ContextRefreshedEvent event to ensure, that transactions are available:

@Component
public class YourService
    implements ApplicationListener<ContextRefreshedEvent> // <= ensure correct timing!
    {

    private final YourRepo repo;
    public YourService (YourRepo repo) {this.repo = repo;}

    @Transactional // <= ensure transaction!
    @Override
    public void onApplicationEvent(ContextRefreshedEvent event) {
        repo.doSomethingWithinTransaction();
    }
}
slartidan
  • 20,403
  • 15
  • 83
  • 131
0

Using transactionOperations.execute() in @PostConstruct or in @NoTransaction method both works

@Service
public class ConfigurationService implements  ApplicationContextAware {
    private static final Logger LOG = LoggerFactory.getLogger(ConfigurationService.class);
    private ConfigDAO dao;
    private TransactionOperations transactionOperations;

    @Autowired
    public void setTransactionOperations(TransactionOperations transactionOperations) {
        this.transactionOperations = transactionOperations;
    }

    @Autowired
    public void setConfigurationDAO(ConfigDAO dao) {
        this.dao = dao;
    }


    @PostConstruct
    public void postConstruct() {
        try { transactionOperations.execute(new TransactionCallbackWithoutResult() {
                @Override
                protected void doInTransactionWithoutResult(final TransactionStatus status) {
                    ResultSet<Config> configs = dao.queryAll();
                }
            });
        }
        catch (Exception ex)
        {
            LOG.trace(ex.getMessage(), ex);
        }
    }

    @NoTransaction
    public void saveConfiguration(final Configuration configuration, final boolean applicationSpecific) {
        String name = configuration.getName();
        Configuration original = transactionOperations.execute((TransactionCallback<Configuration>) status ->
                getConfiguration(configuration.getName(), applicationSpecific, null));


    }


    @Override
    public void setApplicationContext(ApplicationContext applicationContext) throws BeansException {

    }
}
i.karayel
  • 4,377
  • 2
  • 23
  • 27