c# counting identical strings from text file

Question

I have a foreach statement where I go through several lines from a text file, where I have trimmed down and sorted out the lines I need. What I want to do is count up on how many times an identical string is present. How do I do this?

Here is my code. It's the second if statement where I am stuck:

        foreach (string line in lines.Where(l => l.Length >= 5))
        {
            string a = line.Remove(0, 11);

            if ((a.Contains(mobName) && a.Contains("dies")))
            {

                mobDeathCount++;
            }
            if (a.Contains(mobName) && a.Contains("drops"))
            {
                string lastpart = a.Substring(a.LastIndexOf("drops"));
                string modifiedLastpart = lastpart.Remove(0, 6);

            }

Heres what some of the lines look like:

a bag of coins

a siog brandy

a bag of coins

a bag of coins

the Cath Shield

a tattered scroll

So what im trying to do is counting up there are 3 lines with bag of coins. But i need to make it so that it can be everything, theres a drop lists thats huge. So cant add all of em, would take too long

EDIT

    private static void Main()
    {
        int mobDeathCount = 1;
        int lootCheckCount = 1;

        string[] lines =
            System.IO.File.ReadAllLines(@"C:\Users\Michael\Documents\Electronic Arts\Dark Age of Camelot\chat.log");
        Console.WriteLine(
            "Enter which mob you want to see, remember to include the, for an example; The siog seeker, remember to start with a capital T");
        string mobName = Console.ReadLine();


        foreach (string line in lines.Where(l => l.Length >= 5))
        {




            string a = line.Remove(0, 11);

            if ((a.Contains(mobName) && a.Contains("dies")))
            {

                mobDeathCount++;
            }
            if (a.Contains(mobName) && a.Contains("drops"))
            {
                string lastpart = a.Substring(a.LastIndexOf("drops"));
                string modifiedLastpart = lastpart.Remove(0, 6);

               var lineCountDict = modifiedLastpart.GroupBy(x => x).Where(x => x.Count() > 1).ToDictionary(x => x.Key, x => x.Count());
               foreach (var val in lineCountDict)
               {
                   Console.WriteLine(val.Key + " - " + val.Value);
               }

new lines;

[01:09:55] The siog seeker drops a bag of coins.

[01:09:55] The siog seeker drops a siog brandy.

[01:09:55] The siog seeker dies!

[01:09:55] You get 3,687,564 experience points.(1,638,917 camp bonus)

[01:10:31] You cast a Lesser Disenchanting Eruption spell!

[01:10:31] You hit the siog seeker for 424 (+18) damage!

[01:10:31] The siog seeker drops a bag of coins.

[01:10:31] You pick up 18 silver and 88 copper pieces.

[01:10:31] The siog seeker dies

Answer 1

You can use LINQ to get the number of duplicate lines. This will create a dictionary that contains the string as the key and the number of times that string appears as the value.

var lineCountDict = lines.GroupBy(x => x).ToDictionary(x => x.Key, x => x.Count());

To read out the values, simply iterate through the dictionary So, using your example list

List<String> lines = new List<string>()
     { 
         "a bag of coins",
         "a siog brandy",
         "a bag of coins",
         "a bag of coins",
         "the Cath Shield",
         "a tattered scroll"
     };

var lineCountDict = lines.GroupBy(x => x).ToDictionary(x => x.Key, x => x.Count());

foreach (var val in lineCountDict)
{
     Console.WriteLine(val.Key + " - " + val.Value);
}

This will output each string and how many times it appeared, including those strings that only appear once. If you only want those that are duplicates, you can modify the LINQ query by adding a Whereclause

var lineCountDict = lines.GroupBy(x => x).Where(x => x.Count() > 1).ToDictionary(x => x.Key, x => x.Count());

The dictionary will then have only one item from the list in your example (a bag of coins) and the key would be a bag of coins and the value would be 3 since it appears 3 times.

update based on comments

This should work in your case

List<string> modifiedList = new List<string>();
int numberOfDrops = 0;

foreach (string line in lines.Where(l => l.Length >= 5))
{
     string ad = line.Remove(0, 11);

     if ((ad.Contains(mobName) && ad.Contains("dies")))
     {
        mobDeathCount++;
     }
     if (ad.Contains(mobName) && ad.Contains("drops"))
     {
         string lastpart = ad.Substring(ad.LastIndexOf("drops"));
         string modifiedLastpart = lastpart.Remove(0, 6);
         modifiedList.Add(modifiedLastpart);
         numberOfDrops++;
     }

}

double deathDropRatio = (double)mobDeathCount / (double)numberOfDrops;

var lineCountDict = modifiedList.GroupBy(x => x).Where(x => x.Count() > 1).ToDictionary(x => x.Key, x => x.Count());

foreach (var val in lineCountDict)
{
   Console.WriteLine(val.Key + " - " + val.Value);
}

Answer 2

I like to use a Dictionary for this.

Dictionary<string, int> dict = new Dictionary<string, int>();
foreach (string s in yourStringList) {
    if (dict.ContainsKey(s)) {
        dict[s] = ++dict[s];
    } else {
        dict[s] = 1;
    }
}

Your strings are the keys of the dictionary, and the count of the number of times each appears is the value.

(Disclaimer: didn't test code; may require minor tweaks.)

Answer 3

I think this is what you want:

Dictionary<string, int> dropsDict = new Dictionary<string, int>();    

foreach (string line in lines.Where(l => l.Length >= 5))
{
     string a = line.Remove(0, 11);

     if ((a.Contains(mobName) && a.Contains("dies")))
     {
         mobDeathCount++;
     }

     if (a.Contains(mobName) && a.Contains("drops"))
     {
         string lastpart = a.Substring(a.LastIndexOf("drops"));
         string modifiedLastpart = lastpart.Remove(0, 6);

         if (dropsDict.ContainsKey(modifiedLastpart)) 
         {
             dropsDict[modifiedLastpart] = dropsDict[modifiedLastpart]++;
         } 
         else 
         {
             dropsDict[modifiedLastpart] = 1;
         }
     }
}

Answer 4

If you are trying to find how many strings match in all of the lines array(i mean like - "string one" appears 2 times - and - "string two" appears 4 times),create a dictionary outside the foreach and first thing inside foreach place this:

Dictionary<string, int> same = new Dictionary<string, int>();

foreach (string line in lines)
{
      if (same.ContainsKey(line))
          ++same[line];
      else
          same.Add(line, 1);

      //......
      //do your other stuff
}

Each string that repeats will be updated in the value of dictionary(inside the dictionary will be recorded all strings and how many times they appeared),with that you can check how many times a certain string appeared.

Answer 5

Maybe this can help you, it's a pice of code thats counts all the duplicate strings in a collection. You have to modify it to suit your needs, but hope you the point.

   var allStrings = new  List<string>{"stringOne", "stringOne", "stringTwo", "stringOne", "stringThree", "stringTwo"};
   var allStringsGrouped = allStrings.GroupBy(i => i);
   foreach (var group in allStringsGrouped)
   {
       System.Diagnostics.Debug.WriteLine(group.Key +" occured " + group.Count() + " times");
   }

Output is as following:

stringOne occured 3 times
stringTwo occured 2 times
stringThree occured 1 times