58

I have this simple code:

<xsl:for-each select="GroupsServed">
  <xsl:value-of select="."/>,<br/>
</xsl:for-each></font>

I'm trying to add a comma for each item added.

This has 2 flaws:

  1. Case of when there's only 1 item: the code would unconditionally add a comma.
  2. Case of when there's more than 1 item: the last item would have a comma to it.

What do you think is the most elegant solution to solve this?

I'm using XSLT 2.0

sivabudh
  • 31,807
  • 63
  • 162
  • 228

4 Answers4

91

If you're using XSLT 2.0, the canonical answer to your problem is

<xsl:value-of select="GroupsServed" separator=", " />

On XSLT 1.0, the somewhat CPU-expensive approach to finding the last element in a node-set is

<xsl:if test="position() = last()" />
Stobor
  • 44,246
  • 6
  • 66
  • 69
  • I shouldn't try to answer these questions via a phone. I've added the detail on the XSLT2.0 method, in case it wasn't clear earlier. – Stobor Nov 16 '09 at 07:05
  • 2
    Couldn't get this syntax to work, if by any chance you could help on this one... https://stackoverflow.com/questions/62005912/xslt3-joining-values-with-separator – ILoveCoding May 25 '20 at 17:41
31

Final answer:

<xsl:for-each select="GroupsServed">
  <xsl:value-of select="."/>                                    
  <xsl:choose>
    <xsl:when test="position() != last()">,<br/></xsl:when>
  </xsl:choose>
</xsl:for-each>
sivabudh
  • 31,807
  • 63
  • 162
  • 228
4
<xsl:variable name="GROUPS_SERVED_COUNT" select="count(GroupsServed)"/>
<xsl:for-each select="GroupsServed">
    <xsl:value-of select="."/>
    <xsl:if test="position() < $GROUPS_SERVED_COUNT">
        ,<br/>
    </xsl:if>
</xsl:for-each></font>
Grigory K
  • 1,301
  • 10
  • 10
2

Insert the column delimiter before each new item, except the first one. Then insert the line break outside the for-each loop.

<xsl:for-each select="GroupsServed">
  <xsl:if test="position() != 1">,</xsl:if>
  <xsl:value-of select="."/>
</xsl:for-each>
<br/>

In other words, treat every item like the last item. The exception is that the first item does not need a comma separator in front of it. The loop ends after the last item is processed, which also tells us where to put the break.

Damian
  • 1,385
  • 10
  • 10