Spring-Security PasswordEncoder returns null

Question

I have implemented Spring security on my struts2 application and it perfectly works, but it runs into error java.lang.NullPointerException on line 3.

Although it seems passwordEncoder configuration works as by adding those I cant login with a plain text password any more.

 <authentication-manager> 
        <authentication-provider>
           <password-encoder ref="passwordEncoder"/>

            <jdbc-user-service data-source-ref="dataSource"

                           users-by-username-query="
              select username,password,enabled 
              from Users where username=?" 

                           authorities-by-username-query="
                      select username,authority 
                      from Users where username = ?"

        />
        </authentication-provider> 

    </authentication-manager> 
    <beans:bean id="passwordEncoder" 
        xmlns="http://www.springframework.org/schema/beans"            
        class="org.springframework.security.authentication.encoding.ShaPasswordEncoder">
        <constructor-arg value="256"/>
    </beans:bean>
</beans:beans>

MyClass.java

    import org.springframework.security.authentication.encoding.ShaPasswordEncoder;;
    ....
    private ShaPasswordEncoder passwordEncoder;

     public ShaPasswordEncoder getPasswordEncoder() {
         return passwordEncoder;
     }
     @Autowired
     public void setPasswordEncoder(ShaPasswordEncoder passwordEncoder) {
           this.passwordEncoder = passwordEncoder;
      }

     public void encode(String username)
        {
1             System.err.println("encode password");
2             String encodedPassword = "";
3             encodedPassword = passwordEncoder.encodePassword("Jack",username);
4             System.err.println("encoded password " + encodedPassword);
        }

pom.xml

   <dependency>
            <groupId>org.springframework</groupId>
            <artifactId>spring-webmvc</artifactId>
            <version>3.1.1.RELEASE</version>
        </dependency>
        <dependency>
            <groupId>org.springframework.security</groupId>
            <artifactId>spring-security-web</artifactId>
            <version>3.1.1.RELEASE</version>
        </dependency>
        <dependency>
            <groupId>org.springframework.security</groupId>
            <artifactId>spring-security-core</artifactId>
            <version>3.1.1.RELEASE</version>
        </dependency>
        <dependency>
            <groupId>org.springframework.security</groupId>
            <artifactId>spring-security-taglibs</artifactId>
            <version>3.1.1.RELEASE</version>
        </dependency>
        <dependency>
            <groupId>org.springframework.security</groupId>
            <artifactId>spring-security-config</artifactId>
            <version>3.1.1.RELEASE</version>
        </dependency>

score 3 · Answer 1 · edited May 23 '17 at 12:21

3

Do you actually inject the encoder into Encode.java somehow somewhere? If not,then that is your problem.

if you need a quick and dirty solution which will probably work. just make it

 private ShaPasswordEncoder passwordEncoder=new ShaPasswordEncoder(256);

and then find out what you are doing wrong with the injection.

maybe read this to see how injection should be done.

What is the difference between @Inject and @Autowired in Spring Framework? Which one to use under what condition?

edited May 23 '17 at 12:21

Community

1
1

answered Jul 05 '13 at 00:06

Markus Mikkolainen

3,397
18
21

no what should I do ? I have no idea and could not find anything in tutorials – J888 Jul 05 '13 at 00:08
use an annotation or xml to inject that bean instance named "passwordEncoder" to your Encode.java. Read the spring manual on how to inject stuff. – Markus Mikkolainen Jul 05 '13 at 00:09
@JackRamzi `@Autowired` is placed on setter method or field property. – Roman C Jul 05 '13 at 10:01
@RomanC Ive placed it on setter but still runs into same error – J888 Jul 07 '13 at 23:34
Have you `` enabled? Otherwise `@Autowired` will not get interpretted. – Pavel Horal Jul 09 '13 at 14:48
@JackRamzi Post the stacktrace. – Roman C Jul 10 '13 at 13:32
Is your MyClass instance spring managed bean? Do you have somewhere in the config, or is it annotated as component? – Krešimir Nesek Jul 10 '13 at 16:49

score 3 · Answer 2 · answered Jul 14 '13 at 09:57

@Autowired will work only on Spring managed beans. So your MyClass should be a @Service or @Repository or @Component etc (or it may be simply configured in your XML as a <bean>)

Also, I don't understand your

I cant login with a plain text password any more.

The encoding of the user entered password and the comparison with the encoded password from the database is done by spring security internally. All it needs is a UserDetails object which will be provided by your jdbc-user-service.

I used the @Service but still have the same problem ! – J888 Jul 18 '13 at 23:46 — J888, Jul 18 '13 at 23:46

Spring-Security PasswordEncoder returns null

2 Answers2

Linked