Why wont this object get created? c++

Question

Here is my main. All I am trying to do is create an object of the class file, this is probably a very noobish question so sorry, just need to know what I'm doing wrong.

#include <iostream>
#include "Player.h"

using std::cout;
using std::cin;

int main()
{
    cout << "Hello and welcome to the student adventures game.\n";

    Player player1();
}

+1 because there is people who prefer to downvote over teaching. — Theraot, Jul 07 '13 at 11:15
@Theraot: my downvote was to teach, to teach that this was a bad question. How does he detect that this object is not created? It should compile (cannot know for sure without `PLayer.h`), he doesn't ever use player1, so what's the exact error? — KillianDS, Jul 07 '13 at 11:18
This is a duplicate and should be closed. I'm in a minority that thinks that just because something is a duplicate it shouldn't be downvoted — Armen Tsirunyan, Jul 07 '13 at 11:19
@KillianDS thank you by explaining your downvote, was it that hard? If this was asked, it is because the asker knows no better, a downvotes alone aren't going to fix that problem. I understand that you only answer "good question", but those who ask "bad questions" are those who need more help. Also, as for not using the variable, I guess that is his take on being minimal on examples. — Theraot, Jul 07 '13 at 11:23
+1 for *not* having `using namespace std` at the top of your code. — Derek, Jul 07 '13 at 14:00
+1 For a clear and concise question, even if it does happen to be a dupe. — Code-Apprentice, Jul 07 '13 at 15:06

billz · Answer 1 · 2013-07-07T13:34:21.020

14

You declared a function which return Player type, see most vexing parse

To define an object, try update

Player player1();

to

Player player1;

edited Jul 07 '13 at 13:34

answered Jul 07 '13 at 11:15

billz

44,644
9
83
100

4

Downvoter, explain plz – billz Jul 07 '13 at 11:16
ahh, I knew it would be obvious, thanks a lot you've really helped me out :) – Benjamin-Cox Jul 07 '13 at 11:16
@Benjamin-Cox See http://stackoverflow.com/questions/1424510/most-vexing-parse-why-doesnt-a-a-work for details – SomeWittyUsername Jul 07 '13 at 11:19
Doesn't forgetting to return an integer in ``main`` also cause an error? – halflings Jul 07 '13 at 11:21
1

by default, it returns 0 in main, see [this link](http://stackoverflow.com/questions/14853114/visual-studio-strange-behavior/14853204#14853204) – billz Jul 07 '13 at 11:22
@halflings no, main will return 0 by default. – Luchian Grigore Jul 07 '13 at 11:22
@halflings, Worth noting that it's undefined behaviour not to return from other non-void functions, not a compiler error. – chris Jul 07 '13 at 12:11
Moving from java I guess ... – rednaks Jul 07 '13 at 13:15
@billz didn't downvote since I've confused them too (until recently), but I've been told a few days ago that this is **not** the most vexing parse. That would look like `Player player1(string name())` or something like this. – Nov 13 '13 at 20:51

score 4 · Answer 2 · edited Jul 07 '13 at 11:23

4

You shouldn't use the parenthesis when declaring an object without parameters, or else the compiler will think you're declaring a function that returns a Player and that takes no parameter.

edited Jul 07 '13 at 11:23

Luchian Grigore

253,575
64
457
625

answered Jul 07 '13 at 11:16

halflings

1,540
1
13
34

I always wondered what the return 0 was for lol, and yes thats got it, thanks a lot. – Benjamin-Cox Jul 07 '13 at 11:22
3

Hope the edit is okay, I removed the irrelevant (& wrong) part. – Luchian Grigore Jul 07 '13 at 11:24

Why wont this object get created? c++

2 Answers2