I just want to know whats wrong in this java script code?

Question

Here is the code:

var compare = function (choice1, choice2) {
    if (choice1 === choice2) {
        return ("The result is a tie!");
    } else if (choice1 = "Rock") {
        if (choice2 = "Scissorsr") {
            return "rock Wins!";
        } else if (choice2 = "Paper") {
            return "paper Wins!";
        }
    } else if (choice1 = "paper") {
        if (choice2 = "Rock") {
            return "paper wins";
        } else if (choice2 = "Scissors") {
            return "scissors wins!";
        }
    }
};

I was learning java script in codecademy and after submitting the code it gets me the error saying

Your compare function doesn't return the correct string when comparing paper to rock.

Also, you misspelled `"Scissors"` in `if (choice2 = "Scissorsr") {`. I also think you want to capitalize `"Paper"` in `} else if (choice1 = "paper") {`. Just do some proofreading. — Mattias Buelens, Jul 07 '13 at 13:45
[Learn how to **debug** JavaScript](http://www.netmagazine.com/tutorials/javascript-debugging-beginners). — Felix Kling, Jul 07 '13 at 13:48
I think we need a reference question for this, this comes up far too often. — Felix Kling, Jul 07 '13 at 13:48

score 4 · Accepted Answer · answered Jul 07 '13 at 13:44

4

choice1="paper" is an assignment, not a comparison. Use === for comparisons (unless you need type coercion, in which case use ==)

answered Jul 07 '13 at 13:44

Quentin

914,110
126
1,211
1,335

as i am a begginer, whats the actual difference between == and === (though i now know === is for comparisions) – Pavan Nadig Jul 07 '13 at 14:02
@Pavan: see http://stackoverflow.com/q/359494/218196 – Felix Kling Jul 07 '13 at 14:09

score 0 · Answer 2 · answered Jul 07 '13 at 13:48

This should work...

var compare = function(choice1,choice2) {
   if (choice1===choice2) {
        return("The result is a tie!");
   }
   else if (choice1 == "Rock") {
       if (choice2 == "Scissors") {
            return "rock Wins!";}
       else if(choice2 == "Paper") {
            return "paper Wins!";
       }
   }

   else if (choice1 == "paper") {
       if (choice2 == "Rock") {
            return "paper wins";}
       else if (choice2 == "Scissors") {
            return "scissors wins!";
       }
   }
};

ok so now i get the answer! :/ as i am a beginner, whats the actual difference between == and === — Pavan Nadig, Jul 07 '13 at 13:52

I just want to know whats wrong in this java script code?

2 Answers2