Javascript: how to override public method in some class?

Question

I have such JS class that have to be tested:

SomeClass = function {  
    // some stuff that uses initRequest    
    this.initRequest = function() {  
        if (window.XMLHttpRequest) {  
            return new XMLHttpRequest();  
        } else if (window.ActiveXObject) {  
            return new ActiveXObject("Microsoft.XMLHTTP");  
        }   
     }  
}

I want to override method initRequest for testing purposes. I tried to do something like that

var request = new MockXmlHttpRequest();  
var instance = new SomeClass();
instance.initRequest = function() {
    return request;
};
// some calls of the SomeClass methods that use initRequest
// some test code with assertions for the request

Still calling of the initRequest method calls actually the original code, but not the function that I tried to pass to instance.initRequest.

Any ideas what's wrong?

score 0 · Answer 1 · answered Mar 07 '13 at 02:25

0

SomeClass.prototype.initRequest = function() 
  {  
  return request;
  }

answered Mar 07 '13 at 02:25

Paul Sweatte

24,148
7
127
265

score 0 · Answer 2 · answered Nov 18 '09 at 12:56

Check out YUI's extend functionality. It makes all this really clean, PLUS, you can still access the method of the super class if you really want to. Their augment object might also be of interest to you.

Here is the link http://developer.yahoo.com/yui/examples/yahoo/yahoo_extend.html

score 0 · Answer 3 · answered Nov 18 '09 at 14:40

0

In your first example, initRequest returns a new object after each call; in the second example, all calls to initRequest return a reference to the one and only (mock) object.

The request object is not changed in the code example you provide. instance.initRequest simple returns a reference to request. Why do expect it to have changed?

answered Nov 18 '09 at 14:40

Upperstage

3,747
8
44
67

Because of // some calls of the SomeClass methods that uses initRequest – DixonD Nov 20 '09 at 02:13
Have you used FireBug to examine request before and after the call? I find FireBug indispensable. Maybe you could post additional code? – Upperstage Nov 20 '09 at 18:16

score 0 · Answer 4 · answered Nov 19 '09 at 00:57

I'm having a little trouble understanding your question because of your English, but I'll try to answer anyway (and if I answer the wrong question just let me know).

I think what you want to do is:

SomeClass = function {  
    // some stuff that uses initRequest    
    this.initRequest = function() {  
        return request;
     }  
}

In other words, you want to overwrite the original SomeClass object with a new function. Unless you do that new SomeClass objects won't use your test method, they'll just use the original method.

However, if you only want to override that method for a specific object, not for the whole class, what you have there should work. If that's the case, could you please clarify what exactly isn't working about it?

ajukraine · Answer 5 · 2011-11-01T23:53:55.167

-1

First of all, this code sample is not the best way of OOP in JavaScript - use prototype instead. Another remark, your sample throws error in my browser (invalid declarartion of SomeClass function, maybe it's only typing mistake). And at last, instance.initRequest actually returns (I've run it at Google Chrome) object you have expected - check please my sample.

edited Nov 01 '11 at 23:53

answered Nov 01 '11 at 23:11

ajukraine

561
9
27

Javascript: how to override public method in some class?

5 Answers5